Hi,
On Thu, Feb 22, 2018 at 2:17 AM, Gert Doering wrote:
> Acked-by: Gert Doering
>
> Thanks.
>
> (Stared-at-code, stared-at-compiler output on 16.04, before and after)
>
> Your patch has been applied to the release/2.4 branch.
>
>
Wow, that's pretty early morning over there for patch merging..
Acked-by: Gert Doering
Thanks.
(Stared-at-code, stared-at-compiler output on 16.04, before and after)
Your patch has been applied to the release/2.4 branch.
commit 6ff5957cd3eb951b2053fc01665d45214b14c8e8
Author: Selva Nair
Date: Wed Feb 21 23:33:37 2018 -0500
Fix format spec errors
Hi
On Thu, Feb 22, 2018 at 1:46 AM, Илья Шипицин wrote:
>
>
> 2018-02-22 8:52 GMT+05:00 Selva Nair :
>>
>> Hi,
>>
>> On Wed, Feb 21, 2018 at 10:18 PM, Илья Шипицин
>> wrote:
>> >
>> >
>> > 2018-02-21 22:03 GMT+05:00 Selva Nair :
>> >>
>> >> Hi,
>> >>
>> >> On Tue, Feb 20, 2018 at 10:10 AM, Илья
2018-02-22 8:52 GMT+05:00 Selva Nair :
> Hi,
>
> On Wed, Feb 21, 2018 at 10:18 PM, Илья Шипицин
> wrote:
> >
> >
> > 2018-02-21 22:03 GMT+05:00 Selva Nair :
> >>
> >> Hi,
> >>
> >> On Tue, Feb 20, 2018 at 10:10 AM, Илья Шипицин
> >> wrote:
> >> > Hello,
> >> >
> >> > is there any step-by-step ex
Hi,
On Wed, Feb 21, 2018 at 10:18 PM, Илья Шипицин wrote:
>
>
> 2018-02-21 22:03 GMT+05:00 Selva Nair :
>>
>> Hi,
>>
>> On Tue, Feb 20, 2018 at 10:10 AM, Илья Шипицин
>> wrote:
>> > Hello,
>> >
>> > is there any step-by-step example of implementing either static or
>> > dynamic
>> > challenge re
From: Selva Nair
- "%ll" is not supported by Windows run time, so use PRIi64
and cast the variable to (int64_t) in output statements
(as in commit 9ba36639abcac4367c8227d2dd87b18fb56267c4)
- Fix an instance of wchar_t * printed using %s -- should be %ls.
- Cast variables to int or unsigne
From: Selva Nair
- Correct an instance of %s used for wchar_t * (should be %ls)
and some %d for DWORD or %lu for int.
- Cast socket descriptor to (int) during i/o as its unsigned int
or int64 in Windows but signed int in other platforms.
Signed-off-by: Selva Nair
---
Unlike master, use of %
Hi,
Hope this still can get in to 2.4.5
On Tue, Feb 20, 2018 at 11:00 AM, Gert Doering wrote:
> When adding / removing IPv6 routes, the host bits need to be zeroed or
> netsh.exe will refuse to handle the route.
>
> Commit a24dd2e31 changed the way this is done, breaking removal of
> the on-link
2018-02-21 22:03 GMT+05:00 Selva Nair :
> Hi,
>
> On Tue, Feb 20, 2018 at 10:10 AM, Илья Шипицин
> wrote:
> > Hello,
> >
> > is there any step-by-step example of implementing either static or
> dynamic
> > challenge response ?
>
> Static is easy:
> On client: add --static-challenge "Enter OTP" 1
Acked-by: Gert Doering
Tested on OpenSolaris (since this one of my buildslaves), and the problem
goes away. So I assume Centos6 should be fine, too.
AIX7 is still working :)
Your patch has been applied to the master and release/2.4 branch.
commit 6a5d10e96b9ad2f9a9472aeee8cdb7c02fe4d050 (mast
Acked-by: Gert Doering
"because it's an obvious typo" :)
Your patch has been applied to the master and release/2.4 branch.
commit 7bba4007824cc7fe7ba487210222b546de9269f0 (master)
commit d0f0c7549e0822045e8c3bc6ce050b4fad6c610a (release/2.4)
Author: Antonio Quartulli
Date: Fri Jan 12 17:14:14
Acked-by: Gert Doering
Patch matches the problem discussed in the mail thread here and on
stackoverflow (RRF_RT_REG_SZ|RRF_RT_REG_EXPAND_SZ broken on Win7),
cross compiled on ubuntu 16.04, installed & tested on Win7/64, and
works again :-)
Thanks.
Your patch has been applied to the master and
The macro was too new for some of the platforms we still support. In
particular, centos/rhel 6 and opensolaris 10. To work around that, we
introduce our own simpler and more tailored ACL_CHECK_ADD_COMPILE_FLAGS
macro, that not only checks but also sets the flags in CFLAGS if it is
accepted. Sinc
Acked-by: Gert Doering
Tested on the OpenBSD 6.0 buildslave that was failing previously, and
things are happy now (did not test "FreeBSD + LibreSSL", that's a
different issue which we might want to fix, but since it's not the
default SSL library there, it's not as annoying as OpenBSD breakage.
F
From: Selva Nair
- RegGetValue with flags = RRF_RT_REG_SZ|RRF_RT_REG_EXPAND_SZ
fails in Windows 7 with an "invalid parameter" error.
Fix by using RRF_RT_REG_SZ alone.
Note: This is not a regression as in no released version did the
service support expandable strings (ones with embedded %FOO%
Hi,
On Tue, Feb 20, 2018 at 10:10 AM, Илья Шипицин wrote:
> Hello,
>
> is there any step-by-step example of implementing either static or dynamic
> challenge response ?
Static is easy:
On client: add --static-challenge "Enter OTP" 1 to the client config.
On server, merge my auth-pam plugin patch
Am 21.02.18 um 17:46 schrieb selva.n...@gmail.com:
> From: Selva Nair
>
> - This codepath uses some openssl-1.1 specific API and is enabled only
> for openssl 1.1 and higher versions. But, due to incompatible
> version numbering in libressl, it gets wrongly enabled with libressl
> versions
From: Selva Nair
- This codepath uses some openssl-1.1 specific API and is enabled only
for openssl 1.1 and higher versions. But, due to incompatible
version numbering in libressl, it gets wrongly enabled with libressl
versions that do not support the reqired API. As an easy workaround
di
Hi,
well, today is the day that I get to break things, it seems...
On Sat, Nov 18, 2017 at 12:40:58PM -0500, selva.n...@gmail.com wrote:
> +/* The default value of REG_KEY is the install path */
> +if (GetRegString(key, NULL, install_path, sizeof(install_path), NULL) !=
> ERROR_SUCCESS)
When adding / removing IPv6 routes, the host bits need to be zeroed or
netsh.exe will refuse to handle the route.
Commit a24dd2e31 changed the way this is done, breaking removal of
the on-link IPv6 prefix for windows + netsh.exe.
Fix by adding explicitly calling route_ipv6_clear_host_bits() from
Hi,
On Tue, Feb 20, 2018 at 7:23 AM, Gert Doering wrote:
> Acked-by: Gert Doering
>
> "Because it makes sense" (checked with the Windows API documentation, and
> compile-tested on ubuntu 16.04).
>
> Your patch has been applied to the master and release/2.4 branch.
>
> There was one issue with yo
Hi,
On Tue, Feb 20, 2018 at 03:35:02PM +0100, Gert Doering wrote:
> Jan Just, could you please test the following patch? This will explicitly
> clear the host bits for the "on-link" route again.
>
> Fully untested :-)
And indeed, it does not link, because route_ipv6_clear_host_bits() isn't
expo
Hi,
On Tue, Feb 20, 2018 at 7:03 AM, Gert Doering wrote:
> Hi,
>
> On Tue, Feb 20, 2018 at 11:30:35AM +0100, Gert Doering wrote:
>> Your patch has been applied to the master branch.
>>
>> (I have not done any real review on it, except "compile test" and "stare
>> a bit at the code for really obvi
Hi,
On Tue, Feb 20, 2018 at 3:20 AM, Gert Doering wrote:
> Hi,
>
> On Mon, Feb 19, 2018 at 03:26:34PM -0500, selva.n...@gmail.com wrote:
>> - In route.c print adapter_index as unsigned int as in the rest
>> of the code.
>
> That one confuses me, but that is most likely me vs. windows types.
>
>
Hello,
is there any step-by-step example of implementing either static or dynamic
challenge response ?
Cheers,
Ilya Shipitsin
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdo
25 matches
Mail list logo
