Hi, On Tue, Feb 20, 2018 at 7:23 AM, Gert Doering <g...@greenie.muc.de> wrote: > Acked-by: Gert Doering <g...@greenie.muc.de> > > "Because it makes sense" (checked with the Windows API documentation, and > compile-tested on ubuntu 16.04). > > Your patch has been applied to the master and release/2.4 branch. > > There was one issue with your patch that you might want to look into - it > seems to be based on a private branch that has a "#define REG_KEY" which > does not exist in my tree, and which I could not find any references to > on the mailing list either. It broke applying the patch as it appeared > in patch context - but since none of the actual code line reference this, > I decided to apply the patch nonetheless (it has been lingering for way > too long already).
That line got removed by the following commit (multiple service instances): commit f3fec49b1c916a701058ef2445b4c07005c30673 Author: Simon Rozman <si...@rozman.si> Date: Sun Dec 3 22:16:54 2017 +0100 openvpnserv: Add support for multi-instances So it was a rebase conflict. I scanned through the patch as applied and all look ok. Thanks, Selva ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel