Re: [Openvpn-devel] openvpnserv building under MSVC

2017-10-10 Thread Simon Rozman
Hi, > This sounds good. Please send patches (preferably with git-send-email, in > reasonable chunks) to the list so we can review and merge. Please rebase on > top of master. > > "Reasonable chunks" is a very subjective thing, of course :-) - in this case I'd > group the MSVC specific things in

[Openvpn-devel] [PATCH 05/13] Function prototypes are declared as "typedef ( *type_name)()" in MSVC.

2017-10-10 Thread simon
From: Simon Rozman Note: NETIOAPI_API is defined as: #define NETIOAPI_API NETIO_STATUS NETIOAPI_API_ #define NETIOAPI_API_ WINAPI I am not sure whether interactive.c will compile using mingw with this patch. If not: 1. We can introduce some #ifdef _MSC_VER #else #endif 2. Since NTDDI_V

[Openvpn-devel] [PATCH 10/13] msvc-generate.vcxproj project file upgraded to Visual Studio 2017

2017-10-10 Thread simon
From: Simon Rozman 1. The project file was ported to VS2017. 2. All non-essential settings reset to MSVC defaults. 3. -ls flags added to NMake to reduce output clutter. --- build/msvc/msvc-generate/msvc-generate.vcxproj | 42 +- .../msvc-generate/msvc-generate.vcxproj.fil

[Openvpn-devel] [PATCH 11/13] openvpn.vcxproj temporarily disabled from building in openvpn.sln until we re-establish MSVC building for it

2017-10-10 Thread simon
From: Simon Rozman --- openvpn.sln | 2 -- 1 file changed, 2 deletions(-) diff --git a/openvpn.sln b/openvpn.sln index 9f50f11..ac865bb 100644 --- a/openvpn.sln +++ b/openvpn.sln @@ -22,9 +22,7 @@ Global {9C91EE0B-817D-420A-A1E6-15A5A9D98BAD}.Release|Win32.ActiveCfg = Release|W

[Openvpn-devel] [PATCH 04/13] Local functions are not supported in MSVC. Bummer.

2017-10-10 Thread simon
From: Simon Rozman --- src/openvpnserv/interactive.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index 2019d38..7ff45b1 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c

[Openvpn-devel] [PATCH 09/13] Signed/unsigned warnings of MSVC resolved

2017-10-10 Thread simon
From: Simon Rozman --- src/openvpn/block_dns.c | 2 +- src/openvpnserv/automatic.c | 2 +- src/openvpnserv/common.c | 2 +- src/openvpnserv/interactive.c | 4 ++-- src/openvpnserv/validate.c| 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/openvpn/block_

[Openvpn-devel] [PATCH 13/13] x64 MSVC configurations introduced

2017-10-10 Thread simon
From: Simon Rozman --- .gitignore | 1 + build/msvc/msvc-generate/msvc-generate.vcxproj | 42 -- msvc-env.bat | 1 - openvpn.sln| 16 ++ src/compat/compat.vcxproj

[Openvpn-devel] [PATCH 08/13] MSVC meta files added to .gitignore list

2017-10-10 Thread simon
From: Simon Rozman --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 30e289b..4543674 100644 --- a/.gitignore +++ b/.gitignore @@ -17,6 +17,7 @@ Release Debug Win32-Output +.vs .deps .libs Makefile @@ -55,6 +56,7 @@ distro/systemd/*.service

[Openvpn-devel] [PATCH 06/13] openvpnserv.vcxproj project file recreated using Visual Studio 2017

2017-10-10 Thread simon
From: Simon Rozman 1. The project file was created from scratch. 2. XML nodes were reordered to match old project order for easier diff-ing. 3. All non-essential settings reset to MSVC defaults. 4. .h/.c file list updated. 5. Missing /I include paths added. 6. List of required .lib files updated.

[Openvpn-devel] [PATCH 12/13] Memory size arithmetic reviewed according to 64-bit MSVC complaints

2017-10-10 Thread simon
From: Simon Rozman --- src/openvpnserv/automatic.c | 14 -- src/openvpnserv/interactive.c | 12 ++-- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/src/openvpnserv/automatic.c b/src/openvpnserv/automatic.c index 6c39aaa..3e8f6ed 100644 --- a/src/openvpnser

[Openvpn-devel] [PATCH 03/13] RtlIpv6AddressToStringW() and RtlIpv4AddressToStringW() require mstcpip.h

2017-10-10 Thread simon
From: Simon Rozman --- src/openvpnserv/interactive.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index 4b08086..2019d38 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -33,6 +33,7 @@ #include

[Openvpn-devel] [PATCH 01/13] snwprintf() => _snwprintf()

2017-10-10 Thread simon
From: Simon Rozman --- src/openvpnserv/interactive.c | 12 ++-- src/openvpnserv/validate.c| 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index fe9c7d6..9d473e4 100644 --- a/src/openvpnserv/interact

[Openvpn-devel] [PATCH 02/13] Mixing wide and regular strings in concatenations is not allowed in MSVC.

2017-10-10 Thread simon
From: Simon Rozman --- src/openvpnserv/interactive.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index 9d473e4..4b08086 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@

[Openvpn-devel] [PATCH 07/13] compat.vcxproj project file upgraded to Visual Studio 2017

2017-10-10 Thread simon
From: Simon Rozman 1. The project file was ported to VS2017. 2. All non-essential settings reset to MSVC defaults. --- src/compat/compat.vcxproj | 36 +--- src/compat/compat.vcxproj.filters | 4 ++-- 2 files changed, 19 insertions(+), 21 deletions(-) dif

Re: [Openvpn-devel] openvpnserv building under MSVC

2017-10-10 Thread Gert Doering
Hi, On Tue, Oct 10, 2017 at 12:22:22PM +, Simon Rozman wrote: > Unfortunately, maintaining a mingw build environment for our own OpenVPN > binaries is an overkill. Therefore, in the first stage, I have updated the > Microsoft Visual Studio C++ project files to be able to compile > openvpnse

Re: [Openvpn-devel] openvpnserv building under MSVC

2017-10-10 Thread Simon Rozman
No, I have fixed it to build using locally installed Visual Studio 2017 Community Edition. It really wasn't much trouble. Somebody just needed to wipe the dust off it and fix some things that got out of sync as OpenVPN development continued over years. I am preparing separate patches for

Re: [Openvpn-devel] openvpnserv building under MSVC

2017-10-10 Thread Илья Шипицин
wow. did you try to build it on App Veyor ? (I tried, no success) 2017-10-10 17:22 GMT+05:00 Simon Rozman : > Hi! > > It's me again - author of the eduVPN client for Windows. This time I have a > new problem. And, a solution I'd like to share with OpenVPN community. > > I am considering bundling

[Openvpn-devel] openvpnserv building under MSVC

2017-10-10 Thread Simon Rozman
Hi! It's me again - author of the eduVPN client for Windows. This time I have a new problem. And, a solution I'd like to share with OpenVPN community. I am considering bundling openvpn.exe, openvpnserv.exe, and standard TAP drivers with eduVPN client to allow some degree of independence from st