Hi, On Tue, Oct 10, 2017 at 12:22:22PM +0000, Simon Rozman wrote: > Unfortunately, maintaining a mingw build environment for our own OpenVPN > binaries is an overkill. Therefore, in the first stage, I have updated the > Microsoft Visual Studio C++ project files to be able to compile > openvpnserv.exe again: > - Project files were updated to Microsoft Visual Studio C++ 2017 Community > Edition. > - Some minor updates were made to .h/.c files to compile using MSVC again. > - Support for x64 platform was added. > - All MSVC warnings were addressed and fixed. > > Can I deliver the patches for above?
This sounds good. Please send patches (preferably with git-send-email,
in reasonable chunks) to the list so we can review and merge. Please
rebase on top of master.
"Reasonable chunks" is a very subjective thing, of course :-) - in this
case I'd group the MSVC specific things into one patch (like, project
files and such), and the rest into one or more patches depending on the
number of changes.
MSVC-only things are easier to review as there won't be any impact to
other platforms or build systems, while generic "fix warning" patches
have the tendency to introduce warnings elsewhere (like, printf()
format specifiers vs. "what is a time_t" being a prime example).
Anyway, thanks for dusting off these corners :-)
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
