Re: [Openvpn-devel] [PATCH] resolve format string warnings

2017-03-27 Thread Gert Doering
Hi, On Tue, Mar 28, 2017 at 11:43:11AM +0500, ?? wrote: > > (See how dangerous "fixing compiler warnings" is? :-) ) > > this particular warning came from cppcheck, it's not a compiler warning Same thing. A tool that issues a warning which is not relevant the way the variab

Re: [Openvpn-devel] [PATCH] travis-ci: add 2 mingw "build only configurations"

2017-03-27 Thread Илья Шипицин
I opened https://github.com/OpenVPN/openvpn/pull/85 for discussion thoughts ? 2017-03-26 16:21 GMT+05:00 Ilya Shipitsin : > Inspired by https://www.mail-archive.com/openvpn-devel@lists. > sourceforge.net/msg13032.html > build options are taken from regular windows installer builds > > Signed-off

Re: [Openvpn-devel] [PATCH] resolve format string warnings

2017-03-27 Thread Илья Шипицин
2017-03-28 11:04 GMT+05:00 Gert Doering : > Hi, > > On Mon, Mar 27, 2017 at 11:40:49PM +0200, David Sommerseth wrote: > > > On Sat, Mar 25, 2017 at 05:21:18PM +0500, Ilya Shipitsin wrote: > > >> [src/openvpn/options.c:1163]: (warning) %x in format string (no. 1) > requires 'unsigned int *' but the

Re: [Openvpn-devel] [PATCH] resolve format string warnings

2017-03-27 Thread Gert Doering
Hi, On Mon, Mar 27, 2017 at 11:40:49PM +0200, David Sommerseth wrote: > > On Sat, Mar 25, 2017 at 05:21:18PM +0500, Ilya Shipitsin wrote: > >> [src/openvpn/options.c:1163]: (warning) %x in format string (no. 1) > >> requires 'unsigned int *' but the argument type is 'signed int *'. > > > > Pleas

Re: [Openvpn-devel] [PATCH] resolve format string warnings

2017-03-27 Thread Simon Ruderich
On Mon, Mar 27, 2017 at 11:40:49PM +0200, David Sommerseth wrote: > On 25/03/17 14:17, Gert Doering wrote: >> Hi, >> >> On Sat, Mar 25, 2017 at 05:21:18PM +0500, Ilya Shipitsin wrote: >>> [src/openvpn/options.c:1163]: (warning) %x in format string (no. 1) >>> requires 'unsigned int *' but the argu

[Openvpn-devel] [PATCH] systemd: Add and ship README.systemd

2017-03-27 Thread David Sommerseth
This new README file describes how to use the new openvpn-client@.service and openvpn-server@.service unit files properly. The purpose of this file is primarily for all systemd based distributions to have a common set of documentation. Signed-off-by: David Sommerseth --- distro/systemd/Makefile

Re: [Openvpn-devel] [PATCH] resolve format string warnings

2017-03-27 Thread David Sommerseth
On 25/03/17 14:17, Gert Doering wrote: > Hi, > > On Sat, Mar 25, 2017 at 05:21:18PM +0500, Ilya Shipitsin wrote: >> [src/openvpn/options.c:1163]: (warning) %x in format string (no. 1) requires >> 'unsigned int *' but the argument type is 'signed int *'. > > Please use "uint8_t" then, and also ad

Re: [Openvpn-devel] building HEAD + openssl 1.1 api fails @ "crypto.c:823:32: error: invalid application of ???sizeof??? to incomplete type ???cipher_ctx_t"

2017-03-27 Thread Gert Doering
Hi, On Mon, Mar 27, 2017 at 11:25:50AM -0700, PGNet Dev wrote: > noting > > openvpn fails to build with openssl 1.1 > https://community.openvpn.net/openvpn/ticket/759 Guess why that ticket is still open? > [Openvpn-devel] [RFC PATCH v1 00/15] Add support for OpenSSL 1.

[Openvpn-devel] building HEAD + openssl 1.1 api fails @ "crypto.c:823:32: error: invalid application of ‘sizeof’ to incomplete type ‘cipher_ctx_t"

2017-03-27 Thread PGNet Dev
fyi, noting openvpn fails to build with openssl 1.1 https://community.openvpn.net/openvpn/ticket/759 [Openvpn-devel] [RFC PATCH v1 00/15] Add support for OpenSSL 1.1.x https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg14075.html

Re: [Openvpn-devel] [RFC PATCH v1 05/15] OpenSSL: don't use direct access to the internal of X509

2017-03-27 Thread Emmanuel Deloget
Hi everyone, I got some time to try to fix all that stuff. First, On Sat, Mar 4, 2017 at 11:38 PM, David Sommerseth < open...@sf.lists.topphemmelig.net> wrote: > On 04/03/17 16:13, Steffan Karger wrote: > > As a last resort, we could consider keeping the old code inside #if > > OSSL_VER < 1.1.0