2017-03-28 11:04 GMT+05:00 Gert Doering <g...@greenie.muc.de>:
> Hi,
>
> On Mon, Mar 27, 2017 at 11:40:49PM +0200, David Sommerseth wrote:
> > > On Sat, Mar 25, 2017 at 05:21:18PM +0500, Ilya Shipitsin wrote:
> > >> [src/openvpn/options.c:1163]: (warning) %x in format string (no. 1)
> requires 'unsigned int *' but the argument type is 'signed int *'.
> > >
> > > Please use "uint8_t" then, and also adapt the "ret[i] = (uint8_t)byte"
> > > line - the cast would then be obsolete.
> >
> > I would normally agree to use uint8_t ... but the man page for sscanf()
> > on Linux says:
> >
> > "Matches an unsigned hexadecimal integer; the next pointer must be a
> > pointer to unsigned int."
> >
> > And stdint.h declares: typedef unsigned char uint8_t;
> >
> > AFAIR, char is defined as 8 bits (hence uint*8*), while unsigned int are
> > 32 bits on my system.
>
> Yeah, you're right. I confused this discussion with our standard
> "char vs. signed char vs. unsigned char" warning.
>
> (See how dangerous "fixing compiler warnings" is? :-) )
>
this particular warning came from cppcheck, it's not a compiler warning
I hope to address compiler warnings after "travis-ci + mingw" patch applied.
there are a lot of warnings in mingw builds:
https://travis-ci.org/chipitsine/openvpn/jobs/215190933#L1046
https://travis-ci.org/chipitsine/openvpn/jobs/215190933#L1063
https://travis-ci.org/chipitsine/openvpn/jobs/215190933#L1106
https://travis-ci.org/chipitsine/openvpn/jobs/215190933#L1136
https://travis-ci.org/chipitsine/openvpn/jobs/215190933#L1162
https://travis-ci.org/chipitsine/openvpn/jobs/215190933#L1180
https://travis-ci.org/chipitsine/openvpn/jobs/215190933#L1195
https://travis-ci.org/chipitsine/openvpn/jobs/215190933#L1236
https://travis-ci.org/chipitsine/openvpn/jobs/215190933#L1257
>
> gert
> --
> USENET is *not* the non-clickable part of WWW!
> //
> www.muc.de/~gert/ <http://www.muc.de/%7Egert/>
> Gert Doering - Munich, Germany
> g...@greenie.muc.de
> fax: +49-89-35655025 g...@net.informatik.tu-
> muenchen.de
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
