Re: [Openvpn-devel] Visual Studio support?

2017-01-01 Thread Selva Nair
Hi, On Sun, Jan 1, 2017 at 1:47 PM, Gert Doering wrote: > On Sun, Jan 01, 2017 at 10:32:34AM -0800, Fish Wang wrote: > > Thanks for your (and Steffan's) reply. > > > > I also noticed that 2.4 and 2.5 only supports Vista+, so it might make > sense > > to remove dynamic function loading for WPF in

Re: [Openvpn-devel] Visual Studio support?

2017-01-01 Thread Gert Doering
Hi, On Sun, Jan 01, 2017 at 10:32:34AM -0800, Fish Wang wrote: > Thanks for your (and Steffan's) reply. > > I also noticed that 2.4 and 2.5 only supports Vista+, so it might make sense > to remove dynamic function loading for WPF in openvpnserv (see all those > LoadLibrary and GetProcAddress code

Re: [Openvpn-devel] Visual Studio support?

2017-01-01 Thread Fish Wang
Thanks for your (and Steffan's) reply. I also noticed that 2.4 and 2.5 only supports Vista+, so it might make sense to remove dynamic function loading for WPF in openvpnserv (see all those LoadLibrary and GetProcAddress code in [1]). But somehow I have an impression that openvpnserv is no longer s

Re: [Openvpn-devel] Visual Studio support?

2017-01-01 Thread Gert Doering
Hi, On Sun, Jan 01, 2017 at 10:01:57AM -0800, Fish Wang wrote: > I'm finishing up a patch to make sure OpenVPN compiles under Visual Studio. > I have several questions; > > - Do you want to apply such a patch to master and/or release/2.4, or should > I maintain it separately? Unless it's highly

Re: [Openvpn-devel] Visual Studio support?

2017-01-01 Thread Steffan Karger
Hi, On 01-01-17 19:01, Fish Wang wrote: > I'm finishing up a patch to make sure OpenVPN compiles under Visual Studio. > I have several questions; > > - Do you want to apply such a patch to master and/or release/2.4, or should > I maintain it separately? Yes, we intend to keep OpenVPN compilable

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-01 Thread Selva Nair
Hi, On Sun, Jan 1, 2017 at 10:49 AM, debbie10t wrote: > Hi, > > I applied this to 2.5 and used the build system to build windows > installer using windows-nsis/build-snapshot > > I tested the windows client against Linux 2.4 > > The test was: > > Connect to first server, receive DHCP 10.*8*.0.6

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-01 Thread Selva Nair
Hi, On Sun, Jan 1, 2017 at 8:35 AM, Gert Doering wrote: > > Now, for this particular patch, I'm a bit undecided - it fixes breakage > for people, but there's a warning about "unexpected side effects" so > we might try to figure out why this warning exist. Less options and > doing the right thin

[Openvpn-devel] Visual Studio support?

2017-01-01 Thread Fish Wang
Hi, I'm finishing up a patch to make sure OpenVPN compiles under Visual Studio. I have several questions; - Do you want to apply such a patch to master and/or release/2.4, or should I maintain it separately? - What is the minimum version of Visual Studio do we want to support? - Should such a pat

Re: [Openvpn-devel] what is the use case of "#ifndef SIMULATE_DHCP_FAILED" ?

2017-01-01 Thread Gert Doering
Hi, On Sun, Jan 01, 2017 at 06:23:08PM +0300, ?? wrote: > https://github.com/OpenVPN/openvpn/blob/master/src/openvpn/tun.c#L5930 > > how this is supposed to be used ? This is test code: simulate what happens if the tap driver refuses our DeviceIoControl() calls. To enable t

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-01 Thread debbie10t
Hi, I applied this to 2.5 and used the build system to build windows installer using windows-nsis/build-snapshot I tested the windows client against Linux 2.4 The test was: Connect to first server, receive DHCP 10.*8*.0.6 (net30) Idle 10 mins / Transfer some data / disconnect Edit the config

[Openvpn-devel] what is the use case of "#ifndef SIMULATE_DHCP_FAILED" ?

2017-01-01 Thread Илья Шипицин
Hello, https://github.com/OpenVPN/openvpn/blob/master/src/openvpn/tun.c#L5930 how this is supposed to be used ? Cheers, Ilya Shipitsin -- Check out the vibrant tech community on one of the world's most engaging tech sit

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-01 Thread Gert Doering
Hi, On Sun, Jan 01, 2017 at 01:22:37PM +, debbie10t wrote: > Should this be applied to 2.4.0 or 2.5_gitmaster ? Generally speaking, everything goes to git master (unless specifically tagged as "this is for 2.3 / 2.4"). From there, bugfixes, long-term compatibility changes, and in some cases

Re: [Openvpn-devel] [PATCH] Always release dhcp address in close_tun()

2017-01-01 Thread debbie10t
Should this be applied to 2.4.0 or 2.5_gitmaster ? thanks On 31/12/16 02:45, selva.n...@gmail.com wrote: > From: Selva Nair > > Also make sure --dhcp-pre-release results in not just dhcp_release() > in open_tun() but a subsequent dhcp_renew() as well. Else dhcp transaction > gets aborted as this