Thanks for your (and Steffan's) reply.

I also noticed that 2.4 and 2.5 only supports Vista+, so it might make sense
to remove dynamic function loading for WPF in openvpnserv (see all those
LoadLibrary and GetProcAddress code in [1]). But somehow I have an
impression that openvpnserv is no longer supported and openvpnserv2 should
be used instead, so such a patch is not useful. What do you think?

Best,
Fish

[1]
https://github.com/OpenVPN/openvpn/blob/master/src/openvpnserv/interactive.c

-----Original Message-----
From: Gert Doering [mailto:g...@greenie.muc.de] 
Sent: Sunday, January 1, 2017 10:21 AM
To: Fish Wang <fish.t...@gmail.com>
Cc: openvpn-devel@lists.sourceforge.net
Subject: Re: [Openvpn-devel] Visual Studio support?

Hi,

On Sun, Jan 01, 2017 at 10:01:57AM -0800, Fish Wang wrote:
> I'm finishing up a patch to make sure OpenVPN compiles under Visual
Studio.
> I have several questions;
> 
> - Do you want to apply such a patch to master and/or release/2.4, or 
> should I maintain it separately?

Unless it's highly intrusive, it makes sense to merge it.

Since we're not compiling with VS, we sometimes break stuff, but this is not
intentional :-)

> - What is the minimum version of Visual Studio do we want to support?

I have no idea.  Something recent, which can do C99, as that's the coding
standard we've change to for 2.4 and master-after-2.4

> - Should such a patch be developed against maste, release/2.4 branch, 
> or both?

Master (as always).

gert

--
USENET is *not* the non-clickable part of WWW!
 
//www.muc.de/~gert/
Gert Doering - Munich, Germany
g...@greenie.muc.de
fax: +49-89-35655025
g...@net.informatik.tu-muenchen.de


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to