Re: [Openvpn-devel] Solaris 11: t_lpback.sh coredump on AES-GCM

2016-05-21 Thread Jens Neuhalfen
Hi Gert, > Hi, > > On Sat, May 21, 2016 at 07:05:01PM +0200, Jens Neuhalfen wrote: >> ./t_lpback.sh fails with AES-GCM mode on Solaris 11. CRYPTO_gcm128_setiv >> from libcrypto seems to jump into NULL pointer country. > > Oh, interesting. My OpenSSL on the OpenSolaris box is so old that it

Re: [Openvpn-devel] Solaris 11: t_lpback.sh coredump on AES-GCM

2016-05-21 Thread Gert Doering
Hi, On Sat, May 21, 2016 at 07:05:01PM +0200, Jens Neuhalfen wrote: > ./t_lpback.sh fails with AES-GCM mode on Solaris 11. CRYPTO_gcm128_setiv from > libcrypto seems to jump into NULL pointer country. Oh, interesting. My OpenSSL on the OpenSolaris box is so old that it does not have the AES-GC

[Openvpn-devel] Solaris 11: t_lpback.sh coredump on AES-GCM

2016-05-21 Thread Jens Neuhalfen
Hi, ./t_lpback.sh fails with AES-GCM mode on Solaris 11. CRYPTO_gcm128_setiv from libcrypto seems to jump into NULL pointer country. This is currently no issue for me, but in case anyone cares I put the coredump on https://www.neuhalfen.name/__downloads__/openvpn/core_solaris11_aes-gcm_crash

Re: [Openvpn-devel] [PATCH 1/2] Refactor t_client.sh

2016-05-21 Thread Gert Doering
Hi, On Sat, May 21, 2016 at 12:10:04PM +0200, Jens Neuhalfen wrote: > > This script needs to run on all platforms we support, and that includes > > more esoteric ones like AIX and Solaris - OpenSolaris /bin/sh is a ksh93 > > variant (nowadays), so if it works in ksh and dash (Debian /bin/sh), I'm

Re: [Openvpn-devel] [PATCH 1/2] Refactor t_client.sh

2016-05-21 Thread Jens Neuhalfen
Hi Gert, [snip] > Generally speaking, I'm in favour of reworking t_client.sh and making > the output more readable, etc. - it was a quick hack, and more polishing > would be welcome. > > I'm not exactly sure about the shell constructs you use, specifically > arrays and varaible declarations - is

Re: [Openvpn-devel] Test documentation: What does t_cltsrv.sh do?

2016-05-21 Thread Jens Neuhalfen
Gert, please be so kind and review this README intended to go in openvpn/tests OpenVPN tests = OpenVPN utilizes three types of tests * Unit testing with cmocka * Loopback integration testing * VM/Server based integration testing ## Unit testing Unit testing is described in [unit_t

Re: [Openvpn-devel] Test documentation: What does t_cltsrv.sh do?

2016-05-21 Thread Gert Doering
Hi, On Sat, May 21, 2016 at 10:59:23AM +0200, Jens Neuhalfen wrote: > * t_client.sh runs connect & ping tests against servers > * t_lpback.sh runs the built-in crypto tests > * Can anybody tell me what ???t_cltsrv.sh??? tests? It's a basic TLS test that does not need external test infrastructure

Re: [Openvpn-devel] [PATCH 1/2] Refactor t_client.sh

2016-05-21 Thread Gert Doering
Hi, On Sat, May 21, 2016 at 11:22:04AM +0200, openvpn-de...@neuhalfen.name wrote: > +# -- > +# global variables > +# -- > + > +# list of succeeded tests (e.g. 1 2 3) > +declare SUMMARY_

[Openvpn-devel] [PATCH 1/2] Refactor t_client.sh

2016-05-21 Thread openvpn-devel
From: Jens Neuhalfen Move global code into seperate functions. Fixup formatting of code. Signed-off-by: Jens Neuhalfen --- tests/t_client.sh.in | 433 ++- 1 file changed, 255 insertions(+), 178 deletions(-) diff --git a/tests/t_client.sh.in b/te

[Openvpn-devel] [PATCH 2/2] Add table output formatting to t_client.sh

2016-05-21 Thread openvpn-devel
From: Jens Neuhalfen Test results will be printed in a tabular format, e.g. | ID | TEST| RESULT | | -- | --- | | | 1 | testing tun/udp/ipv4| [SUCCESS]| | 2 | testing t

[Openvpn-devel] Refactor t_client.sh & improve output formatting

2016-05-21 Thread openvpn-devel
Ratio: * Cleanup code * Prepare for better automated integration tests (future) Move global code into separate functions. Fixup formatting of code. Also add table output formatting to t_client.sh: | ID | TEST| RESULT | | -- |

[Openvpn-devel] Test documentation: What does t_cltsrv.sh do?

2016-05-21 Thread Jens Neuhalfen
Hi, in my quest to bring better testability to OpenVPN I am documenting some of the test cases. * t_client.sh runs connect & ping tests against servers * t_lpback.sh runs the built-in crypto tests * Can anybody tell me what ’t_cltsrv.sh’ tests? Cheers Jens