Hi, On Sat, May 21, 2016 at 11:22:04AM +0200, openvpn-de...@neuhalfen.name wrote: > +# ---------------------------------------------------------- > +# global variables > +# ---------------------------------------------------------- > + > +# list of succeeded tests (e.g. 1 2 3) > +declare SUMMARY_OK="" > + > +# list of failed tests > +declare SUMMARY_FAIL="" > + > +# number of failed checks for a test (# of calls to fail()) > +declare -i fail_count=0
Generally speaking, I'm in favour of reworking t_client.sh and making the output more readable, etc. - it was a quick hack, and more polishing would be welcome. I'm not exactly sure about the shell constructs you use, specifically arrays and varaible declarations - is that posix shell, or "bash"? This script needs to run on all platforms we support, and that includes more esoteric ones like AIX and Solaris - OpenSolaris /bin/sh is a ksh93 variant (nowadays), so if it works in ksh and dash (Debian /bin/sh), I'm fine... gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature