Re: [Openvpn-devel] [PATCH 3/7] vlan: Add global, per-client 802.1q-based options

2016-04-03 Thread David Sommerseth
On 03/04/16 23:40, Mike Auty wrote: > On 03/04/16 22:10, Jonathan K. Bullard wrote: >> >> NAK. This should include testing for extra parameters supplied in >> error with the options, as the rest of the option-handling code does. >> Something like the following (for each of the three new options): >

Re: [Openvpn-devel] [PATCH 3/7] vlan: Add global, per-client 802.1q-based options

2016-04-03 Thread Mike Auty
On 03/04/16 22:10, Jonathan K. Bullard wrote: > > NAK. This should include testing for extra parameters supplied in > error with the options, as the rest of the option-handling code does. > Something like the following (for each of the three new options): > > + else if (streq (p[0], "vlan-taggin

Re: [Openvpn-devel] [PATCH 3/7] vlan: Add global, per-client 802.1q-based options

2016-04-03 Thread Jonathan K. Bullard
On Sun, Apr 3, 2016 at 2:51 PM, Mike Auty wrote: > > This patch add the new global "--vlan-tagging" boolean switch. This specifies > whether openvpn should handle 802.1q tagged packets in any way. > > This patch also adds the new global '--vlan-accept tagged|untagged|all' which > specifies the be

[Openvpn-devel] [PATCH 6/7] vlan: Prepend and remove VLAN identifiers on outgoing and, incoming frames

2016-04-03 Thread Mike Auty
This patch adds parsing of the IEEE 802.1Q headers for incoming and outgoing ethernet frames. For frames coming in from the tap device, the 802.1Q header is parsed and translated into a regular Ethernet II header. For frames where the Priority Code Point (PCP) is non-zero, the 802.1Q tagging beha

[Openvpn-devel] [PATCH 4/7] vlan: Add in functions for working with 802.1q vlan, headers.

2016-04-03 Thread Mike Auty
This patch adds in functions for extracting data from the 802.1q header. The vlan_hdr_* functions now expect and return the values in host byte order. The callee doesn't need to perform any kind of conversion. These functions are not used yet, but will be used in future patches. Patch authored

[Openvpn-devel] [PATCH 0/7] Vlan support for openvpn

2016-04-03 Thread Mike Auty
Hi there, This is the start of a 7-patch set to add vlan support to openvpn, as authored by Fabian Knittel. This a squashed patchset (originally numbering 21 patches, but now reduced to 7). These were originally written up to four years ago, and have been maintained (at sparse intervals) by the

[Openvpn-devel] [PATCH 5/7] vlan: Add the 802.1q vlan id to appropriate calls.

2016-04-03 Thread Mike Auty
This patch ensures that a vlan ID is passed to all necessary function calls. These changes are not yet used and the vlan ID is always defined as 0. This will be used by future patches that will change the vid variable. Patch authored by Fabian Knittel . Signed-off-by: Fabian Knittel --- src/o

[Openvpn-devel] [PATCH 1/7] vlan: add compile-time option ENABLE_VLAN_TAGGING

2016-04-03 Thread Mike Auty
The option can be disabled via "./configure --disable-vlan-tagging". Patch authored by Fabian Knittel . Signed-off-by: Fabian Knittel --- configure.ac | 10 ++ 1 file changed, 10 insertions(+) diff --git a/configure.ac b/configure.ac index b75d51f..89556c4 100644 --- a/configure.ac +++

[Openvpn-devel] [PATCH 3/7] vlan: Add global, per-client 802.1q-based options

2016-04-03 Thread Mike Auty
This patch add the new global "--vlan-tagging" boolean switch. This specifies whether openvpn should handle 802.1q tagged packets in any way. This patch also adds the new global '--vlan-accept tagged|untagged|all' which specifies the behaviour of the tap device with regards to 802.1q vlan tagged

[Openvpn-devel] [PATCH 2/7] vlan: Add various definitions and 802.1Q structure

2016-04-03 Thread Mike Auty
This patch provides all the #DEFINES necessary for the 802.1q. sf.net tracker: Discussed on the IRC meeting March 4, 2010 in #openvpn-discussions. Thi

[Openvpn-devel] [PATCH 7/7] vlan: document the --vlan-* flags in openvpn.8 man page

2016-04-03 Thread Mike Auty
Documents the --vlan-tagging, --vlan-accept and --vlan-pvid tags in the openvpn man page. Patch authored by Fabian Knittel . Co-authored-by: Mike Auty Signed-off-by: Fabian Knittel --- doc/openvpn.8 | 104 ++ 1 file changed, 104 insertion