On 03/04/16 23:40, Mike Auty wrote: > On 03/04/16 22:10, Jonathan K. Bullard wrote: >> >> NAK. This should include testing for extra parameters supplied in >> error with the options, as the rest of the option-handling code does. >> Something like the following (for each of the three new options): >> >> + else if (streq (p[0], "vlan-tagging") && !p[1]) >> > > Thanks for reviewing the patches! 5:) > > That should be reasonable to add in, I'll try and do that in the next > couple of days (and try and change round my git repo so that I can keep > the patch versions in separate branches). > > Could you let me know if I should be resending all the patches for the > next version, or just the ones that have changed?
As long as it is a change only affecting a single patch, then resending an updated version of that patch is generally fine. When updating patches, please ensure that the subject line states for example "PATCH v2". That is easily done by adding --subject-prefix="PATCH v2" to the git command lines creating the patch. Second detail is to add a "revision history" in the git commit log. See commit a24dd2e31f196c76 as an example. -- kind regards, David Sommerseth
