[Openvpn-devel] [PATCH 2.3] Use adapter index for add/delete_route_ipv6

2015-12-11 Thread Lev Stipakov
Trac #637 --- src/openvpn/route.c | 8 src/openvpn/tun.c | 6 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 1775a9c..cf5a067 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -1623,6 +1623,10 @@ add_rout

[Openvpn-devel] [PATCH v2 master] Use adapter index for add/delete_route_ipv6

2015-12-11 Thread Lev Stipakov
Trac #637 Signed-off-by: Lev Stipakov --- src/openvpn/route.c | 16 src/openvpn/tun.c | 6 +- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 4a60345..2012b5c 100644 --- a/src/openvpn/route.c +++ b/src/openvp

[Openvpn-devel] [PATCH master] Use adapter index for add/delete_route_ipv6

2015-12-11 Thread Lev Stipakov
Trac #637 Signed-off-by: Lev Stipakov --- src/openvpn/route.c | 16 src/openvpn/tun.c | 2 ++ 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 4a60345..2012b5c 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/ro

Re: [Openvpn-devel] [PATCH v2] Use adapter index instead of name

2015-12-11 Thread Lev Stipakov
Thanks, I think (I think!) I got it now. 1) Since we have tt->adapter_index (which temporarily disappeared from my perception of reality), no need to add new member to tuntap or tuntap_options. 2) tt->adapter_index has nothing to do with rgi->adapter_index, first one is windows adapter index

Re: [Openvpn-devel] Opttion "client-nat" not recognised

2015-12-11 Thread debbie10t
- Original Message - From: "Gert Doering" To: Cc: "Gert Doering" ; Sent: Friday, December 11, 2015 8:08 PM Subject: Re: [Openvpn-devel] Opttion "client-nat" not recognised the code says "four arguments have to be there" and the git master code says "four arguments have to be ther

Re: [Openvpn-devel] Opttion "client-nat" not recognised

2015-12-11 Thread Gert Doering
Hi, On Fri, Dec 11, 2015 at 08:06:45PM -, debbie...@gmail.com wrote: > > According to the (slightly confusing, admittedly) man page entry, > > the way you are calling the option is not correct, and as such, > > git master will refuse the lines. "client-nat" has *four* arguments, > > not *fi

Re: [Openvpn-devel] [PATCH v2] Use adapter index instead of name

2015-12-11 Thread Gert Doering
Hi, On Fri, Dec 11, 2015 at 09:41:56PM +0200, Lev Stipakov wrote: > Hi, > > >> So, if we want to use index also for "add/del route", I'd gently modify > >> add/del_route_ipv6 and make it use "interface=" (without breaking > >> "vpn server special route" case). > > > > For consistency, I think we

Re: [Openvpn-devel] Opttion "client-nat" not recognised

2015-12-11 Thread debbie10t
- Original Message - From: "Gert Doering" To: Cc: Sent: Friday, December 11, 2015 7:38 PM Subject: Re: [Openvpn-devel] Opttion "client-nat" not recognised According to the (slightly confusing, admittedly) man page entry, the way you are calling the option is not correct, and as suc

Re: [Openvpn-devel] [PATCH v2] Use adapter index instead of name

2015-12-11 Thread Lev Stipakov
Hi, So, if we want to use index also for "add/del route", I'd gently modify add/del_route_ipv6 and make it use "interface=" (without breaking "vpn server special route" case). For consistency, I think we should do that. What I'd avoid is to do the adapter_index lookup for every single route -

Re: [Openvpn-devel] Opttion "client-nat" not recognised

2015-12-11 Thread Gert Doering
Hi, On Fri, Dec 11, 2015 at 07:35:18PM -, debbie...@gmail.com wrote: > today, I was working with an old config which uses --client-nat > I upgraded that particular client to git-master for testing and > discovered that git-master currently does not support --client-nat [..] > Fri Dec 11 19:08:

[Openvpn-devel] Opttion "client-nat" not recognised

2015-12-11 Thread debbie10t
Hi, today, I was working with an old config which uses --client-nat I upgraded that particular client to git-master for testing and discovered that git-master currently does not support --client-nat This config works perfectly with older versions, details follow: GIT-master versions which --cli

Re: [Openvpn-devel] [PATCH v8-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-12-11 Thread Lev Stipakov
On 10.12.2015 18:49, ValdikSS wrote: I'd better go with just closing the engine without deleting everything. I don't see any drawbacks, that should be perfectly OK for a dynamic session. Is this correct, Lev? If yes, I'll push v9 today or tomorrow morning. Removing non-working FwpmSubLayerDel

[Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

2015-12-11 Thread Fish
Based on release/2.3 branch and ValdikSS's v9 patch, this patch is cross-compiled on Linux and tested on Windows XP/10. The VC project file is left untouched - you might want to add rpcrt4.lib to compile and link it under MSVC. Take ValdikSS's patch for "block-outside-dns" option and make it Windo

Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

2015-12-11 Thread Selva Nair
Hi, The patch is mangled by mailer (added linebreaks etc.). Could you please resend using git send-email? While at it, one thing I noticed: On Thu, Dec 10, 2015 at 6:48 PM, Fish Wang wrote: > -#if _WIN32_WINNT >= 0x0600 >else if (streq (p[0], "block-outside-dns") && !p[1]) > { >