Re: [Openvpn-devel] [RFC] Split plugins into their own repositories

My two cents on this is as follows: As a package maintainer, I think this is going to prove to be a lot of work. It means there are more packages to maintain, over the one I need to now. HOWEVER, from the OpenVPN development process, I think it's best to split things out, as Alon suggests, wi

Re: [Openvpn-devel] [V2.4 4/4] cleanup: tun: tun_engine interface

On Sat, May 12, 2012 at 10:31 PM, Alon Bar-Lev wrote: > Platform independent interface for tun provider. > > Split the long tun.c into platform specific files using > tun_engine interface. > > There is more to be done in order to clean up the code, > however this is a good starting point. > > Sign

[Openvpn-devel] [V2.4 3/4] cleanup: remove tun_adjust_frame_parameters

It is a wrapper of frame_add_to_extra_tun, no sense to keep both around. Signed-off-by: Alon Bar-Lev --- src/openvpn/init.c |2 +- src/openvpn/tun.h |6 -- 2 files changed, 1 insertions(+), 7 deletions(-) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index eb4c5df..0bd3f75 1

[Openvpn-devel] [V2.4 2/4] cleanup: move warn_on_use_of_common_subnets to init.c

No dependencies and init.c is the only user. Signed-off-by: Alon Bar-Lev --- src/openvpn/init.c | 18 ++ src/openvpn/tun.c | 17 - src/openvpn/tun.h |2 -- 3 files changed, 18 insertions(+), 19 deletions(-) diff --git a/src/openvpn/init.c b/src/openvpn/

[Openvpn-devel] [V2.4 1/4] cleanup: remove check_subnet_conflict

Commeted out as "too many false positives". Signed-off-by: Alon Bar-Lev --- src/openvpn/route.c |1 - src/openvpn/tun.c | 43 --- src/openvpn/tun.h |4 3 files changed, 0 insertions(+), 48 deletions(-) diff --git a/src/openvpn/route.c b

[Openvpn-devel] [V2.4 0/4] tun cleanups

Platform independent interface for tun provider. Split the long tun.c into platform specific files using tun_engine interface. Functionality is the same. Maintenance will be much easier! new options, like stacking several interfaces and delegate partial control to plugin. There is more to be do

[Openvpn-devel] [PATCH 16/16] clenaup: syshead: reworder/cleanup includes

Signed-off-by: Alon Bar-Lev --- configure.ac |2 +- src/openvpn/syshead.h | 146 - 2 files changed, 36 insertions(+), 112 deletions(-) diff --git a/configure.ac b/configure.ac index cca9508..97eb5f0 100644 --- a/configure.ac +++ b/con

[Openvpn-devel] [PATCH 15/16] cleanup: syshead: move ENABLE_MEMSTATS to autoconf

Signed-off-by: Alon Bar-Lev --- configure.ac |1 + src/openvpn/syshead.h |7 --- 2 files changed, 1 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index 193d287..cca9508 100644 --- a/configure.ac +++ b/configure.ac @@ -270,6 +270,7 @@ case "$host" in

[Openvpn-devel] [PATCH 14/16] cleanup: syshead: move SOL_IP emulation to autoconf

Signed-off-by: Alon Bar-Lev --- configure.ac | 11 +++ src/openvpn/syshead.h |8 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 2c80ef4..193d287 100644 --- a/configure.ac +++ b/configure.ac @@ -490,6 +490,17 @@ AC_

[Openvpn-devel] [PATCH 13/16] cleanup: syshead: remove dead code

Signed-off-by: Alon Bar-Lev --- src/openvpn/syshead.h | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/src/openvpn/syshead.h b/src/openvpn/syshead.h index 657c884..f908752 100644 --- a/src/openvpn/syshead.h +++ b/src/openvpn/syshead.h @@ -375,14 +375,6 @@ #e

[Openvpn-devel] [PATCH 12/16] cleanup: syshead: move socket compat into basic.h

Probably not the best place, however, better than syshead. Signed-off-by: Alon Bar-Lev --- src/openvpn/basic.h | 17 + src/openvpn/syshead.h | 17 - 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/src/openvpn/basic.h b/src/openvpn/basic.h in

[Openvpn-devel] [PATCH 11/16] cleanup: syshead: move _P1003_1B_VISIBLE to autoconf

Signed-off-by: Alon Bar-Lev --- configure.ac |2 +- src/openvpn/syshead.h |3 --- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 078e46f..2c80ef4 100644 --- a/configure.ac +++ b/configure.ac @@ -291,7 +291,7 @@ case "$host" in

[Openvpn-devel] [PATCH 10/16] cleanup: syshead: split pedantic into pedantic, lint

Split pedantic into two: pedantic (compiler only), lint (functional). Move settings into basic.h. Remove lint stub in tun.c. Signed-off-by: Alon Bar-Lev --- configure.ac | 18 -- src/openvpn/basic.h | 14 ++ src/openvpn/error.h |2 +- src/openvpn/

[Openvpn-devel] [PATCH 06/16] clenaup: syshead: remove wait macros wrappers

WEXITSTATUS is POSIX, show me the platform that does not support this. WIFEXITED is not used at Windows code. Signed-off-by: Alon Bar-Lev --- src/openvpn/syshead.h |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/src/openvpn/syshead.h b/src/openvpn/syshead.h inde

[Openvpn-devel] [PATCH 09/16] cleanup: syshead: rename S_ERROR->S_ERRORS to avoid conflict with stropts.h

Signed-off-by: Alon Bar-Lev --- src/openvpn/ssl.c| 16 src/openvpn/ssl_common.h |2 +- src/openvpn/syshead.h|1 - 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 19512c0..3178ff4 100644 --- a/src/op

[Openvpn-devel] [PATCH 08/16] cleanup: syshead: move sleep, random, syshead.h emulation to compat

--- src/compat/compat.h |6 ++ src/openvpn/syshead.h |3 --- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/compat/compat.h b/src/compat/compat.h index 021573e..7d91277 100644 --- a/src/compat/compat.h +++ b/src/compat/compat.h @@ -41,6 +41,12 @@ #include #endi

[Openvpn-devel] [PATCH 04/16] cleanup: syshead: remove useless constant USE_64_BIT_COUNTERS

Signed-off-by: Alon Bar-Lev --- src/openvpn/common.h | 13 - src/openvpn/syshead.h |5 - 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/src/openvpn/common.h b/src/openvpn/common.h index de2d609..845faee 100644 --- a/src/openvpn/common.h +++ b/src/openvpn/co

[Openvpn-devel] [PATCH 03/16] cleanup: syshead: remove useless WIN32_0_1

Signed-off-by: Alon Bar-Lev --- src/openvpn/syshead.h | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/src/openvpn/syshead.h b/src/openvpn/syshead.h index 91a23d3..99a6674 100644 --- a/src/openvpn/syshead.h +++ b/src/openvpn/syshead.h @@ -439,16 +439,6 @@ #endif

[Openvpn-devel] [PATCH 07/16] cleanup: syshead: move likely, unlikely to basic.h

Signed-off-by: Alon Bar-Lev --- src/openvpn/basic.h |9 + src/openvpn/syshead.h |9 - 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/openvpn/basic.h b/src/openvpn/basic.h index 298cf10..f2d5041 100644 --- a/src/openvpn/basic.h +++ b/src/openvpn/basic.

[Openvpn-devel] [PATCH 02/16] cleanup: syshead: move O_BINARY detection to autoconf

Signed-off-by: Alon Bar-Lev --- configure.ac | 11 +++ src/openvpn/syshead.h |7 --- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index 4592727..6f6a1f4 100644 --- a/configure.ac +++ b/configure.ac @@ -519,6 +519,17 @@ AC_C

[Openvpn-devel] [PATCH 01/16] cleanup: syshead: remove OS_SPECIFIC_DIRSEP in favor of autoconf PATH_SEPARATOR

Signed-off-by: Alon Bar-Lev --- src/openvpn/misc.c |6 +- src/openvpn/ssl_verify.c |2 +- src/openvpn/syshead.h|9 - 3 files changed, 2 insertions(+), 15 deletions(-) diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c index 2ded9bf..3dd2aa2 100644 --- a/src/op

[Openvpn-devel] [PATCH 05/16] cleanup: syshead: move apple specific CPPFLAGS out of syshead

Signed-off-by: Alon Bar-Lev --- configure.ac | 18 ++ src/openvpn/syshead.h |6 -- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 6f6a1f4..9fcd7fe 100644 --- a/configure.ac +++ b/configure.ac @@ -357,6 +357,24 @

[Openvpn-devel] [PATCH 00/16] syshead: cleanups

Hello, This series include some minor syshead.h cleanups, most moved to build system. I think these are simple enough to go into 2.3, the risk is minimal but I don't care if we truly freeze 2.3 and switch master to 2.4 and apply this for 2.4. This series is on top of my build branch[1], about to

[Openvpn-devel] [PATCH] build: insall README* document using build system

Purpose: make distro packager task simpler, more flexible to provide more documentation without changing the packaging script. Remove installation related documents from rpm as package already installed when viewed. +Workaround rpm bug[1]. [1] http://rpm.org/ticket/836 Signed-off-by: Alon Bar-L

Re: [Openvpn-devel] [PATCH] Properly detect OpenSSL version strings with numbers only

ACK, the revision letter is indeed optional. David, Repository is at github... On Sat, May 12, 2012 at 6:54 PM, Simon Deziel wrote: > whichopensslcnf failed to return the right cnf for: > > $ openssl version > OpenSSL 1.0.1 14 Mar 2012 > > Signed-off-by: Simon Deziel > --- >  easy-rsa/2.0/which

[Openvpn-devel] [PATCH] Properly detect OpenSSL version strings with numbers only

whichopensslcnf failed to return the right cnf for: $ openssl version OpenSSL 1.0.1 14 Mar 2012 Signed-off-by: Simon Deziel --- easy-rsa/2.0/whichopensslcnf |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/easy-rsa/2.0/whichopensslcnf b/easy-rsa/2.0/whichopensslcnf

Re: [Openvpn-devel] OpenVPN in the Hypervisor

The wiki was a loss (my backup was only a symlink :-( ), but I've re-written what I did to get this running. Now available at: http://teeks99.com/sys/OpenVPN-VMs/Tryout.html Tom On Fri, May 11, 2012 at 4:29 PM, Tom Kent wrote: > Thanks for making that clear, it worked great...not sure why I wa

[Openvpn-devel] [PATCH] build: detect sys/wait.h required for *bsd

Signed-off-by: Alon Bar-Lev --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 901a916..4592727 100644 --- a/configure.ac +++ b/configure.ac @@ -374,7 +374,7 @@ AC_CHECK_HEADERS([ \ ]) AC_CHECK_HEADERS([ \ sys/tim

Re: [Openvpn-devel] [PATCH] Openvpn for Android 4.0 Changeset

On Sat, May 12, 2012 at 11:10 AM, Gert Doering wrote: > Hi, > > On Fri, May 11, 2012 at 11:52:22PM +0200, Arne Schwabe wrote: >> Am 11.05.12 20:56, schrieb Gert Doering: >> > Changing the build environment to build a shared library out of openvpn >> > is something I do not fully understand yet, th

Re: [Openvpn-devel] [PATCH] Openvpn for Android 4.0 Changeset

Hi, On Fri, May 11, 2012 at 11:52:22PM +0200, Arne Schwabe wrote: > Am 11.05.12 20:56, schrieb Gert Doering: > > Changing the build environment to build a shared library out of openvpn > > is something I do not fully understand yet, though - and don't view > > a particular useful goal right now. >