Re: [Openvpn-devel] OpenVPN Management Interface

2012-03-06 Thread Jason Haar
On 07/03/12 07:55, Alon Bar-Lev wrote: > 1. Multi user computer - we need to make sure one user cannot use > another user credentials and not effect the other users. With changes > I suggested there is full solution for this. Is that really a risk worth solving? I mean, does *anyone*, *anywhere* a

Re: [Openvpn-devel] OpenVPN Management Interface

2012-03-06 Thread Alon Bar-Lev
On Tue, Mar 6, 2012 at 8:41 PM, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/03/12 19:26, Alon Bar-Lev wrote: >> On Tue, Mar 6, 2012 at 7:42 PM, Russell Morris >> wrote: >>> Hi, >>> >>> >>> >>> That makes sense - thanks! I'm not a security expert by any mean

Re: [Openvpn-devel] OpenVPN Management Interface

2012-03-06 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/03/12 19:26, Alon Bar-Lev wrote: > On Tue, Mar 6, 2012 at 7:42 PM, Russell Morris > wrote: >> Hi, >> >> >> >> That makes sense - thanks! I'm not a security expert by any means, >> so the thread lost me when it diverged into this area ... :-

Re: [Openvpn-devel] OpenVPN Management Interface

2012-03-06 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/03/12 18:42, Russell Morris wrote: > Hi, > > > > That makes sense - thanks! I'm not a security expert by any means, so > the thread lost me when it diverged into this area ... :-(. > > > > At the risk of asking a stupid question (but that i

Re: [Openvpn-devel] OpenVPN Management Interface

2012-03-06 Thread Alon Bar-Lev
On Tue, Mar 6, 2012 at 7:42 PM, Russell Morris wrote: > Hi, > > > > That makes sense - thanks! I'm not a security expert by any means, so the > thread lost me when it diverged into this area ... :-(. > > > > At the risk of asking a stupid question (but that is my specialty ... :-)) - > is there a

Re: [Openvpn-devel] OpenVPN Management Interface

2012-03-06 Thread Russell Morris
Hi, That makes sense - thanks! I'm not a security expert by any means, so the thread lost me when it diverged into this area ... :-(. At the risk of asking a stupid question (but that is my specialty ... :-)) - is there a conclusion of how to deal with this? Thanks again, ... Russell

Re: [Openvpn-devel] OpenVPN Management Interface

2012-03-06 Thread Alon Bar-Lev
This exactly what we discuss at the privilege separation thread... Currently to change configuration you need to start a process. 2012/3/6 Russell Morris : > Hi, > > > > Taking off from the thread below - is it possible in Windows to start > openvpn, but only as a sort of local server (for lack of

[Openvpn-devel] OpenVPN Management Interface

2012-03-06 Thread Russell Morris
Hi, Taking off from the thread below - is it possible in Windows to start openvpn, but only as a sort of local server (for lack of a better term)? I would like to start it up, and then be able to initiate connections, tear them down, change proxy, etc. - all via the mangement interface.

Re: [Openvpn-devel] [PATCH 00/35] build revolution

2012-03-06 Thread Alon Bar-Lev
Forgot to mention... I've updated the wiki page[1] Samuli started... [1] https://community.openvpn.net/openvpn/wiki/BuildingUsingGenericBuildsystem

Re: [Openvpn-devel] [PATCH 09/52] cleanup: memcmp.c: remove unused source

2012-03-06 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/03/12 12:13, Alon Bar-Lev wrote: > Not exactly. This file is needed for VERY old libc implementations. I > don't think these exists anymore in supported configurations. If we > find memcmp() is missing, we add it properly to compat. Agreed, and

Re: [Openvpn-devel] [PATCH 21/52] build: remove windows specific build system

2012-03-06 Thread Samuli Seppänen
There goes all the sweat and tears I poured onto that buildsystem :). I say let it burn. ACK. Samuli > It will be completely re-written in future > > Signed-off-by: Alon Bar-Lev > --- > Makefile.am|8 +- > doclean| 73 - > domake-win | 138

Re: [Openvpn-devel] [PATCH 09/52] cleanup: memcmp.c: remove unused source

2012-03-06 Thread Alon Bar-Lev
Not exactly. This file is needed for VERY old libc implementations. I don't think these exists anymore in supported configurations. If we find memcmp() is missing, we add it properly to compat. 2012/3/6 Samuli Seppänen : > >> Signed-off-by: Alon Bar-Lev >> --- >>  configure.ac |    3 --- >>  memc

Re: [Openvpn-devel] [PATCH 16/52] build: we need the sample.ovpn in future

2012-03-06 Thread Alon Bar-Lev
2012/3/6 Samuli Seppänen : > Just wondering... why not move sample.ovpn to "sample-config-files" > directory? Because I did not want to change the sample-config-files... This was windows specific so I left it windows specific. If you want reorder of example, I will be happy to do any other way.

Re: [Openvpn-devel] [PATCH 04/52] cleanup: remove C++ warnings

2012-03-06 Thread Alon Bar-Lev
2012/3/6 Samuli Seppänen : > Although this commenting style has been valid in C since C99 (year > 2000), the actual C99 implementations seem to be incomplete[2]. So, just > to be on the safe side, I'll give this one an ACK. As long as we need to support old machines, we need to support C89. There

Re: [Openvpn-devel] [DISCUSSION] OpenVPN privilege separation (Windows)

2012-03-06 Thread Alon Bar-Lev
On Tue, Mar 6, 2012 at 12:34 PM, michael-dev wrote: > Hi, > > just to give you feedback that your thread is actually followed. This is great! > I believe the different types of configuration are good and correct and > that a good threat analysis is a basic step to proper security, though I > can

Re: [Openvpn-devel] [PATCH 19/52] Remove tap-win32

2012-03-06 Thread Samuli Seppänen
As tap-win32 is being moved to a separate subproject, this makes sense. ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Introduce tap-windows.h which is modified tap-win32/common.h. > Except of function rename, it is the same without the tap_id.

Re: [Openvpn-devel] [PATCH 20/52] cleanup: rename tap-windows function from win32 to win

2012-03-06 Thread Samuli Seppänen
As is said on tap-win32/common.h and in many other places: "TAP-Win32/TAP-Win64 -- A kernel driver to provide virtual tap device functionality on Windows." So, it's not 32-bit only. Thus converting "tap-win32" into "tap-win" makes sense. ACK. -- Samuli Seppänen Community Manager OpenVPN Tech

Re: [Openvpn-devel] [PATCH 17/52] Remove install-win32

2012-03-06 Thread Samuli Seppänen
The "install-win32" directory is obsolete, and will be even more so with this new buildsystem. ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Signed-off-by: Alon Bar-Lev > --- > Makefile.am|5 +- > configure.ac

Re: [Openvpn-devel] [PATCH 18/52] Remove easy-rsa

2012-03-06 Thread Samuli Seppänen
Moving easy-rsa into a separate subproject, so this makes sense. ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Signed-off-by: Alon Bar-Lev > --- > Makefile.am|1 - > easy-rsa/1.0/README

Re: [Openvpn-devel] [PATCH 16/52] build: we need the sample.ovpn in future

2012-03-06 Thread Samuli Seppänen
Il 29.02.2012 22:11, Alon Bar-Lev ha scritto: > Signed-off-by: Alon Bar-Lev > --- > install-win32/sample.ovpn | 103 > > sample-windows/sample.ovpn | 103 > > 2 files changed, 103 insertions(+), 103 del

Re: [Openvpn-devel] [PATCH 12/52] Update .gitignore

2012-03-06 Thread Samuli Seppänen
> Signed-off-by: Alon Bar-Lev > --- > .gitignore |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/.gitignore b/.gitignore > index 3d12f5d..8cc07de 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -5,6 +5,7 @@ > *.obj > *.pyc > *.so > +*~ > .deps > Makefile > M

Re: [Openvpn-devel] [PATCH 11/52] build: correct place to alter WINVER is at build system

2012-03-06 Thread Samuli Seppänen
Il 29.02.2012 22:11, Alon Bar-Lev ha scritto: > Signed-off-by: Alon Bar-Lev > --- > configure.ac|2 +- > syshead.h |4 > win/msvc.mak.in |2 +- > 3 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 1c4d66c..aa1d509 10064

Re: [Openvpn-devel] [DISCUSSION] OpenVPN privilege separation (Windows)

2012-03-06 Thread michael-dev
Hi, just to give you feedback that your thread is actually followed. I believe the different types of configuration are good and correct and that a good threat analysis is a basic step to proper security, though I cannot say much about the isolation tricks on Windows. The important think is, a

Re: [Openvpn-devel] [PATCH 09/52] cleanup: memcmp.c: remove unused source

2012-03-06 Thread Samuli Seppänen
> Signed-off-by: Alon Bar-Lev > --- > configure.ac |3 --- > memcmp.c | 43 --- > 2 files changed, 0 insertions(+), 46 deletions(-) > delete mode 100644 memcmp.c > > diff --git a/configure.ac b/configure.ac > index 25dcc37..1c4d66c 100644 > ---

Re: [Openvpn-devel] [PATCH 08/52] cleanup: tun.c: fix incorrect option in message (ip-win32)

2012-03-06 Thread Samuli Seppänen
> Signed-off-by: Alon Bar-Lev > --- > tun.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tun.c b/tun.c > index c92c0d7..81b66fb 100644 > --- a/tun.c > +++ b/tun.c > @@ -4492,7 +4492,7 @@ dhcp_masq_addr (const in_addr_t local, const in_addr_t > netmask, const in

Re: [Openvpn-devel] [PATCH 07/52] cleanup: crypto_openssl.c: remove support for pre-openssl-0.9.6

2012-03-06 Thread Samuli Seppänen
> autoconf rejecting this anyway: > --- > AC_MSG_CHECKING([that OpenSSL Library is at least version 0.9.6]) > > AC_MSG_ERROR([OpenSSL crypto Library is too old.]) > --- > > Signed-off-by: Alon Bar-Lev > --- > crypto_openssl.c | 49 - > 1 files c

Re: [Openvpn-devel] [PATCH 06/52] cleanup: remove redundant ';'

2012-03-06 Thread Samuli Seppänen
> Signed-off-by: Alon Bar-Lev > --- > misc.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/misc.h b/misc.h > index bdada42..dd6bd5a 100644 > --- a/misc.h > +++ b/misc.h > @@ -145,7 +145,7 @@ openvpn_run_script (const struct argv *a, const struct > env_set *es, c

Re: [Openvpn-devel] [PATCH 04/52] cleanup: remove C++ warnings

2012-03-06 Thread Samuli Seppänen
> Signed-off-by: Alon Bar-Lev > --- > httpdigest.c |4 ++-- > init.c |2 +- > misc.c |6 +++--- > options.c |4 ++-- > socket.c |4 ++-- > ssl_polarssl.c |6 -- > 6 files changed, 14 insertions(+), 12 deletions(-) > > diff --git a/httpdige

Re: [Openvpn-devel] [PATCH 02/52] package: rpm: strip should be handled by package management

2012-03-06 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/03/12 10:53, Samuli Seppänen wrote: > >> Signed-off-by: Alon Bar-Lev --- >> openvpn.spec.in |1 - 1 files changed, 0 insertions(+), 1 >> deletions(-) >> >> diff --git a/openvpn.spec.in b/openvpn.spec.in index >> c5178e9..c42e7c6 100644 ---

Re: [Openvpn-devel] [PATCH 02/52] package: rpm: strip should be handled by package management

2012-03-06 Thread Samuli Seppänen
> Signed-off-by: Alon Bar-Lev > --- > openvpn.spec.in |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/openvpn.spec.in b/openvpn.spec.in > index c5178e9..c42e7c6 100644 > --- a/openvpn.spec.in > +++ b/openvpn.spec.in > @@ -101,7 +101,6 @@ and portability to most majo