-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/03/12 10:53, Samuli Seppänen wrote:
>
>> Signed-off-by: Alon Bar-Lev <alon.bar...@gmail.com> ---
>> openvpn.spec.in | 1 - 1 files changed, 0 insertions(+), 1
>> deletions(-)
>>
>> diff --git a/openvpn.spec.in b/openvpn.spec.in index
>> c5178e9..c42e7c6 100644 --- a/openvpn.spec.in +++ b/openvpn.spec.in
>> @@ -101,7 +101,6 @@ and portability to most major OS platforms.
>> %build %configure --disable-dependency-tracking
>> %{?with_password_save:--enable-password-save}
>> %{?without_lzo:--disable-lzo}
>> %{?with_kerberos:--with-ssl-headers=/usr/kerberos/include} %__make
>> -%__strip %{name}
>>
>> # Build down-root plugin pushd plugin/down-root
>
> Let's see if I understood this correctly... the binary is stripped
> anyways when the package is installed? On a CentOS 6 box I have this
> in "rpm --showrc" output[1]:
>
> -14: __os_install_post %{_rpmconfigdir}/brp-compress
> %{_rpmconfigdir}/brp-strip %{_rpmconfigdir}/brp-strip-static-archive
> %{_rpmconfigdir}/brp-strip-comment-note
>
> If so, I give this one an ACK.
That's correct, according to what I remember from the Fedora packaging
guidelines. The .spec file should not strip packages explicit. The
rpmbuild process will take care of that, which will also create the
debuginfo files during that process. If explicit stripping the binaries
in the .spec file, there won't be any debuginfo files either.
The Fedora packaging rules also applies to EPEL, which then (kind of)
hits RHEL, CentOS and ScientificLinux as well.
kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk9V4FUACgkQDC186MBRfrogGwCdFnC9pPmXYjEFfFF0Yyon78kG
6aEAn207GtSWS437XpN9mDoCGtXNm3iI
=gJ2V
-----END PGP SIGNATURE-----
