Re: [Openvpn-devel] OpenVPN 2.2.0 build failure with "--disable-management"

2011-05-31 Thread Mr Dash Four
If this works for you, I'll take this as an ACK from you, then this patch will get into the queue for a 2.2.1 release. Yep, the patch works without a hitch, but when I now have this: configure \ --build=x86_64-redhat-linux-gnu \ --host=i686-redhat-linux-gnu \ --enable-password-save \ --enab

Re: [Openvpn-devel] [PATCH] USE_PF_INET6 by default for v2.3

2011-05-31 Thread JuanJo Ciarlante
Hi, On Tue, May 31, 2011 at 3:39 PM, Samuli Seppänen wrote: > JuanJo Ciarlante ha scritto: >> On Mon, May 30, 2011 at 6:20 PM, JuanJo wrote: >> >>> - put all #ifdef'd code in place, kill the cpp symbol, >>> - thus in v2.3 it's not actually possible to --disable-ipv6 :) >>> >>> RATIONALE: >>>  #1

Re: [Openvpn-devel] [PATCH 2/4] Fix Microsoft Visual Studio incompatibility in plugin.c

2011-05-31 Thread Gert Doering
Hi, On Thu, May 26, 2011 at 04:23:03PM +0300, Samuli Seppänen wrote: > MS Visual Studio don't like to have struct members named in the > variable declaration. Without this fix, Visual Studio is not able > to compile the new v3 plug-in API. ACK. Looks reasonable (what I've checked is: make sure

Re: [Openvpn-devel] OpenVPN 2.2.0 build failure with "--disable-management"

2011-05-31 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 31/05/11 17:09, Mr Dash Four wrote: > >> Quick fix: add --disable-pkcs11 in addition to --disable-management >> >> Can you try to apply the attached patch? I believe that might solve your >> compile issues. >> > Many thanks - I think applying t

Re: [Openvpn-devel] OpenVPN 2.2.0 build failure with "--disable-management"

2011-05-31 Thread Mr Dash Four
Quick fix: add --disable-pkcs11 in addition to --disable-management Can you try to apply the attached patch? I believe that might solve your compile issues. Many thanks - I think applying the patch would be easier (I'll just list it in the .spec file and include it during the rpm build) -

Re: [Openvpn-devel] OpenVPN 2.2.0 build failure with "--disable-management"

2011-05-31 Thread David Sommerseth
On 31/05/11 15:45, Mr Dash Four wrote: > configure \ > --build=x86_64-redhat-linux-gnu \ > --host=i686-redhat-linux-gnu \ > --enable-password-save \ > --enable-iproute2 \ > --with-ifconfig-path=/sbin/ifconfig \ > --with-iproute-path=/sbin/ip \ > --with-route-path=/sbin/route \ > --disable-port-sha

Re: [Openvpn-devel] Patch for socket.c / add_in6_addr() on Windows

2011-05-31 Thread Samuli Seppänen
> Hi, > > attached you'll find another patch that is needed to make OpenVPN compile > on Windows. After quite some consideration I have decided to change > the implementation for all platforms, as doing this with #ifdef WIN32 > would be messy at best. > > What the function in question does is "ad

Re: [Openvpn-devel] OpenVPN 2.2.0 build failure with "--disable-management"

2011-05-31 Thread Mr Dash Four
Our buildslave farm reported this problem, too. It should get fixed shortly in "master" branch and in 2.2 release branch: Thanks for the swift response. I'll wait until this is fixed so that I c

Re: [Openvpn-devel] OpenVPN 2.2.0 build failure with "--disable-management"

2011-05-31 Thread Samuli Seppänen
> configure \ > --build=x86_64-redhat-linux-gnu \ > --host=i686-redhat-linux-gnu \ > --enable-password-save \ > --enable-iproute2 \ > --with-ifconfig-path=/sbin/ifconfig \ > --with-iproute-path=/sbin/ip \ > --with-route-path=/sbin/route \ > --disable-port-share \ > --disable-management > > passes

[Openvpn-devel] OpenVPN 2.2.0 build failure with "--disable-management"

2011-05-31 Thread Mr Dash Four
configure \ --build=x86_64-redhat-linux-gnu \ --host=i686-redhat-linux-gnu \ --enable-password-save \ --enable-iproute2 \ --with-ifconfig-path=/sbin/ifconfig \ --with-iproute-path=/sbin/ip \ --with-route-path=/sbin/route \ --disable-port-share \ --disable-management passes through, but then I ge

Re: [Openvpn-devel] [PATCH] USE_PF_INET6 by default for v2.3

2011-05-31 Thread Samuli Seppänen
JuanJo Ciarlante ha scritto: > On Mon, May 30, 2011 at 6:20 PM, JuanJo wrote: > >> - put all #ifdef'd code in place, kill the cpp symbol, >> - thus in v2.3 it's not actually possible to --disable-ipv6 :) >> >> RATIONALE: >> #1 some wacky compilers choke on #ifdef'd constructions for >>conc

Re: [Openvpn-devel] [PATCH] Fix a Visual Studio 2008 build issue in socket.c

2011-05-31 Thread Gert Doering
Hi, On Tue, May 31, 2011 at 04:17:40PM +0300, Samuli Seppänen wrote: > Signed-off-by: Gert Doering > Signed-off-by: Samuli Seppänen > --- > socket.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/socket.c b/socket.c > index 69be132..6659bcc 100644 > --- a/socke

[Openvpn-devel] Patch for socket.c / add_in6_addr() on Windows

2011-05-31 Thread Gert Doering
Hi, attached you'll find another patch that is needed to make OpenVPN compile on Windows. After quite some consideration I have decided to change the implementation for all platforms, as doing this with #ifdef WIN32 would be messy at best. What the function in question does is "add a 32 bit offs

[Openvpn-devel] [PATCH] Fix a Visual Studio 2008 build issue in socket.c

2011-05-31 Thread Samuli Seppänen
Signed-off-by: Gert Doering Signed-off-by: Samuli Seppänen --- socket.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/socket.c b/socket.c index 69be132..6659bcc 100644 --- a/socket.c +++ b/socket.c @@ -647,8 +647,9 @@ update_remote (const char* host, if (host

Re: [Openvpn-devel] [PATCH] USE_PF_INET6 by default for v2.3

2011-05-31 Thread JuanJo Ciarlante
On Mon, May 30, 2011 at 6:20 PM, JuanJo wrote: > - put all #ifdef'd code in place, kill the cpp symbol, > - thus in v2.3 it's not actually possible to --disable-ipv6 :) > > RATIONALE: >  #1 some wacky compilers choke on #ifdef'd constructions for >    concatenated strings, and given that: >  #2 v2