Hi, On Tue, May 31, 2011 at 3:39 PM, Samuli Seppänen <sam...@openvpn.net> wrote: > JuanJo Ciarlante ha scritto: >> On Mon, May 30, 2011 at 6:20 PM, JuanJo <jjo...@google.com> wrote: >> >>> - put all #ifdef'd code in place, kill the cpp symbol, >>> - thus in v2.3 it's not actually possible to --disable-ipv6 :) >>> >>> RATIONALE: >>> #1 some wacky compilers choke on #ifdef'd constructions for >>> concatenated strings, and given that: >>> #2 v2.3 has already transport ipv6 by default >>> => doesn't justify putting effort on #1 to keep USE_PF_INET6 >>> ifdef wraps. >>> >>> Signed-off-by: JuanJo Ciarlante <jjo...@google.com> >>> <...snip...> >>> >> >> FWIW you can also peek at the diff at: >> >> https://github.com/jjo/openvpn-ipv6/commit/77fed9c07c1461cd926ab4e86c587cac8414b957 >> http://codereview.appspot.com/4564045/ >> >> Cheers, >> > Hi JuanJo, > > This patch did not apply on top of the earlier "Visual Studio 2008 build > fix" patches applied on top of "master". There was one whitespace error > and it choked on syshead.h due to a new #include. Besides that it worked > great!
Thanks Samuli for stuffing those bits :) ! > > A fixed patch is attached. Shameless ACK 8) Cheers, > > -- > > Samuli Seppänen > Community Manager > OpenVPN Technologies, Inc > > irc freenode net: mattock > > -- --JuanJo ; echo j...@gomosglep.com | sed 's/[SPAM]//g'
