Re: [Openvpn-devel] [IPv6 support] - usage of gethostbyname() in getaddr()

2010-02-17 Thread Stefan Monnier
> When reviewing the patch "FQDN for routes should expand to all IPs" > today, I spotted that there is a function called getaddr() (renamed to > getaddr_all() in the mentioned patch). This function again makes use of > the old gethostbyname() function. This is not compatible with IPv6 > addresses

Re: [Openvpn-devel] [PATCH] FQDN for routes should expand to all IPs

2010-02-17 Thread Stefan Monnier
> Thanks a lot for you patch! In general, it very looks good. Can you > elaborate a little bit on how you have tested this patch? I've been using it on my client machines for the last few months. This is not a very extensive test, obviously: they're all configured identically and so they all loo

Re: [Openvpn-devel] [IPv6 support] - usage of gethostbyname() in getaddr()

2010-02-17 Thread JuanJo Ciarlante
On Wed, Feb 17, 2010 at 2:47 PM, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi all! > > When reviewing the patch "FQDN for routes should expand to all IPs" > today, I spotted that there is a function called getaddr() (renamed to > getaddr_all() in the mentioned p

Re: [Openvpn-devel] openvpn-testing tree available

2010-02-17 Thread JuanJo Ciarlante
Hi David, On Tue, Feb 16, 2010 at 7:49 PM, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Greetings all! > > I am now announcing the openvpn-testing.git tree as open.  Gert has > already been announcing the availability as a response to some merge > conflicts.  An

Re: [Openvpn-devel] openvpn-testing tree available

2010-02-17 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 16/02/10 19:49, David Sommerseth wrote: > > Greetings all! > [...snip...] > > What's next: > [...snip...] > > - Update the developers documentation on the wiki, with some > "requirements" to get patches included. For already submitted patches

Re: [Openvpn-devel] [IPv6 support] - usage of gethostbyname() in getaddr()

2010-02-17 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 17/02/10 17:20, Gert Doering wrote: > Hi, > > On Wed, Feb 17, 2010 at 02:47:28PM +0100, David Sommerseth wrote: >> When reviewing the patch "FQDN for routes should expand to all IPs" >> today, I spotted that there is a function called getaddr() (re

Re: [Openvpn-devel] [IPv6 support] - usage of gethostbyname() in getaddr()

2010-02-17 Thread Gert Doering
Hi, On Wed, Feb 17, 2010 at 02:47:28PM +0100, David Sommerseth wrote: > When reviewing the patch "FQDN for routes should expand to all IPs" > today, I spotted that there is a function called getaddr() (renamed to > getaddr_all() in the mentioned patch). This function again makes use of > the old

Re: [Openvpn-devel] [PATCH] FQDN for routes should expand to all IPs

2010-02-17 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 17/02/10 06:17, Stefan Monnier wrote: > [ I've sent this in the past already, but just trying to make sure it > doesn't get lost somewhere. ] > > When specifiying an FQDN for the network part of a route, OpenVPN should > setup a route for each IP

[Openvpn-devel] [IPv6 support] - usage of gethostbyname() in getaddr()

2010-02-17 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all! When reviewing the patch "FQDN for routes should expand to all IPs" today, I spotted that there is a function called getaddr() (renamed to getaddr_all() in the mentioned patch). This function again makes use of the old gethostbyname() functio

Re: [Openvpn-devel] [PATCH] Reworked the eurephia patch for inclusion to the openvpn-testing tree

2010-02-17 Thread Samuli Seppänen
We could discuss this crypto issue with James in the IRC meeting tomorrow. He should also be able to provide useful feedback about the patches in general. Samuli > Someone with a better understanding of the crypto stuff should verify > that the ctx->current_cert->sha1_hash is always valid, and po

[Openvpn-devel] [PATCH] FQDN for routes should expand to all IPs

2010-02-17 Thread Stefan Monnier
[ I've sent this in the past already, but just trying to make sure it doesn't get lost somewhere. ] When specifiying an FQDN for the network part of a route, OpenVPN should setup a route for each IP associated with that FQDN. Currently, it just chooses one of the IPs at random instead, which le