> Thanks a lot for you patch!  In general, it very looks good.  Can you
> elaborate a little bit on how you have tested this patch?

I've been using it on my client machines for the last few months.
This is not a very extensive test, obviously: they're all configured
identically and so they all lookup the same FQDNs received from the same
VPN server.

> Have you checked it for memory leaks?  (e.g. using valgrind)

No, my patch does not use dynamic memory allocation, so memory leaks
seem unlikely (tho I don't know enough of the functions I call to be
100% sure).

> What happens if no FQDNs are found?

I have not touched this part of the code, AFAIK, so the behavior should
be the same as before (not sure what it is).


        Stefan

Reply via email to