Re: [openstack-dev] [Heat] Reducing pep8 ignores

2014-01-23 Thread Zane Bitter
On 22/01/14 23:19, ZhiQiang Fan wrote: you can split H306 to several patches since it contains so much files. optional: It would be really nice if you can fix the unused import problem (if exist) in the same time, this seems can be checked via IDE That check is already enabled. On Wed, Jan

Re: [openstack-dev] [Heat] Reducing pep8 ignores

2014-01-23 Thread Ben Nemec
On 2014-01-22 22:13, Zane Bitter wrote: On 22/01/14 06:23, Pavlo Shchelokovskyy wrote: Hi all, we have an approved blueprint that concerns reducing number of ignored PEP8 and openstack/hacking style checks for heat (https://blueprints.launchpad.net/heat/+spec/reduce-flake8-ignored-rules). I've

Re: [openstack-dev] [Heat] Reducing pep8 ignores

2014-01-23 Thread Ben Nemec
On 2014-01-23 04:16, Steven Hardy wrote: On Thu, Jan 23, 2014 at 07:54:34AM +1000, Angus Salkeld wrote: On 22/01/14 12:21 +, Steven Hardy wrote: >On Wed, Jan 22, 2014 at 01:23:05PM +0200, Pavlo Shchelokovskyy wrote: >>Hi all, >> >>we have an approved blueprint that concerns reducing number o

Re: [openstack-dev] [Heat] Reducing pep8 ignores

2014-01-23 Thread Steven Hardy
On Thu, Jan 23, 2014 at 07:54:34AM +1000, Angus Salkeld wrote: > On 22/01/14 12:21 +, Steven Hardy wrote: > >On Wed, Jan 22, 2014 at 01:23:05PM +0200, Pavlo Shchelokovskyy wrote: > >>Hi all, > >> > >>we have an approved blueprint that concerns reducing number of ignored PEP8 > >>and openstack/h

Re: [openstack-dev] [Heat] Reducing pep8 ignores

2014-01-22 Thread ZhiQiang Fan
you can split H306 to several patches since it contains so much files. optional: It would be really nice if you can fix the unused import problem (if exist) in the same time, this seems can be checked via IDE On Wed, Jan 22, 2014 at 7:23 PM, Pavlo Shchelokovskyy < pshchelokovs...@mirantis.com>

Re: [openstack-dev] [Heat] Reducing pep8 ignores

2014-01-22 Thread Zane Bitter
On 22/01/14 06:23, Pavlo Shchelokovskyy wrote: Hi all, we have an approved blueprint that concerns reducing number of ignored PEP8 and openstack/hacking style checks for heat (https://blueprints.launchpad.net/heat/+spec/reduce-flake8-ignored-rules). I've been already warned that enabling some of

Re: [openstack-dev] [Heat] Reducing pep8 ignores

2014-01-22 Thread Angus Salkeld
On 22/01/14 12:21 +, Steven Hardy wrote: On Wed, Jan 22, 2014 at 01:23:05PM +0200, Pavlo Shchelokovskyy wrote: Hi all, we have an approved blueprint that concerns reducing number of ignored PEP8 and openstack/hacking style checks for heat ( https://blueprints.launchpad.net/heat/+spec/reduce

Re: [openstack-dev] [Heat] Reducing pep8 ignores

2014-01-22 Thread Sean Dague
On 01/22/2014 06:23 AM, Pavlo Shchelokovskyy wrote: > Hi all, > > we have an approved blueprint that concerns reducing number of ignored > PEP8 and openstack/hacking style checks for heat > (https://blueprints.launchpad.net/heat/+spec/reduce-flake8-ignored-rules). > I've been already warned that e

Re: [openstack-dev] [Heat] Reducing pep8 ignores

2014-01-22 Thread Steven Hardy
On Wed, Jan 22, 2014 at 01:23:05PM +0200, Pavlo Shchelokovskyy wrote: > Hi all, > > we have an approved blueprint that concerns reducing number of ignored PEP8 > and openstack/hacking style checks for heat ( > https://blueprints.launchpad.net/heat/+spec/reduce-flake8-ignored-rules). > I've been al