On 22/01/14 23:19, ZhiQiang Fan wrote:
you can split H306 to several patches since it contains so much files.
optional: It would be really nice if you can fix the unused import
problem (if exist) in the same time, this seems can be checked via IDE
That check is already enabled.
On Wed, Jan 22, 2014 at 7:23 PM, Pavlo Shchelokovskyy
<pshchelokovs...@mirantis.com <mailto:pshchelokovs...@mirantis.com>> wrote:
Hi all,
we have an approved blueprint that concerns reducing number of
ignored PEP8 and openstack/hacking style checks for heat
(https://blueprints.launchpad.net/heat/+spec/reduce-flake8-ignored-rules).
I've been already warned that enabling some of these rules will be
quite controversial, and personally I do not like some of these
rules myself either. In order to understand what is the opinion of
the community, I would like to ask you to leave a comment on the
blueprint page about what do you think about enabling these checks.
The style rules being currently ignored are:
F841 local variable 'json_template' is assigned to but never used
H201 no 'except:' at least use 'except Exception:' (this actually
checks for bare 'except:' lines, so 'except BaseException:' will
pass too)
H302 do not import objects, only modules (this I don't like myself
as it can clutter the code beyond reasonable limit)
H306 imports not in alphabetical order
H404 multi line docstring should start with a summary
Another question I have is how to proceed with such changes. I've
already implemented H306 (order of imports) and am being now puzzled
with how to propose such change to Gerrit. This change naturally
touches many files (163 so far) and as such is clearly not suited
for review in one piece. The only solution I currently can think of
is to split it in 4-5-6 patches without actually changing tox.ini,
and after all of them are merged, issue a final patch that updates
tox.ini and any files breaking the rule that were introduced in
between. But there is still a question on how Jenkins works with
verify and merge jobs. Can it happen that we end up with code in
master that does not pass pep8 check? Or there will be a 'race
condition' between my final patch and any other that breaks the
style rules? I would really appreciate any thoughts and comments
about this.
Best regards,
Pavlo Shchelokovskyy.
_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
<mailto:OpenStack-dev@lists.openstack.org>
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
--
blog: zqfan.github.com <http://zqfan.github.com>
git: github.com/zqfan <http://github.com/zqfan>
_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
