Re: [openstack-dev] [Fuel] Default templates for Sahara feature in 6.0

2014-11-17 Thread Denis Egorenko
Hi guys, I've created spec for this patch: https://review.openstack.org/#/c/134937/ Please, check out it. 2014-11-17 15:41 GMT+04:00 Mike Scherbakov : > I'm fine with getting this patch in... > though a few things should be fixed first, in my opinion: > >1. I don't see a header in the bluep

Re: [openstack-dev] [Fuel] Default templates for Sahara feature in 6.0

2014-11-17 Thread Mike Scherbakov
I'm fine with getting this patch in... though a few things should be fixed first, in my opinion: 1. I don't see a header in the blueprint, who is responsible for what. See example in the blueprint: https://blueprints.launchpad.net/fuel/+spec/send-anon-usage (Feature Lead, QA, etc.)

Re: [openstack-dev] [Fuel] Default templates for Sahara feature in 6.0

2014-11-14 Thread Dmitry Mescheryakov
Dmitry, Lets review the CR from the point of danger to current deployment process: in the essence it is 43 lines of change in puppet module. The module calls a shell script which always returns 0. So whatever happens inside, the deployment will not fail. The only changes (non-get requests) the sc

Re: [openstack-dev] [Fuel] Default templates for Sahara feature in 6.0

2014-11-14 Thread Dmitry Mescheryakov
Oops, the last line should be read as "On the other side, it is a nice UX feature we really want to have 6.0" Dmitry 2014-11-15 3:50 GMT+03:00 Dmitry Mescheryakov : > Dmitry, > > Lets review the CR from the point of danger to current deployment process: > in the essence it is 43 lines of change

Re: [openstack-dev] [Fuel] Default templates for Sahara feature in 6.0

2014-11-14 Thread Dmitry Borodaenko
+286 lines a week after Feature Freeze, IMHO it's too late to make an exception for this one. On Wed, Nov 12, 2014 at 7:37 AM, Dmitry Mescheryakov wrote: > Hello fuelers, > > I would like to request you merging CR [1] which implements blueprint [2]. > It is a nice UX feature we really would like

[openstack-dev] [Fuel] Default templates for Sahara feature in 6.0

2014-11-12 Thread Dmitry Mescheryakov
Hello fuelers, I would like to request you merging CR [1] which implements blueprint [2]. It is a nice UX feature we really would like to have in 6.0. On the other side, the implementation is really small: it is a small piece of puppet which runs a shell script. The script always exits with 0, so