Hi guys, I've created spec for this patch: https://review.openstack.org/#/c/134937/
Please, check out it. 2014-11-17 15:41 GMT+04:00 Mike Scherbakov <mscherba...@mirantis.com>: > I'm fine with getting this patch in... > though a few things should be fixed first, in my opinion: > > 1. I don't see a header in the blueprint, who is responsible for what. > See example in the blueprint: > https://blueprints.launchpad.net/fuel/+spec/send-anon-usage (Feature > Lead, QA, etc.) > 2. There is no fuel-spec associated. If this is very minor thing to > address, which doesn't affect anything beyond, then we probably better to > track this as bug. > 3. Currently, it's not very clear to me from description what this is > for. Can you please provide more information, ideally what are the use > cases, and acceptance criteria for proposed functionality? > > We have FF deadline not just because features can affect other features > stability, but also because we will need time to assure they are of > production quality by themselves. Slipping this to the end of the release > naturally increases risks for quality. > > Thanks, > > On Sat, Nov 15, 2014 at 3:51 AM, Dmitry Mescheryakov < > dmescherya...@mirantis.com> wrote: > >> Oops, the last line should be read as >> "On the other side, it is a nice UX feature we really want to have 6.0" >> >> Dmitry >> >> 2014-11-15 3:50 GMT+03:00 Dmitry Mescheryakov <dmescherya...@mirantis.com >> >: >> >>> Dmitry, >>> >>> Lets review the CR from the point of danger to current deployment >>> process: in the essence it is 43 lines of change in puppet module. The >>> module calls a shell script which always returns 0. So whatever happens >>> inside, the deployment will not fail. >>> >>> The only changes (non-get requests) the script does, it does to Sahara. >>> It tries to upload cluster and node-group templates. That is not dangerous >>> operation for Sahara - in the worst case the templates will just not be >>> created and that is all. It will not affect Sahara correctness in any way. >>> >>> On the other side, it is a nice UX feature we really want to have 5.1.1. >>> >>> Thanks, >>> >>> Dmitry >>> >>> >>> 2014-11-15 3:04 GMT+03:00 Dmitry Borodaenko <dborodae...@mirantis.com>: >>> >>>> +286 lines a week after Feature Freeze, IMHO it's too late to make an >>>> exception for this one. >>>> >>>> On Wed, Nov 12, 2014 at 7:37 AM, Dmitry Mescheryakov >>>> <dmescherya...@mirantis.com> wrote: >>>> > Hello fuelers, >>>> > >>>> > I would like to request you merging CR [1] which implements blueprint >>>> [2]. >>>> > It is a nice UX feature we really would like to have in 6.0. On the >>>> other >>>> > side, the implementation is really small: it is a small piece of >>>> puppet >>>> > which runs a shell script. The script always exits with 0, so the >>>> change >>>> > should not be dangerous. Other files in the change are used in the >>>> shell >>>> > script only. Please consider reviewing and merging this though we've >>>> already >>>> > reached FF. >>>> > >>>> > Thanks, >>>> > >>>> > Dmitry >>>> > >>>> > [1] https://review.openstack.org/#/c/132196/ >>>> > [2] >>>> > >>>> https://blueprints.launchpad.net/mos/+spec/sahara-create-default-templates >>>> > >>>> > _______________________________________________ >>>> > OpenStack-dev mailing list >>>> > OpenStack-dev@lists.openstack.org >>>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >>>> > >>>> >>>> >>>> >>>> -- >>>> Dmitry Borodaenko >>>> >>>> _______________________________________________ >>>> OpenStack-dev mailing list >>>> OpenStack-dev@lists.openstack.org >>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >>>> >>> >>> >> >> _______________________________________________ >> OpenStack-dev mailing list >> OpenStack-dev@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> > > > -- > Mike Scherbakov > #mihgen > > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- Best Regards, Egorenko Denis
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
