Re: test/heartbleed_test.c

2014-05-20 Thread Ben Laurie
On 20 May 2014 15:17, Ken Goldman wrote: > On 5/20/2014 7:24 AM, Ben Laurie wrote: >> >> >> There is already a strndup replacement: BUF_strndup(). Switching to >> use that would be better. > > > However > > - if that function points to strndup, don't you still have the problem if > strndup doesn't

RE: test/heartbleed_test.c

2014-05-20 Thread Michael Wojcik
> -Original Message- > From: owner-openssl-us...@openssl.org [mailto:owner-openssl- > us...@openssl.org] On Behalf Of Ken Goldman > Sent: Tuesday, 20 May, 2014 10:16 > To: openssl-users@openssl.org > Subject: Re: test/heartbleed_test.c > > It's logical to me.

Re: test/heartbleed_test.c

2014-05-20 Thread Ken Goldman
It's logical to me. If the tool chain has a strndup, use it. If it doesn't, here it is. There won't be a namespace clash if the function doesn't exist. On 5/20/2014 8:14 AM, Michael Wojcik wrote: External symbols beginning with "str" are reserved to the library by the C standard (ISO 9899-199

Re: test/heartbleed_test.c

2014-05-20 Thread Ken Goldman
On 5/20/2014 7:24 AM, Ben Laurie wrote: There is already a strndup replacement: BUF_strndup(). Switching to use that would be better. However - if that function points to strndup, don't you still have the problem if strndup doesn't exist? - if that function is a reimplementation of strndup

Re: test/heartbleed_test.c

2014-05-20 Thread Ben Laurie
On 20 May 2014 06:40, The Doctor,3328-138 Ave Edmonton AB T5Y 1M4,669-2000,473-4587 wrote: > Found that strndup would not work. > > I had to add > > #if !HAVE_STRNDUP > > #include > #include > #include > #include > > /* Find the length of STRING, but scan at most MAXLEN characters. >If no

RE: test/heartbleed_test.c

2014-05-20 Thread Michael Wojcik
External symbols beginning with "str" are reserved to the library by the C standard (ISO 9899-1999 et seq). It's a violation of the standard to define them outside the implementation. You should use function names in the user namespace and if necessary use value-style macros to replace the reser