Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

2011-04-19 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/#review631 --- Could you please provide the patch description? I.e what the probl

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

2011-04-20 Thread Vadim ProductEngine
> On April 19, 2011, 8:02 a.m., Vadim ProductEngine wrote: > > Could you please provide the patch description? I.e what the problem was > > and how you fixed it. > > Ima Mechanique wrote: > I'm not sure what you want here. > If you're asking what I

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

2011-04-20 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/#review637 --- indra/llui/llnotifications.cpp

Re: [opensource-dev] Review Request: STORM-956 Ability to mute dialogs by muting object (or object owner)

2011-04-21 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/275/#review640 --- Ship it! Looks fine to me. - Vadim On April 20, 2011, 2:33 p.m

Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

2011-04-21 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/252/#review641 --- Ship it! I assume you'll add the comment before committing this.

[opensource-dev] Review Request: STORM-1093 "Dock" icon is still shown after a side panel has been docked with Ctrl+Shift+W

2011-04-22 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/276/ --- Review request for Viewer and Richard Nelson. Summary --- Reason: When

Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

2011-04-25 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/277/#review647 --- Ship it! Looks good, thanks. One note that applies to my patch a

Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

2011-04-25 Thread Vadim ProductEngine
> On April 25, 2011, 10:27 a.m., Vadim ProductEngine wrote: > > Looks good, thanks. > > > > One note that applies to my patch as well: rfind() seems to fit better than > > find() in this case. > > Boroondas Gupte wrote: > Using string::rfind instead of

Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

2011-04-26 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/277/#review650 --- Ship it! - Vadim On April 25, 2011, 4:40 p.m., Boroondas Gupte

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

2011-05-10 Thread Vadim ProductEngine
> On April 20, 2011, 9:01 a.m., Vadim ProductEngine wrote: > > indra/llui/llnotifications.cpp, line 1536 > > <http://codereview.secondlife.com/r/271/diff/1/?file=1484#file1484line1536> > > > > LLNotificationsUtil is a wrapper around LLNotifications. Calling

Re: [opensource-dev] Review Request: STORM-951 Accidental Self-Muting/Self-Blocking

2011-05-10 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/303/#review691 --- indra/newview/llnotificationofferhandler.cpp

Re: [opensource-dev] Review Request: (STORM-229) Loading Scripts takes a long time and stalls Viewer

2011-05-11 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/273/ --- (Updated May 11, 2011, 2:18 a.m.) Review request for Viewer and Richard Nel

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

2011-05-11 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/#review693 --- Ship it! Thanks. - Vadim On May 11, 2011, 6:56 a.m., Ima Mecha

[opensource-dev] Review Request: STORM-1339 Crash in LLPanelPlaces::onTeleportButtonClicked

2011-06-15 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/339/ --- Review request for Viewer. Summary --- I could not reproduce the crash

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

2011-06-15 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/326/#review751 --- See minor points below. indra/newview/llcofwearables.cpp

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

2011-06-15 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/326/#review755 --- Ship it! Thanks. - Vadim On June 15, 2011, 10:04 a.m., Jonatha

[opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

2011-06-16 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/341/ --- Review request for Viewer. Summary --- Apparently, a nearby chat toast

Re: [opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

2011-06-16 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/341/ --- (Updated June 16, 2011, 1:52 p.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

2011-06-20 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/341/ --- (Updated June 20, 2011, 6:55 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: VWR-26066: request LLFloaterWorldMap child "zoom slider" with correct type to get rid of warning when opening map flaoter

2011-06-20 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/350/#review776 --- Ship it! - Vadim On June 20, 2011, 6:35 a.m., Boroondas Gupte w

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-20 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/#review778 --- Seems to work for me, although I'd appreciate if you used a more

Re: [opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

2011-06-20 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/341/#review779 --- On June 20, 2011, 6:55 a.m., Vadim ProductEngine wrote: > > --

Re: [opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

2011-06-20 Thread Vadim ProductEngine
e case of handling illegal arguments. - Vadim --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/341/#review759 --- On June 20, 2011

Re: [opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

2011-06-20 Thread Vadim ProductEngine
y cheap): > > LLToast* toast_1 = first.get(); > LLToast* toast_2 = second.get(); > > bool inOrder = false; // default return value, in case one or both > toasts don't exist > > if (toast_1 && toast_2) // Toasts m

Re: [opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

2011-06-20 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/341/ --- (Updated June 20, 2011, 3:29 p.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: Enable watchdog timer for Beta crash hunting.

2011-06-20 Thread Vadim ProductEngine
> On June 14, 2011, 2:50 p.m., Alain Linden wrote: > > indra/newview/app_settings/settings.xml, line 12409 > > > > > > I presume this means trigger the watchdog after 20 seconds of 'freeze'. > > Jenn wrote: > :)

Re: [opensource-dev] Review Request: Local Bitmap Browser implementation.

2011-06-21 Thread Vadim ProductEngine
> On June 20, 2011, 2:19 p.m., Vadim ProductEngine wrote: > > indra/newview/llfloaterlocalbitmap.h, lines 79-80 > > <http://codereview.secondlife.com/r/347/diff/1/?file=3004#file3004line79> > > > > Consider using enums instead. Or rather typed constant

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-21 Thread Vadim ProductEngine
> On June 20, 2011, 9:49 a.m., Vadim ProductEngine wrote: > > indra/newview/llvoicevivox.cpp, lines 4485-4488 > > <http://codereview.secondlife.com/r/333/diff/1/?file=2939#file2939line4485> > > > > What if region caps never arrive? >

Re: [opensource-dev] Review Request: VWR-25965 LLDirIterator fixes in the viewer cache migration and VFS fallback.

2011-06-21 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/324/ --- (Updated June 21, 2011, 8:33 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: Check for null ptr to hopefully prevent crash in LLToolPie

2011-06-21 Thread Vadim ProductEngine
Updated June 21, 2011, 8:53 a.m.) > > > Review request for Viewer, Oz Linden and Vadim ProductEngine. > > > Summary > --- > > checking for null gAgentAvatarp should hopefully prevent the crash. I can't > reproduce it so I don't know for sure. > &

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-21 Thread Vadim ProductEngine
> On June 20, 2011, 9:49 a.m., Vadim ProductEngine wrote: > > indra/newview/llvoicevivox.cpp, line 557 > > <http://codereview.secondlife.com/r/333/diff/1/?file=2939#file2939line557> > > > > Inconsistent spacing around "if" conditions. > >

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-24 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/#review815 --- Ship it! No major objections now, thanks. - Vadim On June 24,

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-28 Thread Vadim ProductEngine
> On June 25, 2011, 8:30 a.m., Tankmaster Finesmith wrote: > > When I applied this latest patch to firestorm, which is based off of LL > > 2.5.2, I kept getting timed out when TPing from a mainland area and a DD of > > 256 to other regions. I tried multiple times TPing from the area around >

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-29 Thread Vadim ProductEngine
> > in addition to the library. It also only has 2 attachments (a hud and the > > firestorm bridge) and is one of the noob outfits. I also am running on an > > i7 2600k, 16GB ram, ATI 6970, and 20/5mbit FIOS connection. > > Vadim ProductEngine wrote: > Could you ple

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

2011-06-29 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/#review825 --- Looking good overall. Please fix the minor issues. indra/newview

Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

2011-06-29 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/#review826 --- Looks good apart from missing NULL check. indra/newview/llpanelw

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

2011-06-30 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/#review831 --- Ship it! Fine with me. Although, if you correct the cosmetic issu

Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

2011-06-30 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/#review834 --- Ship it! No major objections. indra/newview/llpanelwearing.cpp

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

2011-06-30 Thread Vadim ProductEngine
> On June 30, 2011, 9:29 a.m., Vadim ProductEngine wrote: > > indra/newview/llpanelpermissions.cpp, line 1027 > > <http://codereview.secondlife.com/r/365/diff/2-3/?file=3041#file3041line1027> > > > > CS: check_purchase or better check_purchase_cb > &g

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

2011-07-04 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/377/#review836 --- Ship it! Looks good code-wise. indra/llmath/llcalc.cpp

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

2011-07-04 Thread Vadim ProductEngine
> On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote: > > indra/llui/llspinctrl.cpp, line 127 > > <http://codereview.secondlife.com/r/377/diff/6/?file=6493#file6493line127> > > > > I'd add a note that we don't prevalidate because of the calcul

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

2011-07-04 Thread Vadim ProductEngine
> On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote: > > indra/llui/llspinctrl.cpp, lines 128-135 > > <http://codereview.secondlife.com/r/377/diff/6/?file=6493#file6493line128> > > > > dead code > > Kadah Coba wrote: > Remove? Yes, our

Re: [opensource-dev] Review Request: Searching in the world map clears the destination arrow but not the destination beacon

2011-07-04 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/379/#review840 --- Ship it! - Vadim On July 1, 2011, 5:25 p.m., Kadah Coba wrote:

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

2011-07-04 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/377/#review841 --- Ship it! Thanks. - Vadim On July 4, 2011, 2:22 p.m., Kadah Cob

[opensource-dev] Review Request: STORM-1481 Jerky transition when switching region from fixed sky to a day cycle

2011-07-06 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/382/ --- Review request for Viewer. Summary --- When uploading new region envir

[opensource-dev] Review Request: STORM-1483 Unable to delete the last water/sky/day preset

2011-07-07 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/384/ --- Review request for Viewer. Summary --- Fixed a wrong condition. This

[opensource-dev] Review Request: STORM-1484 No way to apply changes in estate settings like Allow public access or Allow Voice Chat after merging WLRS

2011-07-07 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/385/ --- Review request for Viewer. Summary --- Restored Apply button in the Es

Re: [opensource-dev] Review Request: STORM-1460 (Cursor doesn't go to the input field on the Find Floater due to lack of window focus)

2011-07-08 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/386/#review853 --- I think this is a hack. The embedded browser should not differ fro

Re: [opensource-dev] Review Request: OPEN-99: use -march=pentium3 and -march=pentium4 only for 32 bit builds

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/351/#review858 --- Ship it! Looks plausible. - Vadim On July 10, 2011, 12:59 p.m.

Re: [opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape.

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/388/#review860 --- Ship it! No objections. - Vadim On July 11, 2011, 7:34 p.m., W

Re: [opensource-dev] Review Request: OPEN-46: Copy3rdPartyLibs.cmake needs to account for Visual Studio 10 and Visual Studio 10 Express.

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/131/ --- (Updated July 12, 2011, 11:04 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-64: Local Bitmap Browser implementation.

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/347/ --- (Updated July 12, 2011, 11:07 a.m.) Review request for Viewer. Summary (u

Re: [opensource-dev] Review Request: Viewer cache UI improvements.

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/321/#review861 --- Log, is there a JIRA ticket associated with these changes? - Vadi

Re: [opensource-dev] Review Request: OPEN-13: Debugging autobuild post build re-configuration error

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/137/ --- (Updated July 12, 2011, 11:12 a.m.) Review request for Viewer. Summary (u

Re: [opensource-dev] Review Request: STORM-1017: Attachments may loose their associated inventory item UUID

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/161/ --- (Updated July 12, 2011, 11:15 a.m.) Review request for Viewer. Summary (u

Re: [opensource-dev] Review Request: STORM-1112 Implement SOCKS 5 Proxy for the viewer

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/232/ --- (Updated July 12, 2011, 11:18 a.m.) Review request for Viewer. Summary (u

Re: [opensource-dev] Review Request: STORM-1112 Support SOCKS 5 proxy in the viewer (take 2)

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/374/ --- (Updated July 12, 2011, 11:20 a.m.) Review request for Viewer, Oz Linden, M

Re: [opensource-dev] Review Request: STORM-1068 Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/ --- (Updated July 12, 2011, 11:23 a.m.) Review request for Viewer. Summary (u

Re: [opensource-dev] Review Request: OPEN-69 Convert autobuild library builds to use msbuild.exe instead of devenv.com.

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/312/ --- (Updated July 12, 2011, 11:35 a.m.) Review request for Viewer. Summary (u

Re: [opensource-dev] Review Request: OPEN-66 Update autobuilds default VC version to 2010

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/305/ --- (Updated July 12, 2011, 11:36 a.m.) Review request for Viewer. Summary (u

Re: [opensource-dev] Review Request: OPEN-21 patch to let 3D connexion devices work on linux with kernel 2.6.35 or newer

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/322/ --- (Updated July 12, 2011, 11:37 a.m.) Review request for Viewer. Summary (u

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/#review862 --- Diff r4 looks broken to me. And yes, a clean fork would be nice.

Re: [opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/ --- (Updated July 12, 2011, 11:42 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-58 Allow objects to have 99.99% max hollow for default hollow shape.

2011-07-12 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/388/ --- (Updated July 12, 2011, 11:47 a.m.) Review request for Viewer. Summary (u

[opensource-dev] Review Request: STORM-1502 Disable "Delete Water/Sky/Day Preset" dialogs if no user presets exist

2011-07-13 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/392/ --- Review request for Viewer. Summary --- This patch disables the corresp

Re: [opensource-dev] Review Request: STORM-1503 (Find floater doesn't set focus to its browser)

2011-07-13 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/393/#review870 --- Ship it! Looks like this is what Richard suggested. - Vadim On

[opensource-dev] Review Request: STORM-1506 Regions set to Fixed Sun with viewers < 2.8 are not reset correctly when set to use a Day Cycle

2011-07-15 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/397/ --- Review request for Viewer. Summary --- Reset the estate to global sun

Re: [opensource-dev] Review Request: (STORM-1221) [HARD CODED] ALL LANGS Several strings are untranslated under Group Profile Land/Assets (French viewer)

2011-07-19 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/400/#review890 --- Looking good overall. indra/newview/skins/default/xui/en/strings

Re: [opensource-dev] Review Request: (STORM-1221) [HARD CODED] ALL LANGS Several strings are untranslated under Group Profile Land/Assets (French viewer)

2011-07-19 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/400/#review891 --- Ship it! - Vadim On July 19, 2011, 7:20 a.m., Seth ProductEngin

[opensource-dev] Review Request: STORM-1487 Gestures -> Get more leads to wrong URL

2011-07-19 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/401/ --- Review request for Viewer. Summary --- Changed the URL. This address

Re: [opensource-dev] Review Request: STORM-1474 Implement Show Last Search in viewer chrome

2011-07-22 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/402/#review909 --- Ship it! - Vadim On July 22, 2011, 5:10 a.m., Paul ProductEngin

[opensource-dev] Review Request: STORM-1311 Place Profile only shows 2 lines and users have to click More link to see full description

2011-07-22 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/409/ --- Review request for Viewer. Summary --- Provide more space for parcel d

[opensource-dev] Review Request: STORM-1451 "Login failed" message is empty in Danish

2011-07-22 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/410/ --- Review request for Viewer. Summary --- Straightforward notification te

[opensource-dev] Review Request: STORM-1408 [DE] Text truncation in Edit outfit floater

2011-07-22 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/411/ --- Review request for Viewer. Summary --- Overridden the Save button widt

[opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

2011-07-22 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/ --- Review request for Viewer. Summary --- Bug reason: incorrect reuse of

Re: [opensource-dev] Review Request: VWR-26458: fixing a simple typo in German translation

2011-07-23 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/408/#review914 --- Ship it! - Vadim On July 21, 2011, 3:42 p.m., Boroondas Gupte w

Re: [opensource-dev] Review Request: STORM-1523: fixing a simple typo in German translation

2011-07-23 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/408/ --- (Updated July 23, 2011, 6:49 a.m.) Review request for Viewer. Changes ---

[opensource-dev] Review Request: STORM-565 llGiveInventory window is suppressed if avatar in Busy mode

2011-07-25 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/413/ --- Review request for Viewer. Summary --- Allow inventory offers from obj

[opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

2011-07-25 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/ --- Review request for Viewer. Summary --- Localized sim product name (e.g

Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

2011-07-25 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/#review917 --- Rejecting this fix in favor of a duplicate (but I think better) on

[opensource-dev] Review Request: STORM-1233 Untranslated Profile button in the Places panel

2011-07-25 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/415/ --- Review request for Viewer. Summary --- Made the button translatable by

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

2011-07-25 Thread Vadim ProductEngine
- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/#review920 ------- On July 22, 2011, 10:51 a.m., Vadim ProductEngine wrote: > > --

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

2011-07-25 Thread Vadim ProductEngine
s? Not sure whether it makes sense. I'll find out. - Vadim --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/#review923 -

Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

2011-07-25 Thread Vadim ProductEngine
s is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/#review925 --- On July 25, 2011, 7:36 a.m., Vadim ProductEngine wrote: > > --

Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

2011-07-25 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/ --- (Updated July 25, 2011, 1:51 p.m.) Review request for Viewer. Changes ---

[opensource-dev] Review Request: STORM-1291 [STRING IN ENG] Gestos button. Many gestures.

2011-07-26 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/416/ --- Review request for Viewer and Richard Nelson. Summary --- Localize nam

[opensource-dev] Review Request: STORM-1405 Untranslated items in Sound Devices drop-down list

2011-07-26 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/417/ --- Review request for Viewer. Summary --- Localized the "No Device" and "

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

2011-07-26 Thread Vadim ProductEngine
> On July 25, 2011, 10:04 a.m., Boroondas Gupte wrote: > > > It's up to the translation team to remove obsolete translations. > > > > In that case, no further concerns. Should we file a jira issue to make the > > translation team aware of the obsolete eleme

[opensource-dev] Review Request: STORM-1529 Sound Devices floater is too narrow for its widgets

2011-07-26 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/418/ --- Review request for Viewer. Summary --- Made the Sound Devices floater

Re: [opensource-dev] Review Request: STORM-1529 Sound Devices floater is too narrow for its widgets

2011-07-26 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/418/ --- (Updated July 26, 2011, 2:43 p.m.) Review request for Viewer. Changes ---

[opensource-dev] Review Request: STORM-1436 [JP]"Contents" and "New Script" folder text are missing in "Content" tab for "Build" floater

2011-07-28 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/420/ --- Review request for Viewer and Richard Nelson. Summary --- Fixed broken

[opensource-dev] Review Request: STORM-1473 [VIEWER DEV] ALL LANGS Untranslated Voice Morph Names in the French viewer

2011-07-29 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/421/ --- Review request for Viewer. Summary --- Localized voice morph names.

[opensource-dev] Review Request: STORM-1194 Web browser opens clicking URL-name of object in Object Contents floater

2011-07-29 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/422/ --- Review request for Viewer. Summary --- Object Contents floater: disabl

[opensource-dev] Review Request: STORM-632 URL-like resident display name is shown as clickable HTTP URL in various places

2011-07-29 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/423/ --- Review request for Viewer. Summary --- Disallow showing URL-like avata

[opensource-dev] Review Request: STORM-1186 "no mCurrentRMessageTemplate" spam when first opening inventory

2011-08-01 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/425/ --- Review request for Viewer, Stone Linden and Richard Nelson. Summary ---

[opensource-dev] Review Request: STORM-1291 [STRING IN ENG] Gestos button. Many gestures. (part 2)

2011-08-02 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/426/ --- Review request for Viewer. Summary --- Localized common (unisex) gestu

[opensource-dev] Review Request: STORM-1309 [TEXT ELLIPTED] Text overlaying in Buy Land floater in Portuguese localization

2011-08-05 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/430/ --- Review request for Viewer. Summary --- Misc i18n fixes in the Buy Land

[opensource-dev] Review Request: STORM-1540 duplicated ID errors: floater_build_options.xml, floater_model_wizard.xml

2011-08-05 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/431/ --- Review request for Viewer and Seth ProductEngine. Summary --- Fixed nu

[opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)

2011-08-05 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/432/ --- Review request for Viewer. Summary --- Fixed a debug assertion trigger

Re: [opensource-dev] Review Request: STORM-1534: Derive Credits lists of contributors and translators from doc/ files

2011-08-07 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/427/#review955 --- Ship it! Looks plausible. indra/newview/viewer_manifest.py

<    1   2   3   >