> On June 20, 2011, 2:19 p.m., Vadim ProductEngine wrote: > > indra/newview/llfloaterlocalbitmap.h, lines 79-80 > > <http://codereview.secondlife.com/r/347/diff/1/?file=3004#file3004line79> > > > > Consider using enums instead.
Or rather typed constants. > On June 20, 2011, 2:19 p.m., Vadim ProductEngine wrote: > > indra/newview/llfloaterlocalbitmap.cpp, line 90 > > <http://codereview.secondlife.com/r/347/diff/1/?file=3005#file3005line90> > > > > No need to to use this for accessing members: this is why they have a > > distinctive naming style. I meant no need to use "this". - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/347/#review780 ----------------------------------------------------------- On June 18, 2011, 8:04 a.m., Vaalith Jinn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/347/ > ----------------------------------------------------------- > > (Updated June 18, 2011, 8:04 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Local Bitmap Browser is a mechanism to locally load images into the viewer, > track them and optionally (per each image) > have it check if the image has been overwritten locally and if so - update it > in the viewer and inworld. > > This change affects build menu by adding a way to open the floater there. > This change also affects the texture picker - adding tabs that lets the user > choose between the "Server" (regular inventory) and "Local" tabs (list of > locally added files). > > > This addresses bug STORM-64. > http://jira.secondlife.com/browse/STORM-64 > > > Diffs > ----- > > doc/contributions.txt 6a3e7e403bd1 > indra/llmath/llvolumemgr.h 6a3e7e403bd1 > indra/llmath/llvolumemgr.cpp 6a3e7e403bd1 > indra/newview/CMakeLists.txt 6a3e7e403bd1 > indra/newview/llfloaterlocalbitmap.h PRE-CREATION > indra/newview/llfloaterlocalbitmap.cpp PRE-CREATION > indra/newview/lltexturectrl.h 6a3e7e403bd1 > indra/newview/lltexturectrl.cpp 6a3e7e403bd1 > indra/newview/llviewerfloaterreg.cpp 6a3e7e403bd1 > indra/newview/llviewerobjectlist.h 6a3e7e403bd1 > indra/newview/llviewertexturelist.h 6a3e7e403bd1 > indra/newview/llvovolume.h 6a3e7e403bd1 > indra/newview/skins/default/xui/en/floater_local_bitmap.xml PRE-CREATION > indra/newview/skins/default/xui/en/floater_texture_ctrl.xml 6a3e7e403bd1 > indra/newview/skins/default/xui/en/menu_viewer.xml 6a3e7e403bd1 > > Diff: http://codereview.secondlife.com/r/347/diff > > > Testing > ------- > > Texture/Sculptmap/Avatar Layer show. > Texture/Sculptmap/Avatar Layer update. > Multiple sculpties update. > Opening multiple browser floaters works correctly. (two possible since one > can be opened from menu above, one from texture picker. all of them + texture > picker play nice.) > Tested adding over 200 images at the same time. > > > Thanks, > > Vaalith > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
