Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-02-04 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/#review331 --- Ship it! OK, did a merge and complete TC build on all platforms: n

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-02-03 Thread Aleric Inglewood
> On Jan. 31, 2011, 6:44 p.m., Merov Linden wrote: > > @Aleric: OK, you convinced me on all accounts *except* for the ease of > > merge which I want to test myself before giving my blessing to this patch. > > You wouldn't be the first one be to claim that "it merges" and create some > > issues

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-31 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/#review300 --- @Aleric: OK, you convinced me on all accounts *except* for the ease

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-21 Thread Aleric Inglewood
> On Jan. 20, 2011, 10:57 p.m., Merov Linden wrote: > > I fail to see how any of those changes "massively prevents object > > duplication". I don't disagree with any of them but I don't see much value > > in any either. Sure, there are different ways to skin a cat and some are > > better. Stil

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-21 Thread Aleric Inglewood
> On Jan. 14, 2011, 1:31 p.m., Boroondas Gupte wrote: > > indra/llcommon/lllslconstants.h, line 184 > > > > > > Yay for having type modifiers after the core type name. Makes them much > > easier to understand, especially

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-20 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/#review221 --- I fail to see how any of those changes "massively prevents object d

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-16 Thread Aleric Inglewood
> On Jan. 14, 2011, 1:31 p.m., Boroondas Gupte wrote: > > indra/llcommon/lllslconstants.h, line 184 > > > > > > Yay for having type modifiers after the core type name. Makes them much > > easier to understand, especially

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-16 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/ --- (Updated Jan. 16, 2011, 5:53 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-14 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/#review153 --- indra/llcharacter/llanimationstates.cpp

[opensource-dev] Review Request: VWR-24312: Massively duplicated objects (part 2)

2011-01-14 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/81/ --- Review request for Viewer. Summary --- Turns out that most of my SNOW-8