Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-04-09 Thread Vaalith Jinn
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/566/ --- (Updated April 9, 2012, 9:57 a.m.) Review request for Viewer, Callum Linden

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-04-09 Thread Vaalith Jinn
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/566/ --- (Updated April 9, 2012, 7:50 a.m.) Review request for Viewer, Callum Linden

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-04-03 Thread Vaalith Jinn
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/566/ --- (Updated April 3, 2012, 1:22 p.m.) Review request for Viewer, Callum Linden

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-03-31 Thread Oz Linden
> On March 29, 2012, 5:28 a.m., Vaalith Jinn wrote: > > well said, Boroondas Yes, it's clearer to use the enum, and yes an enum parameter can have a default > On March 29, 2012, 5:28 a.m., Vaalith Jinn wrote: > > indra/newview/lllocalbitmaps.h, line 42 > >

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-03-31 Thread Boroondas Gupte
> On March 29, 2012, 5:28 a.m., Vaalith Jinn wrote: > > indra/newview/lllocalbitmaps.h, line 42 > > > > > > For clarity's sake i kept private enums block below where it's > > currently at. > > > > If i were to

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-03-30 Thread Vaalith Jinn
> On March 29, 2012, 5:28 a.m., Vaalith Jinn wrote: > > indra/newview/lllocalbitmaps.h, line 42 > > > > > > For clarity's sake i kept private enums block below where it's > > currently at. > > > > If i were to

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-03-30 Thread Boroondas Gupte
> On March 29, 2012, 5:28 a.m., Vaalith Jinn wrote: > > indra/newview/lllocalbitmaps.h, line 42 > > > > > > For clarity's sake i kept private enums block below where it's > > currently at. > > > > If i were to

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-03-30 Thread Vaalith Jinn
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/566/ --- (Updated March 30, 2012, 4:06 p.m.) Review request for Viewer, Callum Linde

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-03-30 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/566/#review1201 --- indra/newview/lllocalbitmaps.cpp

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-03-29 Thread Vaalith Jinn
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/566/#review1199 --- indra/newview/lllocalbitmaps.h

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-03-29 Thread Vaalith Jinn
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/566/ --- (Updated March 29, 2012, 5:12 a.m.) Review request for Viewer, Callum Linde

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-03-28 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/566/ --- (Updated March 28, 2012, 9:59 a.m.) Review request for Viewer, Callum Linde

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-03-28 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/566/#review1197 --- A couple of things to look at, but overall very very nice looking