----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/566/#review1197 -----------------------------------------------------------
A couple of things to look at, but overall very very nice looking code. indra/newview/lllocalbitmaps.h <http://codereview.secondlife.com/r/566/#comment1113> Minor point ... it would be clearer to have the parameter be an enum whose values were first_use and texture_updated or something. Just because something only has two values doesn't make it a 'bool'. indra/newview/lllocalbitmaps.cpp <http://codereview.secondlife.com/r/566/#comment1114> Would an LL_WARN be appropriate here? indra/newview/lllocalbitmaps.cpp <http://codereview.secondlife.com/r/566/#comment1115> The cases in this switch all fall through if something unexpected happens... and there's no code to handle the unexpected. If falling through is intentional, there should be a comment saying so, and if not the break should follow the end of the (missing) else block. indra/newview/lllocalbitmaps.cpp <http://codereview.secondlife.com/r/566/#comment1116> you could shorten this loop by adding ' && add_object ' to the termination condition indra/newview/lllocalbitmaps.cpp <http://codereview.secondlife.com/r/566/#comment1117> clearer to put the assignment in the first clause of the for loop indra/newview/lllocalbitmaps.cpp <http://codereview.secondlife.com/r/566/#comment1118> I'd prefer a single 'return result;' at the bottom, replacing all those scattered ones with 'break;' because it's easier to set breakpoints on. - Oz Linden On March 23, 2012, 9:01 a.m., Vaalith Jinn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/566/ > ----------------------------------------------------------- > > (Updated March 23, 2012, 9:01 a.m.) > > > Review request for Viewer. > > > Description > ------- > > Local Bitmaps is a mechanism to locally load images into the viewer, track > them and optionally (per each image) > have it check if the image has been overwritten locally and if so - update it > in the viewer and inworld. > > This change affects the texture picker - adding radio checks that let the > user choose between the "Inventory" (regular inventory) and "Local" tabs > (list of locally added files). > > *** DO NOT USE THIS YET *** > do not implement for live viewers until fully reviewed. > > > This addresses bug STORM-64. > http://jira.secondlife.com/browse/STORM-64 > > > Diffs > ----- > > doc/contributions.txt 96a53bafcd1c > indra/newview/CMakeLists.txt 96a53bafcd1c > indra/newview/lllocalbitmaps.h PRE-CREATION > indra/newview/lllocalbitmaps.cpp PRE-CREATION > indra/newview/lltexturectrl.h 96a53bafcd1c > indra/newview/lltexturectrl.cpp 96a53bafcd1c > indra/newview/llviewertexturelist.h 96a53bafcd1c > indra/newview/llwearable.h 96a53bafcd1c > indra/newview/llwearable.cpp 96a53bafcd1c > indra/newview/skins/default/xui/en/floater_texture_ctrl.xml 96a53bafcd1c > > Diff: http://codereview.secondlife.com/r/566/diff/diff > > > Testing > ------- > > > Thanks, > > Vaalith Jinn > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
