Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-04-05 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/#review557 --- This review request is obsolete. Wolfpup, please close it. - Vadi

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Cron Stardust
> On Jan. 21, 2011, 3:44 a.m., Boroondas Gupte wrote: > > indra/newview/skins/default/xui/en/menu_bottomtray.xml, lines 11-13 > > > > > > Begin XML comments with just "", not > > "". Typically SGML/XML comments are supp

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/#review236 --- indra/newview/llbottomtray.cpp

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Opensource Obscure
It seems it works as expected on Linux after some testing (2.6.0 (219418)). The UI works fine, but I didn't use voice during the tests. I don't know if this is by design, but I'll add that: - when you disable Voice, the Speak Button correctly disappears - this doesn't happen if you disable the who

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Alexandrea Fride
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/#review235 --- Perfect just the naming in menu should be better "Speak button (en

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Boroondas Gupte
> On Jan. 21, 2011, 3:44 a.m., Boroondas Gupte wrote: > > indra/newview/llspeakbutton.cpp, lines 67-70 > > > > > > Please don't remove the single empty line between the end of one method > > and the beginning of the next

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/#review230 --- Looks like RB ate some of my comments in the review above. (Maybe

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/#review229 --- indra/newview/llbottomtray.h

[opensource-dev] Review Request: STORM-236 Actual Code Review

2011-01-20 Thread Wolfpup Lowenhar
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/ --- Review request for Viewer. Summary --- This allows the Speak Button to