Re: [opensource-dev] Review Request: STORM-1892 - Add Apply button to the edit content permission floater

jira Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1892 - Add Apply button to the edit content permission floater

/en/floater_bulk_perms.xml 4d9106153407 Diff: http://codereview.secondlife.com/r/587/diff/diff Testing --- See test plan in jira Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

to the tools floater. See https://bitbucket.org/JonathanYap/storm-468 - Jonathan Yap On March 2, 2012, 12:30 a.m., Tobias Roth wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.se

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

> On None, Tobias Roth wrote: > > Ship It! Please add the viewer version you are working from to the Branch field and STORM-468 to the Bugs field in this review request. In addition to the objections LL has posted I found two bugs when I worked on this code in January. Have both of these iss

Re: [opensource-dev] Review Request: STORM-1812 Music stream does not always restart after teleporting

have not been able to reproduce this condition recently. Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated

Re: [opensource-dev] Review Request: STORM-1738: auto-replace chat text

com/r/581/#comment1135> I think this TODO comment can now be eliminated. - Jonathan Yap On May 30, 2012, 1:25 p.m., Oz Linden wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://coderev

Re: [opensource-dev] Review Request: STORM-1812 Music stream does not always restart after teleporting

/556/diff/diff Testing --- See Test Plan in jira. During early investigation and testing of this fix there were times the play button became grayed out. I have not been able to reproduce this condition recently. Thanks, Jonathan Yap

Re: [opensource-dev] Review Request: STORM-1812 Music stream does not always restart after teleporting

recently. Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1812 Music stream does not always restart after teleporting

Testing --- See Test Plan in jira. During early investigation and testing of this fix there were times the play button became grayed out. I have not been able to reproduce this condition recently. Thanks, Jonathan Yap ___ Policies and (un

Re: [opensource-dev] Review Request: Don't save per-account settings if login not fully successful

hed, as they were not yet read in, but are being written out. This addresses bug STORM-1842. Diffs - doc/contributions.txt 0a41a8750048 indra/newview/llappviewer.h 0a41a8750048 indra/newview/llappviewer.cpp 0a41a8750048 Diff: http://codereview.secondlife.com/r/578/diff/diff Testi

Re: [opensource-dev] Review Request: STORM-1818: Fix for viewer crash when entering chars other than [a-z0-9-_. ] into the grid-selection combo.

, as you say some TPVs do, that are currently causing trouble. - Jonathan Yap On March 24, 2012, 5:33 a.m., MartinRJ Fayray wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.seco

Re: [opensource-dev] Review Request: STORM-1807 Play animation floater 2nd play button active while animation is playing

a41a8750048 indra/newview/skins/default/xui/en/floater_preview_animation.xml 0a41a8750048 Diff: http://codereview.secondlife.com/r/552/diff/diff Testing --- See test plan in jira. Thanks, Jonathan Yap ___ Policies and (un)subscribe inform

[opensource-dev] Review Request: STORM-1812 Music stream does not always restart after teleporting

able to reproduce this condition recently. Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1809 The word "Multiple" does NOT show in the edit window when editing prims or linksets with mixed textures in LL V3

09 Diffs - doc/contributions.txt 767757e005e3 indra/newview/lltexturectrl.cpp 767757e005e3 indra/newview/skins/default/xui/en/strings.xml 767757e005e3 Diff: http://codereview.secondlife.com/r/551/diff/diff Testing --- See test plan in jira. Thanks, Jo

Re: [opensource-dev] Review Request: STORM-1803 Adding raw anim file upload support

/en/floater_animation_preview.xml b91d07f8fad9 indra/newview/skins/default/xui/en/notifications.xml b91d07f8fad9 Diff: http://codereview.secondlife.com/r/546/diff/diff Testing --- See Test Plan in jira Thanks, Jonathan Yap ___ Policies and (un)subscr

Re: [opensource-dev] Review Request: STORM-1793 1) Treat all mini-map altitudes above 1020 m as the same height 2) Improve z-level accuracy

0010858de5a1 indra/newview/llworldmapview.h 0010858de5a1 indra/newview/llworldmapview.cpp 0010858de5a1 Diff: http://codereview.secondlife.com/r/545/diff/diff Testing --- See test plan in jira Thanks, Jonathan Yap ___ Policies and (un

Re: [opensource-dev] Review Request: STORM-1793 1) Treat all mini-map altitudes above 1020 m as the same height 2) Improve z-level accuracy

--- See test plan in jira Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1793 1) Treat all mini-map altitudes above 1020 m as the same height 2) Improve z-level accuracy

0010858de5a1 indra/newview/llworldmapview.cpp 0010858de5a1 Diff: http://codereview.secondlife.com/r/545/diff/diff Testing --- See test plan in jira Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http

[opensource-dev] Review Request: STORM-1803 Adding raw anim file upload support

iff Testing --- See Test Plan in jira Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1793 1) Treat all mini-map altitudes above 1020 m as the same height 2) Improve z-level accuracy

/r/545/diff/diff Testing --- See test plan in jira Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting

Re: [opensource-dev] Review Request: STORM-1804 Details... button on PERMISSION_DEBIT dialog triggers run_time_permissions() with a deny action

ttp://codereview.secondlife.com/r/544/#comment1108> Oz, here is the early return you thought might be present. Want to suggest an alternative? - Jonathan Yap On Jan. 25, 2012, 4:47 a.m., Jonathan Yap wrote: > > --- > This is an automatically g

Re: [opensource-dev] Review Request: STORM-1795 Ad-hoc messages are received even when "Only friends and groups can call or IM me"

e message This addresses bug STORM-1795. http://jira.secondlife.com/browse/STORM-1795 Diffs (updated) - doc/contributions.txt 4982ab91ef6a indra/newview/llimview.cpp 4982ab91ef6a Diff: http://codereview.secondlife.com/r/536/diff/diff Testing --- See test plan in jira Thank

Re: [opensource-dev] Review Request: STORM-1795 Ad-hoc messages are received even when "Only friends and groups can call or IM me"

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/536/#review1151 --- On Jan. 20, 2012, 11:29 a.m., Jonathan Yap wrote: > > --

Re: [opensource-dev] Review Request: STORM-1795 Ad-hoc messages are received even when "Only friends and groups can call or IM me"

ewview/llimview.cpp 4982ab91ef6a Diff: http://codereview.secondlife.com/r/536/diff/diff Testing (updated) --- See test plan in jira Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http://wiki.secondlife.co

Re: [opensource-dev] Review Request: STORM-1795 Ad-hoc messages are received even when "Only friends and groups can call or IM me"

their preferences to allow messages from everyone. You do not want to reject the session (that was handled by a different jira recently for blocked residents), only suppress messages. Thanks, Jonathan Yap ___ Policies and (un)subscribe information ava

Re: [opensource-dev] Review Request: STORM-1795 Ad-hoc messages are received even when "Only friends and groups can call or IM me"

his is correct behavior because C may change their preferences to allow messages from everyone. You do not want to reject the session (that was handled by a different jira recently for blocked residents), only suppress messages. Thanks, Jonath

Re: [opensource-dev] Review Request: STORM-1795 Ad-hoc messages are received even when "Only friends and groups can call or IM me"

m/r/536/#comment1105> I think there may be something else wrong with this logic: you do not have calls/IMs restricted and someone is your friend, this would not show the message (false AND true produce false), or am I missing something here? - Jonathan Yap On Jan. 16, 2012, 11:

[opensource-dev] Review Request: STORM-1795 Ad-hoc messages are received even when "Only friends and groups can call or IM me"

at was handled by a different jira recently for blocked residents), only suppress messages. Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before post

[opensource-dev] Review Request: STORM-1799 Object doesn't appear in Block list if trying to block from Remote object inspector

799. http://jira.secondlife.com/browse/STORM-1799 Diffs - doc/contributions.txt 4982ab91ef6a indra/newview/llinspectremoteobject.cpp 4982ab91ef6a Diff: http://codereview.secondlife.com/r/535/diff/diff Testing --- Performed steps per Description, object is blocked. Thanks,

[opensource-dev] Review Request: STORM-1793 Viewer needs to treat all mini-map altitudes above 1020 m as the same height

/llworldmapview.h 4982ab91ef6a indra/newview/llworldmapview.cpp 4982ab91ef6a indra/newview/skins/default/textures/map_avatar_unknown_32.tga 4982ab91ef6a Diff: http://codereview.secondlife.com/r/534/diff/diff Testing --- See test plan in jira Thanks, Jonathan Yap

[opensource-dev] Review Request: STORM-1798 'Block' menuitem title isn't changed after blocking item in object inspector

798. http://jira.secondlife.com/browse/STORM-1798 Diffs - indra/newview/llviewermenu.cpp 3a521e980fbf indra/newview/skins/default/xui/en/menu_inspect_object_gear.xml 3a521e980fbf Diff: http://codereview.secondlife.com/r/533/diff/diff Testing --

Re: [opensource-dev] Review Request: VWR-28087: When I upload a texture, the "preview as" dropdown in the preview window is hidden under the texture

<http://codereview.secondlife.com/r/532/#comment1102> Why are you changing this by 25 when in the other two locations you are only increasing by 20? - Jonathan Yap On Jan. 12, 2012, 12:23 a.m., Lance Corrimal wrote: > > -

[opensource-dev] Review Request: STORM-1790 Provide a Develop sub-menu to change the default logging level

the menu. Noted that logging adjusted to what the level was set to, at least for Debug (which also is All), Info, Warning, and None. I did not test Error, which probably is a bit of a moot point, as it is supposed to cause a crash. Thanks, Jonathan Yap

[opensource-dev] Review Request: STORM-1737 panel_edit_skin.xml uses confusing historical terminology

--- See test plan in jira. Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-653 As a user i would like to be able to see the available number of attachments and remaining free slots.

34d957a19aa4 indra/newview/skins/default/xui/en/panel_cof_wearables.xml 34d957a19aa4 indra/newview/skins/default/xui/en/strings.xml 34d957a19aa4 Diff: http://codereview.secondlife.com/r/527/diff/diff Testing --- See test plan in jira Thanks, Jonathan Yap

Re: [opensource-dev] Review Request: STORM-1731 Ad-hoc confererence block failing. Residents using it to start massive multi-sim conferences, used as a griefing tool.

f9a1f62ac997 Diff: http://codereview.secondlife.com/r/524/diff/diff Testing --- See test plan in jira. Testing Not Done: regression testing to see if these code changes have broken muting for other circumstances. Thanks, Jonathan Yap ___ Policies

Re: [opensource-dev] Review Request: STORM-1731 Ad-hoc confererence block failing. Residents using it to start massive multi-sim conferences, used as a griefing tool.

test, > > and then the more specific additional checks for voice in the inner check? > > > > Also, why is isLinden a special case for voice but not for other > > sessions? > > > > Jonathan Yap wrote: > Having the tests in this order is what is needed

Re: [opensource-dev] Review Request: STORM-1731 Ad-hoc confererence block failing. Residents using it to start massive multi-sim conferences, used as a griefing tool.

ink fixing these now is within the scope of this jira please let me know. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/524/#review1122 ---------

Re: [opensource-dev] Review Request: STORM-1731 Ad-hoc confererence block failing. Residents using it to start massive multi-sim conferences, used as a griefing tool.

test plan in jira. Testing Not Done: regression testing to see if these code changes have broken muting for other circumstances. Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource

[opensource-dev] Review Request: STORM-1731 Ad-hoc confererence block failing. Residents using it to start massive multi-sim conferences, used as a griefing tool.

Done: regression testing to see if these code changes have broken muting for other circumstances. Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies

Re: [opensource-dev] Review Request: STORM-1653 Group notices sent by muted residents are still displayed

systems servicing the name to ID request are heavily loaded. Thanks, Jonathan Yap ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting

Re: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

rmedia.cpp 8b455c1b7a5e indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e Diff: http://codereview.secondlife.com/r/520/diff/diff Testing --- See the massive test plan in the jira. Thanks, Jonathan Yap ___ Policies and (un)subscribe information

Re: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

ra/newview/llviewermedia.cpp 8b455c1b7a5e indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e Diff: http://codereview.secondlife.com/r/520/diff/diff Testing --- See the massive test plan in the jira. Thanks, Jonathan Yap ___ Policies and (un)subscribe i

Re: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

an else. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/520/#review1088 --- On Nov. 23, 2011, 5:59 a.m., Jona

Re: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

d back the two debug settings. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/520/#review1104 ------- On

Re: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

odereview.secondlife.com/r/520/#review1090 --- On Nov. 23, 2011, 5:59 a.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/520/ >

Re: [opensource-dev] Review Request: STORM-1653 Group notices sent by muted residents are still displayed

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/508/ --- (Updated Nov. 23, 2011, 8:05 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: STORM-1653 Group notices sent by muted residents are still displayed

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/508/ --- (Updated Nov. 23, 2011, 6:57 a.m.) Review request for Viewer. Changes ---

[opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/520/ --- Review request for Viewer. Summary --- Audio fading in has been added

Re: [opensource-dev] Review Request: Mouse pointer flickers when hovering over any active/clickable UI item

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/513/#review1073 --- indra/llui/llview.cpp

[opensource-dev] Review Request: STORM-1105 "Traffic: 0" shown for two cases (traffic actually 0, and waiting for data)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/509/ --- Review request for Viewer. Summary --- In the past, the daily computa

Re: [opensource-dev] Review Request: STORM-1653 Group notices sent by muted residents are still displayed

------ On Oct. 26, 2011, 11:09 a.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/508/ > ---

Re: [opensource-dev] Review Request: STORM-1653 Group notices sent by muted residents are still displayed

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/508/ --- (Updated Oct. 26, 2011, 11:09 a.m.) Review request for Viewer. Changes --

[opensource-dev] Review Request: STORM-1653 Group notices sent by muted residents are still displayed

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/508/ --- Review request for Viewer. Summary --- When I mute a resident, group n

Re: [opensource-dev] Review Request: VWR-27184: Hide "Library" landmark accordion when NoInventoryLibrary is set to TRUE

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/499/#review1056 --- indra/newview/skins/default/xui/en/panel_landmarks.xml

[opensource-dev] Review Request: STORM-976 Object muted by name still displays notification message when clicked

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/491/ --- Review request for Viewer. Summary --- An object muted by name still d

Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/ --- (Updated Aug. 26, 2011, 9:37 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

989#file6989line6279> > > > > I suppose these changes must be also made to the "ScriptDialog" > > notification template. Good catch! - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/#review993 --

Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/ --- (Updated Aug. 23, 2011, 1:41 p.m.) Review request for Viewer. Summary ---

Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/ --- (Updated Aug. 23, 2011, 4:07 a.m.) Review request for Viewer. Changes ---

[opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/ --- Review request for Viewer. Summary --- Add a block button to popups fr

Re: [opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/317/ --- (Updated Aug. 14, 2011, 9:07 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

> > short comment explaining the semantics of this variable. > > Jonathan Yap wrote: > Comment added. Robin Cornelius suggested using a global variable. If > you can think of a better way please let me know. > > Boroondas Gupte wrote: > A static class m

Re: [opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/317/ --- (Updated Aug. 3, 2011, 11:21 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

variable. If you can think of a better way please let me know. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/317/#review895 ---

Re: [opensource-dev] Review Request: (STORM-1221) [HARD CODED] ALL LANGS Several strings are untranslated under Group Profile Land/Assets (French viewer)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/400/#review889 --- indra/newview/lldateutil.cpp

Re: [opensource-dev] Review Request: Change pre-login viewer display URL to prepare for new community information display

> On July 16, 2011, 6:48 a.m., Thickbrick Sleaford wrote: > > indra/newview/app_settings/settings.xml, line 4875 > > > > > > Setting the default value to something other than an empty string would > > override the se

Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/ --- (Updated June 30, 2011, 1:27 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/ --- (Updated June 29, 2011, 12:14 p.m.) Review request for Viewer. Changes --

[opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/ --- Review request for Viewer. Summary --- Add a feature on the "Wearing T

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/ --- (Updated June 24, 2011, 4:45 a.m.) Review request for Viewer. Summary ---

Re: [opensource-dev] Review Request: STORM-1392 Add Nearby Voice to the Communicate menu

generated e-mail. To reply, visit: http://codereview.secondlife.com/r/346/#review771 ------- On June 18, 2011, 4:12 a.m., Jonathan Yap wrote: > > --- > This is an automa

[opensource-dev] Review Request: STORM-1392 Add Nearby Voice to the Communicate menu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/346/ --- Review request for Viewer. Summary --- Add Nearby Voice to the Communi

Re: [opensource-dev] Review Request: STORM-1320 Create a 3p-libndofdev-linux repo based on version 0.3 of Jan Ciger's linux libndofdev.

> On June 16, 2011, 4:59 p.m., Boroondas Gupte wrote: > > libndofdev/CMakeLists.txt, lines 27-30 > > > > > > Might be worth mentioning the non-linux libndofdev (and where to find > > it) in the error message. On windo

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/326/ --- (Updated June 15, 2011, 12:50 p.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/326/ --- (Updated June 15, 2011, 10:04 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

/codereview.secondlife.com/r/326/#review751 ------- On June 7, 2011, 2:32 p.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To re

[opensource-dev] Review Request: STORM-787 Mute Gestures Button

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/336/ --- Review request for Viewer. Summary --- Added a checkbox control in Pre

[opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/ --- Review request for Viewer. Summary --- This is a patch by ArminWeather

[opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/326/ --- Review request for Viewer. Summary --- 1. Launch viewer, change langua

Re: [opensource-dev] Review Request: VWR-25896 [Regression] Bulk uploads do not adhere to default permissions

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/323/#review720 ------- On June 5, 2011, 8:11 a.m., Jonathan Yap wrote: > >

Re: [opensource-dev] Review Request: VWR-25896 [Regression] Bulk uploads do not adhere to default permissions

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/323/ --- (Updated June 5, 2011, 8:11 a.m.) Review request for Viewer. Summary

[opensource-dev] Review Request: VWR-25896 [Regression] Bulk uploads do not adhere to default permissions

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/323/ --- Review request for Viewer. Summary --- Something in the big mesh branc

[opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/317/ --- Review request for Viewer. Summary --- As a Content Creator, I have to

Re: [opensource-dev] Review Request: STORM-859 : winres.h isn't present within VC++ Express includes. Must be manually copied from win7 sdk example code.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/304/#review698 --- indra/newview/skins/default/xui/en/notifications.xml

[opensource-dev] Review Request: STORM-956 Ability to mute dialogs by muting object (or object owner)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/275/ --- Review request for Viewer. Summary --- >From the jira Description: Gri

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/ --- (Updated April 16, 2011, 1:52 p.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/#review629 --- On April 16, 2011, 6:24 a.m., Jonath

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/ --- (Updated April 16, 2011, 6:24 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

on? > > It's not like we have to keep any internal state or something. > > Jonathan Yap wrote: > Moved to inside of routine. > > Boroondas Gupte wrote: > That's a good idea, too, but not what I meant. I was wondering why you > are using a class (or s

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

on? > > It's not like we have to keep any internal state or something. > > Jonathan Yap wrote: > Moved to inside of routine. > > Boroondas Gupte wrote: > That's a good idea, too, but not what I meant. I was wondering why you > are using a class (or s

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

//codereview.secondlife.com/r/262/#review595 --- On April 15, 2011, 11:33 a.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To r

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

inside the "for" clause to limit its > > scope. Changed. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/#review598 --------

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/ --- (Updated April 15, 2011, 11:33 a.m.) Review request for Viewer. Changes -

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llbottomtray.cpp, lines 560-561 > > <http://codereview.secondlife.com/r/244/diff/3/?file=1450#file1450line560> > > > > Any reason not to move this to LLNearbyChatBar::post

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

om/r/244/#review596 ------- On April 13, 2011, 12:32 p.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondli

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

; > > CS: extra spaces near parenthesis Done. - Jonathan ------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review591 ---

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/ --- (Updated April 13, 2011, 12:32 p.m.) Review request for Viewer. Changes -

[opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/ --- Review request for Viewer. Summary --- The results of using the World

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

nt when the MM sent this back. - Jonathan --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review589 --- On April 13, 2011, 6:40 a.m.

  1   2   >