----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/544/#review1157 -----------------------------------------------------------
indra/newview/llviewermessage.cpp <http://codereview.secondlife.com/r/544/#comment1108> Oz, here is the early return you thought might be present. Want to suggest an alternative? - Jonathan Yap On Jan. 25, 2012, 4:47 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/544/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2012, 4:47 a.m.) > > > Review request for Viewer. > > > Description > ------- > > When an object requests DEBIT permissions a large, yellow dialog appears. > This dialog has three buttons: "Grant", "Deny", and "Details..." When you > select "Details..." Additional information about DEBIT permission is > displayed. > > The bug is that when "Details..." is selected PERMISSION_DEBIT is denied and > the run_time_permissions() event handler is triggered. There is also a system > message in the Local Chat pane of the communicate window that informs the > user that permission has been denied. Further, if "Grant" or "Deny" are > pressed AFTER details the run_time_permissions() event handler is NOT > triggered, yet there is a system message saying that permissions have been > granted or denied. > > What should happen when "Details..." is pressed is no run_time_permissions > event should be triggered and the "Grant" and "Deny" buttons should operate > normally and trigger the run_time_permissions event afterwards. > > > This addresses bug STORM-1804. > http://jira.secondlife.com/browse/STORM-1804 > > > Diffs > ----- > > doc/contributions.txt 3f2162768b29 > indra/newview/llviewermessage.cpp 3f2162768b29 > > Diff: http://codereview.secondlife.com/r/544/diff/diff > > > Testing > ------- > > See test script in jira. > > Click on Details: additional information is shown, click on Ok to dismiss > that, then you can go back and click on Grant or Deny. > > > Thanks, > > Jonathan Yap > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
