[opensource-dev] Review Request: Fixed snapping of rotation in the edge-on case

t been modified in either viewer since ancient times and should therefore cause no ill effects. Thanks, Cron Stardust ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies befo

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

Damn. SL's text editing windows do not like tabs. When copy/pasting the > tabs are converted to spaces, but not when inserting text. I'll look at > finding a way around this. > > Kadah Coba wrote: > I don't remember any in-viewer text input ever liking \t parti

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

> On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote: > > found another glitch: > > I'm developing scripts in eclipse with lslforge. When I "compile" a script > > in eclipse and then load it using this patch, tabstops are converted into > > IDunnoWhat (it shows as little squares in the script ed

Re: [opensource-dev] Review Request: storm-1663: widen pitch clamping on camera, make it the same for sitting

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/504/#review1060 --- Ship it! Looks good to me. The only issue I can see is commenti

Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

> On June 30, 2011, 11:02 a.m., Vadim ProductEngine wrote: > > indra/newview/llpanelwearing.cpp, lines 297-302 > > > > > > Looks a bit confusing. > > Lance Corrimal wrote: > but it's elegant! Just needs some pare

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

> On April 4, 2011, 4:39 p.m., Cron Stardust wrote: > > Huh.. long winded speech became dust on pressing publish... Here goes again: - Cron --- This is an automatically generated e-mail. To reply, vi

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/#review546 --- - Cron On April 4, 2011, 10:34 a.m., Cron Stardust wrote

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

parallel review of my own, let me know what you think. - Cron --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/#review544

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/ --- (Updated April 4, 2011, 10:34 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

ross lines to put the operator at the beginning of the second > line instead of the end of the first line: > > (dist_vec_squared(LLVector3(ki_prev->mPos), first_frame_pos) > > (POSITION_MOTION_THRESHOLD*POSITION_MOTION_THRESHOLD)) > > > Cron Stardust wrote: >

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

> On March 17, 2011, 4:50 a.m., Vadim ProductEngine wrote: > > indra/newview/llnetmap.cpp, lines 473-474 > > > > > > Please move these numbers to settings. Those two should be CHAT_NORMAL_RADIUS and CHAT_SHOUT_RADIUS

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

se, where intermediary variables help readability or > > understandability, we should prefer them, but I don't think that's the case > > here. > > Boroondas Gupte wrote: > [...] if this mainly occurs *at* comparisons [...] Good thoughts, however I think

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/ --- (Updated March 12, 2011, 11:54 p.m.) Review request for Viewer. Changes -

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

n --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/#review448 --- On March 12, 2011, 6:33 a.m., Cron Stardust wrote: >

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

e you're touching it anyway, fix it QSL: I'm on it! :D - Cron --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/#review444 --

[opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/ --- Review request for Viewer. Summary --- I looking at the code, trying t

[opensource-dev] Review Request: Corrected a call to the Mac-specific command "Rez" that had the wrong case.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/196/ --- Review request for Viewer. Summary --- Simple change from a lower-case

Re: [opensource-dev] Review Request: storm-1038: crash in texture cache pruning

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/172/#review413 --- As Thickbrick just noted on OSDev, this looks to be practically id

Re: [opensource-dev] Review Request: storm-1038: crash in texture cache pruning

> On None, Oz Linden wrote: > > indra/newview/lltexturecache.cpp, line 1439 > > > > > > This was the crash - note that it is exactly the same condition that > > would normally get you out of the loop above. > > Any

Re: [opensource-dev] Review Request: STORM-236 Actual Code Review

> On Jan. 21, 2011, 3:44 a.m., Boroondas Gupte wrote: > > indra/newview/skins/default/xui/en/menu_bottomtray.xml, lines 11-13 > > > > > > Begin XML comments with just "", not > > "". Typically SGML/XML comments are supp

Re: [opensource-dev] Review Request: Help Needed to debug small problem with code for STORM-236.

> On Jan. 20, 2011, 10:45 a.m., Cron Stardust wrote: > > Looks like you are only preventing the button from drawing and working, but > > not actually /removing/ it from the tray. Have you hunted down the code > > that is used to remove tray buttons when the tray is

Re: [opensource-dev] Review Request: Help Needed to debug small problem with code for STORM-236.

> On Jan. 20, 2011, 10:45 a.m., Cron Stardust wrote: > > Looks like you are only preventing the button from drawing and working, but > > not actually /removing/ it from the tray. Have you hunted down the code > > that is used to remove tray buttons when the tray is

Re: [opensource-dev] Review Request: Help Needed to debug small problem with code for STORM-236.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/#review210 --- Looks like you are only preventing the button from drawing and wor

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/90/#review204 --- Ship it! Thanks for the clarification! Looks good to me. - Cron

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

> On Jan. 18, 2011, 12:09 p.m., Merov Linden wrote: > > indra/newview/lltexturecache.cpp, line 1595 > > > > > > validate_idx being used in a test later, it's not just for > > (validate_idx == 0) that the behavior will b

Re: [opensource-dev] Review Request: STORM-34 As a User, I want a list of my favorite locations available on the login screen so i can log in to SL right where I want to be.

> On 2010-12-06 08:33:21, Seth ProductEngine wrote: > > Looks good for a first version of the task implementation, considering the > > issues mentioned in the description. Agreed. The code looks clean. (As expected from the pro's! :D ) Thought I had found a style issue, but double checked th

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

> On 2010-12-01 21:26:12, Cron Stardust wrote: > > Based on the logic of the removed break, line 1192 of the fixed file: > > idleTimer.getElapsedTimeF64() >= max_idle_time > > should be > > idleTimer.getElapsedTimeF64() < max_idle_time > > > > The

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/2/#review4 --- Based on the logic of the removed break, line 1192 of the fixed file: