Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-06-21 Thread Boroondas Gupte
> On June 21, 2011, 6:56 a.m., Aleric Inglewood wrote: > > indra/llvfs/lldiriterator.cpp, line 123 > > > > > > What is your reasoning to use native() here and not string()? > > Boroondas Gupte wrote: > I tried to

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-06-21 Thread Aleric Inglewood
> On June 21, 2011, 6:56 a.m., Aleric Inglewood wrote: > > indra/llvfs/lldiriterator.cpp, line 123 > > > > > > What is your reasoning to use native() here and not string()? > > Boroondas Gupte wrote: > I tried to

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-06-21 Thread Aleric Inglewood
> On June 21, 2011, 6:56 a.m., Aleric Inglewood wrote: > > indra/llvfs/lldiriterator.cpp, line 123 > > > > > > What is your reasoning to use native() here and not string()? > > Boroondas Gupte wrote: > I tried to

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-21 Thread Seth ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/357/#review803 --- Ship it! The glob to regex conversion was not initially supposed

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-21 Thread Vadim ProductEngine
> On June 20, 2011, 9:49 a.m., Vadim ProductEngine wrote: > > indra/newview/llvoicevivox.cpp, line 557 > > > > > > Inconsistent spacing around "if" conditions. > > > > Please use "if (cond)" with no extra or m

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-21 Thread Seth ProductEngine
> On June 21, 2011, 7:57 a.m., Alain Linden wrote: > > indra/llvfs/tests/lldiriterator_test.cpp, line 46 > > > > > > Personally, I dislike referencing jira items in code comments. Its > > referencing something ephemer

Re: [opensource-dev] Review Request: Check for null ptr to hopefully prevent crash in LLToolPie

2011-06-21 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/359/#review800 --- Ship it! The check certainly will not hurt. - Vadim On June 21

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-21 Thread ArminWeatherHax Resident
> On June 20, 2011, 9:49 a.m., Vadim ProductEngine wrote: > > indra/newview/llvoicevivox.cpp, lines 4485-4488 > > > > > > What if region caps never arrive? > > The string may grow infinitely. > > > > Also

[opensource-dev] Review Request: Check for null ptr to hopefully prevent crash in LLToolPie

2011-06-21 Thread Alain Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/359/ --- Review request for Viewer, Oz Linden and Vadim ProductEngine. Summary -

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-21 Thread Alain Linden
> On June 21, 2011, 7:57 a.m., Alain Linden wrote: > > indra/llvfs/tests/lldiriterator_test.cpp, line 46 > > > > > > Personally, I dislike referencing jira items in code comments. Its > > referencing something ephemer

Re: [opensource-dev] Review Request: VWR-25965 LLDirIterator fixes in the viewer cache migration and VFS fallback.

2011-06-21 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/324/ --- (Updated June 21, 2011, 8:33 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-21 Thread Vadim ProductEngine
> On June 20, 2011, 9:49 a.m., Vadim ProductEngine wrote: > > indra/newview/llvoicevivox.cpp, lines 4485-4488 > > > > > > What if region caps never arrive? > > The string may grow infinitely. > > > > Also

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-21 Thread Boroondas Gupte
> On June 21, 2011, 7:57 a.m., Alain Linden wrote: > > indra/llvfs/tests/lldiriterator_test.cpp, line 46 > > > > > > Personally, I dislike referencing jira items in code comments. Its > > referencing something ephemer

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-21 Thread Alain Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/357/#review795 --- Ship it! indra/llvfs/tests/lldiriterator_test.cpp

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-06-21 Thread Boroondas Gupte
> On June 21, 2011, 6:56 a.m., Aleric Inglewood wrote: > > indra/llvfs/lldiriterator.cpp, line 123 > > > > > > What is your reasoning to use native() here and not string()? I tried to stick to a 1:1 replacement. The o

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-06-21 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/313/#review793 --- indra/llvfs/lldiriterator.cpp

Re: [opensource-dev] Review Request: Local Bitmap Browser implementation.

2011-06-21 Thread Vadim ProductEngine
> On June 20, 2011, 2:19 p.m., Vadim ProductEngine wrote: > > indra/newview/llfloaterlocalbitmap.h, lines 79-80 > > > > > > Consider using enums instead. Or rather typed constants. > On June 20, 2011, 2:19 p.m., Vadi

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-06-21 Thread Francesco "Sythos"
Well... I'm sorry but for me is quite hard remember what i've done yesterday... Got focus about what i've done 1 month ago is impissible... If i recall correctly i've already used this patch in KV, i can check deeper asap @ home this evening -- Sent by iPhone Il giorno 21/giu/2011, alle ore 12:

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-06-21 Thread Boroondas Gupte
> On May 25, 2011, 2:55 p.m., Altair Memo wrote: > > work fine with both 1.45 from 3p-libs both custom 1.46 prebuilt libs > > (non-standalone) Have you actually reviewed the code change or just tested the result? - Boroondas --- This i

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-21 Thread ArminWeatherHax Resident
> On June 20, 2011, 9:49 a.m., Vadim ProductEngine wrote: > > indra/newview/llvoicevivox.cpp, lines 4485-4488 > > > > > > What if region caps never arrive? > > The string may grow infinitely. > > > > Also

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-21 Thread ArminWeatherHax Resident
> On June 9, 2011, 1:48 p.m., Altair Memo wrote: > > indra/newview/llvoicevivox.cpp, line 785 > > > > > > not sure is a nice choice remove the warn, a resident lose the only way > > to know if all work fine I'll add

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/357/#review788 --- doc/contributions.txt