Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

2010-12-01 Thread Cron Stardust
> On 2010-12-01 21:26:12, Cron Stardust wrote: > > Based on the logic of the removed break, line 1192 of the fixed file: > > idleTimer.getElapsedTimeF64() >= max_idle_time > > should be > > idleTimer.getElapsedTimeF64() < max_idle_time > > > > The variable "S32 pending;" is redeclared on line

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

2010-12-01 Thread Wolfpup Lowenhar
> On 2010-12-01 21:26:12, Cron Stardust wrote: > > Based on the logic of the removed break, line 1192 of the fixed file: > > idleTimer.getElapsedTimeF64() >= max_idle_time > > should be > > idleTimer.getElapsedTimeF64() < max_idle_time > > > > The variable "S32 pending;" is redeclared on line

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

2010-12-01 Thread Cron Stardust
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/2/#review4 --- Based on the logic of the removed break, line 1192 of the fixed file:

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

2010-12-01 Thread zidonuke
> On 2010-12-01 20:54:32, Wolfpup Lowenhar wrote: > > testing new review system. > > > > code looks clean to me Heh, commenting on his comment seems to work. - Zidonuke --- This is an automatically generated e-mail. To reply, visit: ht

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

2010-12-01 Thread Wolfpup Lowenhar
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/2/#review1 --- Ship it! testing new review system. code looks clean to me - Wolfpu

Re: [opensource-dev] Autoupdater Flashback

2010-12-01 Thread Oz Linden (Scott Lawrence)
> Is there any chance we can get a build that doesn't serve AutoUpdater > Errors when you launch the app, or is that all server side? > That set of problems is the subject of quite a lot of attention. ___ Policies and (un)subscribe information available

[opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

2010-12-01 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/2/ --- Review request for Viewer. Summary --- This review is mostly a first tes

Re: [opensource-dev] Autoupdater Flashback

2010-12-01 Thread Trilo Byte
Is there any chance we can get a build that doesn't serve AutoUpdater Errors when you launch the app, or is that all server side? TriloByte Zanzibar On Nov 30, 2010, at 1:34 PM, Brad Kittenbrink (Brad Linden) wrote: > Oops, thanks for the heads-up. > > The background updater is new in viewer 2

[opensource-dev] Daily Scrum Summary - Wednesday, December 1

2010-12-01 Thread Anya Kanevsky
Wednesday, December 1, 2010 General Notes -- - FEEL BETTER ESBE! - Merge Monkey of the Day: Oz - IMPORTANT: When reopening issues from prior sprints, please move into unscheduled (remove Sprint X) and comment that it was reopnened. Reopnened current

Re: [opensource-dev] Autoupdater Flashback

2010-12-01 Thread Kitty
Would it be possible to get the protocol specification for the updater service on the server-side? It's always possible to work backwards from the code in the viewer, but it would be handy to just have an overview of the viewer<->web service exchanges :). Kitty From: opensource-dev-boun

[opensource-dev] Comments wanted - (Un)docking sidebar tabs/sidebar opens closes

2010-12-01 Thread Jonathan Welch
Good morning-- Have you been using those new tear off sidebar tabs? I have, and when I redock one I find it disturbing that the sidebar leaps out and then has to be manually closed. The converse of this is when the sidebar is open and you tear off a tab and the sidebar closes. Here is a jira on