Re: [Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-02-02 Thread David Brownell
On Tuesday 26 January 2010, Nicolas Pitre wrote: > > > Also I don't like the fact that the introduced arm_semi_hosting structure > > > (which could have been done in a patch of its own btw) is carrying fields > > > that are valid only for one particular instance of a semihosting call and > > > ther

Re: [Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-01-26 Thread Nicolas Pitre
On Wed, 27 Jan 2010, Spencer Oliver wrote: > > When do_semihosting() returns with an error, the caller should return right > > away with 1 as the original code did and not 0 like the patch does. > > > > I am confused as the code in git master is: > if ((*retval = do_semihosting(target, &arm->sem

Re: [Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-01-26 Thread Nicolas Pitre
On Tue, 26 Jan 2010, David Brownell wrote: > On Tuesday 26 January 2010, Nicolas Pitre wrote: > > Finally the fix for FLEN could be split in a patch of its own too as > > this is clearly an orthogonal issue. > > If you agree this is a bug, then it should get fixed > before the 0.4 code freezes .

Re: [Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-01-26 Thread Spencer Oliver
> > When do_semihosting() returns with an error, the caller should return > right away with 1 as the original code did and not 0 like the patch > does. > I am confused as the code in git master is: if ((*retval = do_semihosting(target, &arm->semi_hosting_info)) != ERROR_OK) return 0;

Re: [Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-01-26 Thread David Brownell
On Tuesday 26 January 2010, Nicolas Pitre wrote: > I don't like the fact that the introduced arm_semi_hosting > structure (which could have been done in a patch of its own btw) is > carrying fields that are valid only for one particular instance of a > semihosting call and therefore should have

Re: [Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-01-26 Thread David Brownell
On Tuesday 26 January 2010, Nicolas Pitre wrote: > Finally the fix for FLEN could be split in a patch of its own too as > this is clearly an orthogonal issue. If you agree this is a bug, then it should get fixed before the 0.4 code freezes ... I'm glad to see a bit more testing of the semihos

Re: [Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-01-26 Thread Nicolas Pitre
On Tue, 26 Jan 2010, David Brownell wrote: > On Tuesday 26 January 2010, Nicolas Pitre wrote: > > > > > > For the record:  I did get that working with an ARM9, no > > > > changes, using the latest CodeSourcery EABI toolchain. > > > > > > > > > > strange, i tested on arm9 aswell. > > > fileio was

Re: [Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-01-26 Thread Spencer Oliver
David Brownell wrote: > On Tuesday 26 January 2010, Nicolas Pitre wrote: For the record: I did get that working with an ARM9, no changes, using the latest CodeSourcery EABI toolchain. >>> strange, i tested on arm9 aswell. >>> fileio was ok, just printf to stdout/stderr failed. >> It

Re: [Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-01-26 Thread Nicolas Pitre
On Tue, 26 Jan 2010, Spencer Oliver wrote: > David Brownell wrote: > > On Tuesday 26 January 2010, Spencer Oliver wrote: > >> I could not get the original implementation from Nicolas Pitr working > >> when outputting to stdout. > > > > For the record: I did get that working with an ARM9, no > >

Re: [Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-01-26 Thread David Brownell
On Tuesday 26 January 2010, Nicolas Pitre wrote: > > > > For the record:  I did get that working with an ARM9, no > > > changes, using the latest CodeSourcery EABI toolchain. > > > > > > > strange, i tested on arm9 aswell. > > fileio was ok, just printf to stdout/stderr failed. > > It is used in

Re: [Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-01-26 Thread Spencer Oliver
David Brownell wrote: > On Tuesday 26 January 2010, Spencer Oliver wrote: >> patch attached. > > ... another preview for the 0.5 series. :) > > got a few patches waiting :) ___ Openocd-development mailing list Openocd-development@lists.berlios.de htt

Re: [Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-01-26 Thread Spencer Oliver
David Brownell wrote: > On Tuesday 26 January 2010, Spencer Oliver wrote: >> I could not get the original implementation from Nicolas Pitr working >> when outputting to stdout. > > For the record: I did get that working with an ARM9, no > changes, using the latest CodeSourcery EABI toolchain. >

Re: [Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-01-26 Thread David Brownell
On Tuesday 26 January 2010, Spencer Oliver wrote: > patch attached. ... another preview for the 0.5 series. :) ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-01-26 Thread David Brownell
On Tuesday 26 January 2010, Spencer Oliver wrote: > I could not get the original implementation from Nicolas Pitr working > when outputting to stdout. For the record: I did get that working with an ARM9, no changes, using the latest CodeSourcery EABI toolchain. The only moderately surprising be

[Openocd-development] [PATCH 1/2] ARM semihosting: add armv7m support

2010-01-26 Thread Spencer Oliver
patch attached. I could not get the original implementation from Nicolas Pitr working when outputting to stdout. The issue i had was with the SYS_FLEN call - it has now been change to use fstat and printf works with codesourcery semihosting libs as expected. Cheers Spen >From 7703ede2589941