[Openocd-development] Jenkins changes

2011-10-21 Thread Øyvind Harboe
I'd like to drive the OpenOCD code towards zero scan-build (clang static analysis) warnings and I'd very much appreciate patches to that effect! I've added a scan-build (clang static analysis) that is run when a patch is submitted (openocd-gerrit). If scan-build fails, then the patch is still ma

[Openocd-development] New patch to review for openocd: 0b0da27 warning: fix false positive

2011-10-21 Thread Gerrit
This is an automated email from Gerrit. ?yvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/49 -- gerrit commit 0b0da279276e47b49f002374735e0570544cf32b Author: Øyvind Harboe Date: Sat Oct 22 08:25:00 2011 +0200

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread Øyvind Harboe
> I have to agree with you here. Make things work first, nice to have but > not essential things can come later. It's a policy to reduce the # of unnecessary changes to OpenOCD. The # of willy-nilly changes in itself drives the quality down. We don't understand this problem yet, so we're likely t

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread Xiaofan Chen
On Sat, Oct 22, 2011 at 1:52 AM, Freddie Chopin wrote: > Why can't we revert a change, fixing a bug and wait for a real jimtcl-expert > (Steve) to discuss other alternatives while in the meantime OpenOCD would > work as expected for Windows users? > > "The problem" is that Windows paths now cannot

Re: [Openocd-development] Amontec - Out of business?

2011-10-21 Thread Peter Stuge
Hi Ananda, Ananda Regmi wrote: > Does anybody here know if Amontec - makers of JTAG Tiny - company > went out of business or something? I guess it's possible, but company owner Laurent posted to this very mailing list a week or so ago. > Here's the reason I asked. I bought a JTAG tiny from them

[Openocd-development] New patch to review for openocd: d42e353 mx2: add error propagation and remove warnings

2011-10-21 Thread Gerrit
This is an automated email from Gerrit. ?yvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/48 -- gerrit commit d42e3535a11b2ce1dc705e9a5a273c9f75f1829a Author: Øyvind Harboe Date: Sat Oct 22 01:11:58 2011 +0200

[Openocd-development] New patch to review for openocd: 22d28c0 kinetis: fix warning about malloc(0) w/assert

2011-10-21 Thread Gerrit
This is an automated email from Gerrit. ?yvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/47 -- gerrit commit 22d28c08fc5f0d8ef9a87dd5c9588a6e027b54b0 Author: Øyvind Harboe Date: Sat Oct 22 01:09:32 2011 +0200

[Openocd-development] New patch to review for openocd: f6522f3 fm3: fix warning for superfluous assignment

2011-10-21 Thread Gerrit
This is an automated email from Gerrit. ?yvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/46 -- gerrit commit f6522f3799e861bb06eec8aae41e27892fbbce13 Author: Øyvind Harboe Date: Sat Oct 22 01:08:16 2011 +0200

[Openocd-development] New patch to review for openocd: d1857ad tms470: remove dead assignment warning

2011-10-21 Thread Gerrit
This is an automated email from Gerrit. ?yvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/45 -- gerrit commit d1857ad1f392b5e700d9d977ab65d827204f6957 Author: Øyvind Harboe Date: Sat Oct 22 01:06:26 2011 +0200

[Openocd-development] New patch to review for openocd: 19fcc78 server: remove warning due to dead assignment

2011-10-21 Thread Gerrit
This is an automated email from Gerrit. ?yvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/44 -- gerrit commit 19fcc78a930eb6e1d1c60cf1df4aa7fc2f1271fb Author: Øyvind Harboe Date: Sat Oct 22 01:04:27 2011 +0200

[Openocd-development] New patch to review for openocd: 2f7714a buspirate: ignore return value and fix warning

2011-10-21 Thread Gerrit
This is an automated email from Gerrit. ?yvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/43 -- gerrit commit 2f7714a90cdb829a7a5d4f7596b189728ba0ac8d Author: Øyvind Harboe Date: Sat Oct 22 00:40:51 2011 +0200

[Openocd-development] Amontec - Out of business?

2011-10-21 Thread Ananda Regmi
Hello, Does anybody here know if Amontec - makers of JTAG Tiny - company went out of business or something? I know, this is an off topic question. But I have exhausted all my options before posting it here. Since, Amontec's SDK kit supports OpenOCD, I figured some of you might know their status.

Re: [Openocd-development] commit a62d8f22 causes double evaluation of $filename in src/helper/startup.tcl proc script

2011-10-21 Thread Øyvind Harboe
Hi Freddie, as a policy we wait for all information that we expect to arrive on a bug so that we can hopefully fix the problem once and for all. This is slower, but ultimately means higher quality because we make more informed changes to OpenOCD. It isn't going to make a difference if we wait for

Re: [Openocd-development] commit a62d8f22 causes double evaluation of $filename in src/helper/startup.tcl proc script

2011-10-21 Thread Freddie Chopin
On 2011-10-21 20:13, Peter Stuge wrote: Meanwhile, the workaround is quite trivial. Yeah, right... Tell that to thousands of OpenOCD users who do NOT build their binary. How can they change startup.tcl when it's hardcoded into openocd.exe? I'm more interested in knowing if not using upleve

Re: [Openocd-development] commit a62d8f22 causes double evaluation of $filename in src/helper/startup.tcl proc script

2011-10-21 Thread Peter Stuge
Freddie Chopin wrote: >> But I disagree with reverting the commit. Fix the problem instead. > > What? > > So you don't know how to fix that, I don't know how to fix that, but > we cannot revert a one-line change that introduced A BUG just > because it (supposedly - I did not check) adds some functi

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread Freddie Chopin
On 2011-10-21 19:39, Peter Stuge wrote: Not so easy. I disagree with reverting the patch without having a clear plan for the real fix. Not easy because it is not neccessarily possible to implement the same functionality in any other way. The proper solution requries Jim expertise which I have n

Re: [Openocd-development] clang static analyzer

2011-10-21 Thread Peter Stuge
Øyvind Harboe wrote: > I upgraded to Ubuntu 11.10 from Ubuntu 11.04 and now it works :-) > > Looks like this is bleeding edge stuff... Not really, it is more likely just not something that Canonical cares so much about. //Peter ___ Openocd-development

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread Peter Stuge
Freddie Chopin wrote: > Just as Peter suspected the problem is caused by commit > a62d8f2271312ba955e839509590f5a5975b1b49. I've verified that with > bisecting. I've also build version with that single commit reverted > which worked as expected and as before. Thanks for confirming that! > I've

Re: [Openocd-development] New patch to review for openocd: 7067428 Revert "Evaluate 'script' in the global scope"

2011-10-21 Thread Freddie Chopin
On 2011-10-21 19:09, Øyvind Harboe (Code Review) wrote: > Please look up the discussion of why this code was modified to use > uplevel and amend the commit with an explanation of why we should use > the proposed behaviour instead. I cannot comment on Gerrit... The discussion - https://lists.ber

[Openocd-development] New patch to review for openocd: d5d891e clang: fix warning w/assert so that clang knows that there will be no division by zero

2011-10-21 Thread Gerrit
This is an automated email from Gerrit. Øyvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/42 -- gerrit commit d5d891eaeff5c4484b2858e90ece1f2ce312c097 Author: Øyvind Harboe Date: Fri Oct 21 19:14:57 2011 +0200

[Openocd-development] New patch to review for openocd: 7405d98 clang: fix malloc() warning with assert

2011-10-21 Thread Gerrit
This is an automated email from Gerrit. Øyvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/41 -- gerrit commit 7405d985b1957c6dfbde3cdf5842bfad914f2873 Author: Øyvind Harboe Date: Fri Oct 21 19:00:09 2011 +0200

Re: [Openocd-development] clang static analyzer

2011-10-21 Thread Øyvind Harboe
I upgraded to Ubuntu 11.10 from Ubuntu 11.04 and now it works :-) Looks like this is bleeding edge stuff... -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread Freddie Chopin
Just as Peter suspected the problem is caused by commit a62d8f2271312ba955e839509590f5a5975b1b49. I've verified that with bisecting. I've also build version with that single commit reverted which worked as expected and as before. I've pushed revert-patch for Gerrit review. I believe it should

[Openocd-development] New patch to review for openocd: 7067428 Revert "Evaluate 'script' in the global scope"

2011-10-21 Thread Gerrit
This is an automated email from Gerrit. Freddie Chopin (freddie.cho...@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/40 -- gerrit commit 70674284abe1e4106f5b06829a9f8f2f000a3977 Author: Freddie Chopin Date: Fri Oct 21 18:20:17 2011 +0200

Re: [Openocd-development] clang static analyzer

2011-10-21 Thread Marti Bolivar
On 10/21/2011 10:40 AM, Øyvind Harboe wrote: Where does the output go? It should go in a directory named scan-build--MM-DD-n/, where n starts from 1. If I recall correctly, that directory ended up in the directory I ran scan-build from. scan-build ./configure --enable-maintainer-mod

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread Peter Stuge
Xiaofan Chen wrote: > The following does work now. > C:\work\openocd\binary>openocd -f board\\ek-lm3s1968.cfg -f has not changed in almost 5 years, and directly calls the script procedure, which was changed by Steve's commit. So maybe both things are caused by the commit after all. There's actua

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread Xiaofan Chen
On Fri, Oct 21, 2011 at 11:37 PM, Xiaofan Chen wrote: > On Fri, Oct 21, 2011 at 11:06 PM, Peter Stuge wrote: >> So there are two differences in behavior versus 0.5: >> >> 1. \ in -f parameters get evaluated one time extra by Jim tcl >> 2. paths in -f parameters are now relative to a different dir

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread Xiaofan Chen
On Fri, Oct 21, 2011 at 11:06 PM, Peter Stuge wrote: > So there are two differences in behavior versus 0.5: > > 1. \ in -f parameters get evaluated one time extra by Jim tcl > 2. paths in -f parameters are now relative to a different directory, >   one level down from previously > > 2. is most lik

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread Peter Stuge
Peter Stuge wrote: > > C:\work\openocd\binary\bin>openocd.exe -f board//ek-lm3s1968.cfg > > Open On-Chip Debugger 0.6.0-dev-snapshot (2011-10-21-21:26) > > Licensed under GNU GPL v2 > > For bug reports, read > > http://openocd.sourceforge.net/doc/doxygen/bugs.html > > Runtime Error: embedde

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread Peter Stuge
Xiaofan Chen wrote: > For version 0.5.0, the following two commands work and I use only > either of them. > openocd.exe -f board\ek-lm3s1968.cfg > openocd.exe -f board/ek-lm3s1968.cfg > > For latest git, none of the following commands work. > openocd.exe -f board\ek-lm3s1968.cfg > openocd.exe -f b

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread Xiaofan Chen
On Fri, Oct 21, 2011 at 7:06 PM, Spencer Oliver wrote: > On 20 October 2011 17:04, Freddie Chopin wrote: >> The only working version that I've found is: >>> openocd -f ../interface/jtagkey.cfg -f ../target/stm32.cfg >> > > i cannot reproduce this problem, any more details. > I can reproduce the

Re: [Openocd-development] clang static analyzer

2011-10-21 Thread Øyvind Harboe
Hmm It doesn't work here. Any tips? Where does the output go? scan-build ./configure --enable-maintainer-mode --enable-dummy --disable-werror scan-build make ... make[2]: Leaving directory `/home/oyvind/openocd' make[1]: Leaving directory `/home/oyvind/openocd' scan-build: Removing directory

Re: [Openocd-development] Gerrit background

2011-10-21 Thread Peter Stuge
Xiaofan Chen wrote: > >> "+1 Looks good to me, but someone else must approve > >> 0 No score > >> -1 I would prefer that you didn't submit this" > >> > >> If the contributor see a -1 and refer to the above, > >> I do not think it is that encouraging. :-). Do you already consider that "submit" is t

Re: [Openocd-development] Change in openocd[master]: jlink libusb1 driver with libusb1 common driver interface.

2011-10-21 Thread Peter Stuge
Mauro Gamba wrote: > I think to proceed in this way: > > - Add to the configuration step the possibility to choose which usb > library to use. Use pkg-config to check for all libraries that can work, and use with the first one that is found. Check for libusb-1.0 first. You will need to study mo

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread freddie_chopin
W dniu 2011-10-21 13:50:26 użytkownik Spencer Oliver napisał: > you could either do a git bisect to see what version it broke at. Will bisecting also affect jimtcl version used as a submodule or maybe always the most recent one is used? Generally I see some changes that could affect path handl

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread Spencer Oliver
On 21 October 2011 12:40, freddie_chopin wrote: > W dniu 2011-10-21 13:06:05 użytkownik Spencer Oliver > napisał: >> i cannot reproduce this problem, any more details. > > We'll... I've compiled master from yesterday, using the same tools and > libraries (libusb and libftdi) as before, using th

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread freddie_chopin
W dniu 2011-10-21 13:06:05 użytkownik Spencer Oliver napisał: > i cannot reproduce this problem, any more details. We'll... I've compiled master from yesterday, using the same tools and libraries (libusb and libftdi) as before, using the same script as before - generally nothing changed from m

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread Spencer Oliver
On 20 October 2011 17:04, Freddie Chopin wrote: > Hi! > > The most recent OpenOCD behaves differently on Windows than 0.5.0 (and > before) and in my opinion the direction of change is to worse. > > OpenOCD 0.5.0 could be run this way: >> openocd -f interface/jtagkey.cfg -f target/stm32.cfg > And i

[Openocd-development] New patch to review for openocd: 48bbfa4 jim: add missing jim license

2011-10-21 Thread Gerrit
This is an automated email from Gerrit. Spencer Oliver (s...@spen-soft.co.uk) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/39 -- gerrit commit 48bbfa4ea38ad0acbc64a52c40619f8dba29a9c7 Author: Spencer Oliver Date: Fri Oct 21 09:51:21 2011 +0100 j

Re: [Openocd-development] commit - jim-nvp is moving from jimtcl to openocd

2011-10-21 Thread Øyvind Harboe
On Fri, Oct 21, 2011 at 10:13 AM, Spencer Oliver wrote: > with ref to subject commit ef885d3b2a3001325f525df250dadd570e5d743e > the files jim-nvp.[ch] have no copyright info. They are FreeBSD, but when combined with OpenOCD source, they have to be distributed under GPL of course. The header can s

[Openocd-development] commit - jim-nvp is moving from jimtcl to openocd

2011-10-21 Thread Spencer Oliver
with ref to subject commit ef885d3b2a3001325f525df250dadd570e5d743e the files jim-nvp.[ch] have no copyright info. Cheers Spen ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-dev

Re: [Openocd-development] Command-line paths problem in Windows

2011-10-21 Thread freddie_chopin
W dniu 2011-10-21 00:12:52 użytkownik Andrew Leech napisał: > Have you tried with double backslash "\\" ? Actually no, I guess that it would probably work but you'd still have to give path to OpenOCD working directory in Eclipse and probably still use "..\\" before directory with config file.