[Openocd-development] New patch to review for openocd: 7405d98 clang: fix malloc() warning with assert

[Gerrit]

This is an automated email from Gerrit.

Øyvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to 
Gerrit, which you can find at http://openocd.zylin.com/41

-- gerrit
commit 7405d985b1957c6dfbde3cdf5842bfad914f2873
Author: Øyvind Harboe <oyvind.har...@zylin.com>
Date:   Fri Oct 21 19:00:09 2011 +0200

    clang: fix malloc() warning with assert
    
    Change-Id: I989d2655622a9f11f4a0a2994014e42822587ecd
    Signed-off-by: Øyvind Harboe <oyvind.har...@zylin.com>

diff --git a/src/jtag/tcl.c b/src/jtag/tcl.c
index 3b2f83b..468edf5 100644
--- a/src/jtag/tcl.c
+++ b/src/jtag/tcl.c
@@ -172,6 +172,7 @@ static int Jim_Command_drscan(Jim_Interp *interp, int argc, 
Jim_Obj *const *args
        }
 
        num_fields = (argc-2)/2;
+       assert(num_fields > 0);
        fields = malloc(sizeof(struct scan_field) * num_fields);
        for (i = 2; i < argc; i += 2)
        {
diff --git a/src/target/image.c b/src/target/image.c
index 21ce11f..8f437c0 100644
--- a/src/target/image.c
+++ b/src/target/image.c
@@ -473,6 +473,8 @@ static int image_elf_read_headers(struct image *image)
                if ((field32(elf, elf->segments[i].p_type) == PT_LOAD) && 
(field32(elf, elf->segments[i].p_filesz) != 0))
                        image->num_sections++;
 
+       assert(image->num_sections > 0);
+
        /**
         * some ELF linkers produce binaries with *all* the program header
         * p_paddr fields zero (there can be however one loadable segment

-- 

_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development