Re: [Openocd-development] [PATCH 1/4] embedded hosts: optimize common code path for core arm operations

2009-12-10 Thread Øyvind Harboe
On Fri, Dec 11, 2009 at 3:22 AM, David Brownell wrote: > On Thursday 10 December 2009, Øyvind Harboe wrote: >> +   /* FIX this is a kludge!!! arm926ejs.c should >> reimplement this arm_jtag_set_instr to >> +    * have special verification code. >> +    */ >

Re: [Openocd-development] [PATCH 1/4] embedded hosts: optimize common code path for core arm operations

2009-12-10 Thread David Brownell
On Thursday 10 December 2009, Øyvind Harboe wrote: > +   /* FIX this is a kludge!!! arm926ejs.c should reimplement > this arm_jtag_set_instr to > +    * have special verification code. > +    */ > +   jtag_add_ir_scan_noverify(1, &field, jtag_get

Re: [Openocd-development] [PATCH 0/3] deferred 'init' and leaner 'help'

2009-12-10 Thread Zach Welch
On Thu, 2009-12-10 at 13:18 +, Spencer Oliver wrote: > Spencer Oliver wrote: > > Zachary T Welch wrote: > >> Hi all, > >> > >> These patches clean up the server and system startup. The first patch > >> factors the GDB server setup to be more conducive to deferred > >> initialization of targets

Re: [Openocd-development] [PATCH 2/4] optimisation: tiny optimisation for embedded ice

2009-12-10 Thread Øyvind Harboe
On Thu, Dec 10, 2009 at 9:51 PM, David Brownell wrote: > On Thursday 10 December 2009, Øyvind Harboe wrote: >> On Thu, Dec 10, 2009 at 9:10 PM, David Brownell wrote: >> > On Thursday 10 December 2009, Ųyvind Harboe wrote: >> >> +   values[1]=(1<<5)|reg_addr; >> > >> > Could you please add spa

Re: [Openocd-development] [PATCH 4/4] gdb_server: use more local variables in inner loop of fetching packetstiny refactoring to allow optimisation of inner loops

2009-12-10 Thread Øyvind Harboe
On Thu, Dec 10, 2009 at 9:50 PM, David Brownell wrote: > On Thursday 10 December 2009, Ųyvind Harboe wrote: >> GDB load is at 600kBytes/s @ 16MHz for arm7 now with zy1000 revc. > > Where previously it was ... ? It went from ~580-90 to 600-15'ish. > The thing about micro-optimization is that it d

Re: [Openocd-development] [PATCH 2/4] optimisation: tiny optimisation for embedded ice

2009-12-10 Thread Øyvind Harboe
On Thu, Dec 10, 2009 at 9:10 PM, David Brownell wrote: > On Thursday 10 December 2009, Ųyvind Harboe wrote: >> +   values[1]=(1<<5)|reg_addr; > > Could you please add spaces around the operators? > >        values[1] = (1 << 5) | reg_addr; > > I've been carrying around a cleanup patch, as-yet

Re: [Openocd-development] [PATCH 4/4] gdb_server: use more local variables in inner loop of fetching packetstiny refactoring to allow optimisation of inner loops

2009-12-10 Thread Øyvind Harboe
On Thu, Dec 10, 2009 at 9:07 PM, David Brownell wrote: > On Thursday 10 December 2009, Øyvind Harboe wrote: >> Some profiling information for arm7 16MHz GDB load operation shows >> gdb_get_packet_inner() near the very top. >> >> Each sample counts as 0.01 seconds. >>   %   cumulative   self      

Re: [Openocd-development] [PATCH 2/4] optimisation: tiny optimisation for embedded ice

2009-12-10 Thread David Brownell
On Thursday 10 December 2009, Øyvind Harboe wrote: > On Thu, Dec 10, 2009 at 9:10 PM, David Brownell wrote: > > On Thursday 10 December 2009, Ųyvind Harboe wrote: > >> +   values[1]=(1<<5)|reg_addr; > > > > Could you please add spaces around the operators? > > > >        values[1] = (1 << 5) |

Re: [Openocd-development] [PATCH 4/4] gdb_server: use more local variables in inner loop of fetching packetstiny refactoring to allow optimisation of inner loops

2009-12-10 Thread David Brownell
On Thursday 10 December 2009, Øyvind Harboe wrote: > GDB load is at 600kBytes/s @ 16MHz for arm7 now with zy1000 revc. Where previously it was ... ? The thing about micro-optimization is that it doesn't necessarily affect anything of significance. You can shuffle cycles around easily enough, eve

Re: [Openocd-development] [PATCH 2/4] optimisation: tiny optimisation for embedded ice

2009-12-10 Thread David Brownell
On Thursday 10 December 2009, Øyvind Harboe wrote: > +   values[1]=(1<<5)|reg_addr; Could you please add spaces around the operators? values[1] = (1 << 5) | reg_addr; I've been carrying around a cleanup patch, as-yet unmerged, to fix that routine... _

Re: [Openocd-development] [PATCH 3/4] gdb_server: make struct gdb_connection private

2009-12-10 Thread David Brownell
On Thursday 10 December 2009, Øyvind Harboe wrote: > it is only used inside gdb_server.c This is a code cleanup that can be applied in quite a few other places. Related, not every driver needs to keep driver-private declarations in a header file that could be imported by other code. ;) - Dave

Re: [Openocd-development] [PATCH 4/4] gdb_server: use more local variables in inner loop of fetching packetstiny refactoring to allow optimisation of inner loops

2009-12-10 Thread David Brownell
On Thursday 10 December 2009, Øyvind Harboe wrote: > Some profiling information for arm7 16MHz GDB load operation shows > gdb_get_packet_inner() near the very top. > > Each sample counts as 0.01 seconds. >   %   cumulative   self              self     total >  time   seconds   seconds    calls  Ts

[Openocd-development] [PATCH 1/4] embedded hosts: optimize common code path for core arm operations

2009-12-10 Thread Øyvind Harboe
avoid fn call for the if check on whether anything needs to be done. Signed-off-by: Øyvind Harboe --- src/target/arm_jtag.c | 75 + src/target/arm_jtag.h | 37 ++-- 2 files changed, 66 insertions(+), 46 deletions(-) diff --

[Openocd-development] [PATCH 3/4] gdb_server: make struct gdb_connection private

2009-12-10 Thread Øyvind Harboe
it is only used inside gdb_server.c Signed-off-by: Øyvind Harboe --- src/server/gdb_server.c | 21 - src/server/gdb_server.h | 19 +-- 2 files changed, 21 insertions(+), 19 deletions(-) diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c index

[Openocd-development] [PATCH 2/4] optimisation: tiny optimisation for embedded ice

2009-12-10 Thread Øyvind Harboe
use two shift operations instead of three to set embedded ice register. Signed-off-by: Øyvind Harboe --- src/target/embeddedice.h |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/target/embeddedice.h b/src/target/embeddedice.h index 1faa1ee..ec381ff 100644 ---

[Openocd-development] [PATCH 4/4] gdb_server: use more local variables in inner loop of fetching packetstiny refactoring to allow optimisation of inner loops

2009-12-10 Thread Øyvind Harboe
Some profiling information for arm7 16MHz GDB load operation shows gdb_get_packet_inner() near the very top. Each sample counts as 0.01 seconds. % cumulative self self total time seconds secondscalls Ts/call Ts/call name 52.91 2.27 2.27

[Openocd-development] [PATCH 1/1] - add dsp563xx support

2009-12-10 Thread Mathias K.
From: Mathias Kuester --- src/target/Makefile.am |6 +- src/target/dsp563xx.c | 1037 src/target/dsp563xx.h | 88 src/target/dsp563xx_once.c | 124 ++ src/target/dsp563xx_once.h | 81 src/target/target.c|

Re: [Openocd-development] [PATCH 0/3] deferred 'init' and leaner 'help'

2009-12-10 Thread Spencer Oliver
Spencer Oliver wrote: Zachary T Welch wrote: Hi all, These patches clean up the server and system startup. The first patch factors the GDB server setup to be more conducive to deferred initialization of targets (in a later series). The second provides the 'noinit' command which can be used in

Re: [Openocd-development] New object-orientated C++ architecture for OpenOCD?

2009-12-10 Thread René Doss
Perhaps is the question in the subject too much aimed to c++. The wish is a little different to a better modelling system. This can also an UML abstraction. activity diagram or other diagrams. rene ___ Openocd-development mailing list Openocd-developm

Re: [Openocd-development] New object-orientated C++ architecture for OpenOCD?

2009-12-10 Thread Nico Coesel
> -Original Message- > From: openocd-development-boun...@lists.berlios.de [mailto:openocd- > development-boun...@lists.berlios.de] On Behalf Of Michel Catudal > Sent: donderdag 10 december 2009 0:59 > To: Freddie Chopin > Cc: openocd-development > Subject: Re: [Openocd-development] New obje