Re: RFR: 8298167: Opacity in WebView not working anymore [v2]

2023-01-11 Thread Oliver Schmidtmer
On Wed, 11 Jan 2023 07:50:39 GMT, Roman Marchenko wrote: >> There was refactoring in WebKit's GraphicsContext class (nativecode) >> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63 >> >> >> GraphicsContextJava's methods begin/endPlatformTransparencyLayers were

RFR: 8334124: Rendering issues with CSS "text-shadow" in WebView

2024-08-27 Thread Oliver Schmidtmer
On a Shadow state update with cleared shadow, the new values were not transmitted to the Java GraphicsDecoder - Commit messages: - 8334124: Rendering issues with CSS "text-shadow" in WebView Changes: https://git.openjdk.org/jfx/pull/1547/files Webrev: https://webrevs.openjdk.org/

Re: RFR: 8334124: Rendering issues with CSS "text-shadow" in WebView [v2]

2024-08-27 Thread Oliver Schmidtmer
> On a Shadow state update with cleared shadow, the new values were not > transmitted to the Java GraphicsDecoder Oliver Schmidtmer has updated the pull request incrementally with one additional commit since the last revision: add test - Changes: - all:

Re: RFR: 8334124: Rendering issues with CSS "text-shadow" in WebView [v2]

2024-08-27 Thread Oliver Schmidtmer
On Tue, 27 Aug 2024 20:21:43 GMT, Oliver Schmidtmer wrote: >> On a Shadow state update with cleared shadow, the new values were not >> transmitted to the Java GraphicsDecoder > > Oliver Schmidtmer has updated the pull request incrementally with one > additional commit si

RFR: 8337481: File API: file.name contains path instead of name

2024-08-29 Thread Oliver Schmidtmer
FileSystemJava had no valid implementation for pathFileName since the function was renamed from pathGetFileName to pathFileName in the FileSystem.h from WebKit - Commit messages: - 8337481 Fix FileSystemJava.pathFileName Changes: https://git.openjdk.org/jfx/pull/1551/files Webrev

Re: RFR: 8337481: File API: file.name contains path instead of name [v2]

2024-08-29 Thread Oliver Schmidtmer
> FileSystemJava had no valid implementation for pathFileName since the > function was renamed from pathGetFileName to pathFileName in the FileSystem.h > from WebKit Oliver Schmidtmer has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8337481: File API: file.name contains path instead of name [v3]

2024-08-30 Thread Oliver Schmidtmer
> FileSystemJava had no valid implementation for pathFileName since the > function was renamed from pathGetFileName to pathFileName in the FileSystem.h > from WebKit Oliver Schmidtmer has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8337481: File API: file.name contains path instead of name [v2]

2024-08-30 Thread Oliver Schmidtmer
On Fri, 30 Aug 2024 08:18:08 GMT, Ambarish Rapte wrote: >> Oliver Schmidtmer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add test > > modules/javafx.web/src/main/native/Source/WTF/wtf/java/FileSystemJ

Re: RFR: 8337481: File API: file.name contains path instead of name [v2]

2024-08-30 Thread Oliver Schmidtmer
On Fri, 30 Aug 2024 08:18:28 GMT, Ambarish Rapte wrote: >> Oliver Schmidtmer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add test > > modules/javafx.web/src/test/java/test/javafx/scene/web/F

Re: RFR: 8334124: Rendering issues with CSS "text-shadow" in WebView [v3]

2024-08-30 Thread Oliver Schmidtmer
> On a Shadow state update with cleared shadow, the new values were not > transmitted to the Java GraphicsDecoder Oliver Schmidtmer has updated the pull request incrementally with one additional commit since the last revision: Requested changes from review - Changes:

Integrated: 8337481: File API: file.name contains path instead of name

2024-08-30 Thread Oliver Schmidtmer
On Thu, 29 Aug 2024 13:16:11 GMT, Oliver Schmidtmer wrote: > FileSystemJava had no valid implementation for pathFileName since the > function was renamed from pathGetFileName to pathFileName in the FileSystem.h > from WebKit This pull request has now been integrated. Changeset:

Integrated: 8334124: Rendering issues with CSS "text-shadow" in WebView

2024-08-31 Thread Oliver Schmidtmer
On Tue, 27 Aug 2024 15:55:47 GMT, Oliver Schmidtmer wrote: > On a Shadow state update with cleared shadow, the new values were not > transmitted to the Java GraphicsDecoder This pull request has now been integrated. Changeset: e0ceafb7 Author:Oliver Schmidtmer Committer: Jay Bhaska

[jfx23u] RFR: 8337481: File API: file.name contains path instead of name

2024-09-04 Thread Oliver Schmidtmer
Clean backport of JDK-8337481 - Commit messages: - Backport ca70a07b3ee712b1d06baf8a3901e6ae96070124 Changes: https://git.openjdk.org/jfx23u/pull/19/files Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=19&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337481 Stats:

[jfx23u] Integrated: 8337481: File API: file.name contains path instead of name

2024-09-04 Thread Oliver Schmidtmer
On Wed, 4 Sep 2024 12:30:43 GMT, Oliver Schmidtmer wrote: > Clean backport of JDK-8337481 This pull request has now been integrated. Changeset: 34835744 Author: Oliver Schmidtmer Committer: Kevin Rushforth URL: https://git.openjdk.org/jfx23u/com

Re: RFR: 8306707: Support pluggable image loading via javax.imageio [v3]

2024-10-16 Thread Oliver Schmidtmer
On Wed, 16 Oct 2024 14:30:12 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/javax/XImageLoader.java >> line 203: >> >>> 201: case TYPE_BYTE_INDEXED -> "TYPE_BYTE_INDEXED"; >>> 202: default -> Integer.toString(image.

Re: RFR: 8340322: Update WebKit to 620.1

2025-02-11 Thread Oliver Schmidtmer
On Mon, 10 Feb 2025 15:27:49 GMT, Jay Bhaskar wrote: > Webkit JavaFx upgrade from 619.1 to 620.1 > Build is verified in mac , windows and linux. Sanity testing looks fine. No > issues seen, except one observed CanvasPattern test where it works only on > Linux but failed on Mac/Windows (WIP). >

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v4]

2025-03-25 Thread Oliver Schmidtmer
On Fri, 28 Feb 2025 16:48:39 GMT, Michael Strauß wrote: >> As the existing code was already pretty optimistic about 2 byte chars, is it >> possible that is already handled somewhere else? >> I'm not sure whether this is done explicitly somewhere or if CF_UNICODETEXT >> is just tried first. > >

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v9]

2025-04-05 Thread Oliver Schmidtmer
remaining chars. > > The JIRA ticket contains a JNA based sample program, which prefills the > buffer for demonstrating this issue. > If this should be added as a unit test, I'm open for advice how to do that. Oliver Schmidtmer has updated the pull request incrementally with one

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v6]

2025-03-25 Thread Oliver Schmidtmer
remaining chars. > > The JIRA ticket contains a JNA based sample program, which prefills the > buffer for demonstrating this issue. > If this should be added as a unit test, I'm open for advice how to do that. Oliver Schmidtmer has updated the pull request incrementally with one

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v7]

2025-03-26 Thread Oliver Schmidtmer
remaining chars. > > The JIRA ticket contains a JNA based sample program, which prefills the > buffer for demonstrating this issue. > If this should be added as a unit test, I'm open for advice how to do that. Oliver Schmidtmer has updated the pull request incrementally with one

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v8]

2025-03-28 Thread Oliver Schmidtmer
remaining chars. > > The JIRA ticket contains a JNA based sample program, which prefills the > buffer for demonstrating this issue. > If this should be added as a unit test, I'm open for advice how to do that. Oliver Schmidtmer has updated the pull request with a new target base

Integrated: 8281384: Random chars on paste from Windows clipboard

2025-04-01 Thread Oliver Schmidtmer
On Tue, 25 Feb 2025 13:25:07 GMT, Oliver Schmidtmer wrote: > Windows programs may reuse a clipboard buffer that is larger than the new > content. In this case de NUL terminator is not at the end of the buffer, but > within it. > The current implementation copys the whole buffer

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v5]

2025-02-27 Thread Oliver Schmidtmer
remaining chars. > > The JIRA ticket contains a JNA based sample program, which prefills the > buffer for demonstrating this issue. > If this should be added as a unit test, I'm open for advice how to do that. Oliver Schmidtmer has updated the pull request incrementally with one

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v4]

2025-02-27 Thread Oliver Schmidtmer
On Thu, 27 Feb 2025 03:40:47 GMT, Michael Strauß wrote: >> Oliver Schmidtmer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> cleanup > > modules/javafx.graphics/src/main/native-glass/win/GlassCli

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v3]

2025-02-26 Thread Oliver Schmidtmer
remaining chars. > > The JIRA ticket contains a JNA based sample program, which prefills the > buffer for demonstrating this issue. > If this should be added as a unit test, I'm open for advice how to do that. Oliver Schmidtmer has updated the pull request incrementally with one

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v4]

2025-02-26 Thread Oliver Schmidtmer
remaining chars. > > The JIRA ticket contains a JNA based sample program, which prefills the > buffer for demonstrating this issue. > If this should be added as a unit test, I'm open for advice how to do that. Oliver Schmidtmer has updated the pull request incrementally with one

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v2]

2025-02-25 Thread Oliver Schmidtmer
On Tue, 25 Feb 2025 14:36:59 GMT, Kevin Rushforth wrote: >> Oliver Schmidtmer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> check both UTF16 bytes > > modules/javafx.graphics/src/main/java/com/sun/glass/

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v2]

2025-02-25 Thread Oliver Schmidtmer
remaining chars. > > The JIRA ticket contains a JNA based sample program, which prefills the > buffer for demonstrating this issue. > If this should be added as a unit test, I'm open for advice how to do that. Oliver Schmidtmer has updated the pull request incrementally with one

RFR: 8281384: Random chars on paste from Windows clipboard

2025-02-25 Thread Oliver Schmidtmer
Windows programs may reuse a clipboard buffer that is larger than the new content. In this case de NUL terminator is not at the end of the buffer, but within it. The current implementation copys the whole buffer into a text field, including the NUL terminator and the remaining chars. The JIRA

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v7]

2025-03-27 Thread Oliver Schmidtmer
On Thu, 27 Mar 2025 10:06:02 GMT, Lukasz Kostyra wrote: >> Oliver Schmidtmer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> readding flavors with changed mapping > > modules/javafx.graphics/src/main/nativ