On Fri, 30 Aug 2024 08:18:08 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Oliver Schmidtmer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add test > > modules/javafx.web/src/main/native/Source/WTF/wtf/java/FileSystemJava.cpp > line 276: > >> 274: } >> 275: >> 276: String pathFileName(const String& path) > > This method is used 2 times in file > `modules/javafx.web/src/main/native/Source/WebCore/fileapi/FileCocoa.mm`. > It needs correction. > [[1]](https://github.com/openjdk/jfx/blob/a53bc589ac37d490b1406a2b977097a06bf5ac74/modules/javafx.web/src/main/native/Source/WebCore/fileapi/FileCocoa.mm#L62), > > [[2]](https://github.com/openjdk/jfx/blob/a53bc589ac37d490b1406a2b977097a06bf5ac74/modules/javafx.web/src/main/native/Source/WebCore/fileapi/FileCocoa.mm#L64) Indeed, now there are no more calls to pathGetFileName in the branch ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1551#discussion_r1738464337
