On Fri, 2 Jun 2023 15:56:23 GMT, Eric Long wrote:
>> RISC-V is a new free and open-source ISA that is being widely adopted in the
>> recent years. Currently WebKit is ready for riscv64, and only minor changes
>> is needed to support the platform.
>
> Eric Long has updated the pull request with
On Fri, 21 Jul 2023 14:24:17 GMT, Kevin Rushforth wrote:
> Is this new code or was it moved / refactored from elsewhere? If new code,
> what is its purpose, and who is calling it?
It was taken from last webkit update, as it was giving undefined reference
error for current webkit update.
> ```
On Sun, 23 Jul 2023 10:28:18 GMT, yosbits wrote:
> I found a change to turn off DFGJIT by default, is this a fix for some
> problem?
>
> modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java
The Change is required, as it is making issues with complex js code written for
a website.
---
On Fri, 21 Jul 2023 16:52:27 GMT, Jay Bhaskar wrote:
> absoluteLinkURL
Agree
-
PR Comment: https://git.openjdk.org/jfx/pull/1180#issuecomment-1647113499
On Sun, 23 Jul 2023 15:55:39 GMT, Johan Vos wrote:
> > Oh, I see that now. What led me to ask this question was that there is an
> > alternative implementation in `#if PLATFORM(JAVA)`, which implies that we
> > removed the call to `stripLeadingAndTrailingHTMLSpaces` and that it is
> > still pr
Issue: Some web worker tests fail to finish.
Root Cause:
sharedTimerFiredInternal function from ThreadTimers class does not require an
isMainThread check, The check was introduced during the initial webkit
stabilization.
-
Commit messages:
- 8313177: Web Workers timeout with Webkit
> Issue: Some web worker tests fail to finish.
> Root Cause:
> sharedTimerFiredInternal function from ThreadTimers class does not require an
> isMainThread check, The check was introduced during the initial webkit
> stabilization.
Jay Bhaskar has updated the pull request increme
> Issue: Some web worker tests fail to finish.
> Root Cause:
> sharedTimerFiredInternal function from ThreadTimers class does not require an
> isMainThread check, The check was introduced during the initial webkit
> stabilization.
Jay Bhaskar has updated the pull request increme
On Mon, 31 Jul 2023 22:26:48 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add test case for worker timeout
>
> modules/javafx.web/src/test/java/test/javaf
On Mon, 31 Jul 2023 06:03:58 GMT, Jay Bhaskar wrote:
> Issue: Some web worker tests fail to finish.
> Root Cause:
> sharedTimerFiredInternal function from ThreadTimers class does not require an
> isMainThread check, The check was introduced during the initial webkit
> stabilizat
On Wed, 2 Aug 2023 12:23:04 GMT, Jay Bhaskar wrote:
> clean backport for jfx21u. The fix is for the js web worker timeout ( some
> tests fail to finish)
This pull request has now been integrated.
Changeset: a9161e83
Author: Jay Bhaskar
URL:
https://git.openjdk.org/jfx21u/
clean backport for jfx21u. The fix is for the js web worker timeout ( some
tests fail to finish)
-
Commit messages:
- Backport 5f5e54feb2e816dcb351a28862c798117c3f81e8
Changes: https://git.openjdk.org/jfx21u/pull/5/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=5&range=
Issue : Enabling modern media controls on webkit 616.1 does not load button
images on HTML5 Video Element
Solution: Add resources and correct MediaControl Stylesheet
-
Commit messages:
- use smart pointer to avoid memory leak
- Adding simple tool based on python to generate base64
> Issue : Enabling modern media controls on webkit 616.1 does not load button
> images on HTML5 Video Element
> Solution: Add resources and correct MediaControl Stylesheet
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
On Tue, 8 Aug 2023 11:41:11 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up according to review comments
>
> modules/javafx.web/src/main/nativ
> Issue : Enabling modern media controls on webkit 616.1 does not load button
> images on HTML5 Video Element
> Solution: Add resources and correct MediaControl Stylesheet
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
more
On Tue, 8 Aug 2023 16:39:30 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up according to review comments
>
> modules/javafx.web/src/main/nativ
On Tue, 8 Aug 2023 17:33:29 GMT, Jay Bhaskar wrote:
>> modules/javafx.web/src/main/native/Source/WebCore/platform/java/ModernMediaControlResource.cpp
>> line 28:
>>
>>> 26: #include "ModernMediaControlResource.h"
>>> 27:
>>> 28:
On Sun, 6 Aug 2023 11:46:32 GMT, Jay Bhaskar wrote:
> Issue : Enabling modern media controls on webkit 616.1 does not load button
> images on HTML5 Video Element
> Solution: Add resources and correct MediaControl Stylesheet
This pull request has now been integrated.
Changeset: 5d7417
On Wed, 9 Aug 2023 12:09:26 GMT, Jay Bhaskar wrote:
> A clean backport to jfx21u. The fix is for the video control issue, without
> the fix, the controls ( play, pause, etc. buttons ) are not rendering. I have
> tested the fix it is working with the fix and failing without the fix.
A clean backport to jfx21u. The fix is for the video control issue, without the
fix, the controls ( play, pause, etc. buttons ) are not rendering. I have
tested the fix it is working with the fix and failing without the fix.
-
Commit messages:
- Backport 5d741761e751aa047f265d9d816
Issue: WCMediaPlayer does not support HTTP live streaming m3u8 format. Giving
error com.sun.javafx.webkit.prism.WCMediaPlayerImpl onError WARNING: onError,
errCode=0, msg=Unsupported protocol "data"
Solution: Do not invoke the current media time operation in an error state. As
the WCMediaPlayer
On Thu, 17 Aug 2023 07:51:56 GMT, Jay Bhaskar wrote:
> Issue: WCMediaPlayer does not support HTTP live streaming m3u8 format. Giving
> error com.sun.javafx.webkit.prism.WCMediaPlayerImpl onError WARNING: onError,
> errCode=0, msg=Unsupported protocol "data"
>
> So
an error state.
> As the WCMediaPlayer might not be a valid object.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
clean up according to review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pu
On Thu, 17 Aug 2023 11:44:04 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up according to review comments
>
> modules/javafx.web/src/main/native/Source/
On Thu, 17 Aug 2023 16:17:45 GMT, Kevin Rushforth wrote:
>> done
>
> The answer to my question is still pending. Please take a look at whether or
> not this is the only error you need to check. If it is, can you say why?
Once the Player is in an error state, play, pause, seek, etc. all of these
On Thu, 17 Aug 2023 16:28:35 GMT, Kevin Rushforth wrote:
>> Once the Player is in an error state, play, pause, seek, etc. all of these
>> operations would not be called. Only the current time which is the last
>> played point of time needs to be updated to the player user interface.
>
> OK. My
On Thu, 17 Aug 2023 07:51:56 GMT, Jay Bhaskar wrote:
> Issue: WCMediaPlayer does not support HTTP live streaming m3u8 format. Giving
> error com.sun.javafx.webkit.prism.WCMediaPlayerImpl onError WARNING: onError,
> errCode=0, msg=Unsupported protocol "data"
>
> So
On Fri, 18 Aug 2023 15:17:56 GMT, Jay Bhaskar wrote:
> A clean backport to jfx21u. The fix is for the cnn.com web page crash issue,
> without the fix, the page crashes. I have tested the fix it is working with
> the fix and failing without the fix.
This pull request has now been i
A clean backport to jfx21u. The fix is for the cnn.com web page crash issue,
without the fix, the page crashes. I have tested the fix it is working with the
fix and failing without the fix.
-
Commit messages:
- Backport ddd1f79685383f592a4651811a9a9070569a7832
Changes: https://git
On Wed, 30 Aug 2023 14:32:37 GMT, Andrew Brygin wrote:
> This issue is a regression from 7e48413eb0 8285881: Update WebKit to 614.1.
> For synchronous requests, we have an additional buffer to collect data, and
> the appending data into this buffer is doing in a wrong way: we use
> Vector::a
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote:
> With the help of debug build which pinpointed the crash, I found the commit
> in upstream WebKit core that caused the crash. That commit was subsequently
> reverted not long after it was initially committed. This reverted commit
> wasn
Issue: constructor Path(Path) which takes another Path object fails to draw on
canvas html.
Solution: copy the old path to the current path constructor
-
Commit messages:
- 8323879: constructor Path(Path) which takes another Path object fail to draw
on canvas html
Changes: https:/
> Issue: constructor Path(Path) which takes another Path object fails to draw
> on canvas html.
> Solution: copy the old path to the current path constructor
Jay Bhaskar has refreshed the contents of this pull request, and previous
commits have been removed. Incremental views are not
On Thu, 18 Jan 2024 03:30:21 GMT, Jay Bhaskar wrote:
> Issue: constructor Path(Path) which takes another Path object fails to draw
> on canvas html.
> Solution: copy the old path to the current path constructor
This pull request has been closed without being integrated.
Issue: constructor Path(Path) which takes another Path object fails to draw on
canvas html.
Solution: copy the old path while creating a new Path object from the existing
Path that is already created with the same canvas rendering context.
-
Commit messages:
- 8323879: constructor
On Thu, 18 Jan 2024 20:51:05 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove unused variable and imports
>
> modules/javafx.web/src/t
> Issue: constructor Path(Path) which takes another Path object fails to draw
> on canvas html.
> Solution: copy the old path while creating a new Path object from the
> existing Path that is already created with the same canvas rendering context.
Jay Bhaskar has updated the
On Thu, 18 Jan 2024 03:51:28 GMT, Jay Bhaskar wrote:
> Issue: constructor Path(Path) which takes another Path object fails to draw
> on canvas html.
> Solution: copy the old path while creating a new Path object from the
> existing Path that is already created with the same canv
A clean backport to jfx22u. The fix is for the canvas path constructor drawing
with an old path on canvas, without the fix, the page crashes. I have tested
the fix it is working with the fix and failing without the fix.
-
Commit messages:
- Backport 3cf9390f5fb2ad564eeec3a95744503f
On Tue, 23 Jan 2024 16:15:42 GMT, Jay Bhaskar wrote:
> A clean backport to jfx22u. The fix is for the canvas path constructor
> drawing with an old path on canvas, without the fix, the page crashes. I have
> tested the fix it is working with the fix and failing without the fix.
On Wed, 17 Jan 2024 12:57:22 GMT, Kevin Rushforth wrote:
>> As noted in the JBS bug, this is a follow-on to
>> [JDK-8196011](https://bugs.openjdk.org/browse/JDK-8196011) that I discovered
>> while testing the fix for
>> [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) (a deadlock in
Issue: The current implementation of complex text rendering paths on the Java
platform is experiencing side effects.
Solution: We need to align with WebKit 616.1 standards. The patch supports two
paths simple rendering path and complex rendering path based on text rendering
mode.
-
On Tue, 13 Feb 2024 16:57:37 GMT, Jay Bhaskar wrote:
> Issue: The current implementation of complex text rendering paths on the Java
> platform is experiencing side effects.
> Solution: We need to align with WebKit 616.1 standards. The patch supports
> two paths simple render
A clean backport to jfx22u. The fix is for rtl text issue, where the caret
position is at the wrong position. I have tested the fix it is working with the
fix and failing without the fix.
-
Commit messages:
- Backport 1fb56e333bc65860cc1abeebd1cbb01cd8b8e5f3
Changes: https://git.o
On Fri, 16 Feb 2024 14:00:57 GMT, Jay Bhaskar wrote:
> A clean backport to jfx22u. The fix is for rtl text issue, where the caret
> position is at the wrong position. I have tested the fix it is working with
> the fix and failing without the fix.
This pull request has now been i
Issue: xml not well-formed error occurs at XML document parser.
Issue: doEnd() call not needed for JAVA platform, as it is making
XMLDocumentParserLibxml2 xml not well-formed error.
-
Commit messages:
- 8290274: DRT 27 tests fail due to xml not well formed error on window
Changes:
On Wed, 10 Aug 2022 10:06:21 GMT, Jay Bhaskar wrote:
> Issue: xml not well-formed error occurs at XML document parser.
> Issue: doEnd() call not needed for JAVA platform, as it is making
> XMLDocumentParserLibxml2 xml not well-formed error.
According to comments mention in the so
Issue: test Bug LocalStorageTest does not cleanup post execution
Solution: Path for LocalStorageDir changed to modules/javafx.web/build/. Now
the LocalStorageDir is deleted after post execution.
-
Commit messages:
- 8285878: [TestBug] LocalStorageTest does not cleanup post execution
> Issue: test Bug LocalStorageTest does not cleanup post execution
> Solution: Path for LocalStorageDir changed to modules/javafx.web/build/. Now
> the LocalStorageDir is deleted after post execution.
Jay Bhaskar has updated the pull request incrementally with two additional
commits
On Sat, 13 Aug 2022 11:45:00 GMT, Jay Bhaskar wrote:
> Issue: test Bug LocalStorageTest does not cleanup post execution
> Solution: Path for LocalStorageDir changed to modules/javafx.web/build/. Now
> the LocalStorageDir is deleted after post execution.
This pull request has be
On Tue, 6 Sep 2022 01:19:07 GMT, Leslie Zhai wrote:
> Hi,
>
> jfx web failed to build when `USE_SYSTEM_MALLOC` is `ON`:
>
>
> jfx/modules/javafx.web/build/linux/Release/WTF/Headers/wtf/Platform.h:58,
> jfx/modules/javafx.web/build/linux/Release/WTF/Headers/wtf/Assertions.h:28,
> jfx/modules/ja
On Thu, 17 Nov 2022 06:16:34 GMT, Hima Bindu Meda wrote:
> Updated sqlite to v3.39.4
> Verified build on windows, linux and mac.
> Sanity testing looks fine.
+ looks ok to me
-
Marked as reviewed by jbhaskar (Author).
PR: https://git.openjdk.org/jfx/pull/953
On Wed, 11 Jan 2023 07:50:39 GMT, Roman Marchenko
wrote:
>> There was refactoring in WebKit's GraphicsContext class (nativecode)
>> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63
>>
>>
>> GraphicsContextJava's methods begin/endPlatformTransparencyLayers were
On Wed, 11 Jan 2023 18:58:44 GMT, Roman Marchenko
wrote:
>> There was refactoring in WebKit's GraphicsContext class (nativecode)
>> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63
>>
>>
>> GraphicsContextJava's methods begin/endPlatformTransparencyLayers were
Issue: [linux] Crash on exit from WebKit 615.1 Crash dump observed on Window
exit
Root cause: Accessing local storage data of a thread having client data like
font cache during VM shutdown
Solution: Add a shutdown hook to ThreadTimers class, so that no timer class
doesn't fire any function durin
On Wed, 8 Feb 2023 13:51:29 GMT, Jay Bhaskar wrote:
> Issue: [linux] Crash on exit from WebKit 615.1 Crash dump observed on Window
> exit
> Root cause: Accessing local storage data of a thread having client data like
> font cache during VM shutdown
> Solution: Add a s
Issue: current update is breaking the rendering of media controls on youtube
video playback
For the Webkit Gtk platform, the layout class name is returned as
AdwaitaLayoutTraits
which is incompatible with the JAVA platform.
Solution: Use mediaControlsAdwaitaJavaScript and
m
en youtube.com and play any video, mouse hover on
> the video area, and the control
> should come up overlapping with each other.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
clean up , #if PLATFORM(JAVA) not valid
On Wed, 22 Feb 2023 12:36:44 GMT, Jay Bhaskar wrote:
>> Issue: current update is breaking the rendering of media controls on youtube
>> video playback
>>For the Webkit Gtk platform, the layout class name is returned as
>> AdwaitaLayoutTraits
>>
On Wed, 22 Feb 2023 07:46:58 GMT, Jay Bhaskar wrote:
> Issue: current update is breaking the rendering of media controls on youtube
> video playback
>For the Webkit Gtk platform, the layout class name is returned as
> AdwaitaLayoutTraits
>which is incomp
Issue: default html5 video element not showing media controls
Details: Media control design has been refactored in the current Webkit Gtk
port. The CSS id
and properties related to media buttons, and slider have been
removed, due to which the
media style mediaCon
media style mediaControlsAdwaita.css values are not being
> applied.
> Solution: restored media control keywords and mapped to CSS keywords values.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
minor correction
On Sun, 26 Feb 2023 17:03:29 GMT, Jay Bhaskar wrote:
>> Issue: default html5 video element not showing media controls
>> Details: Media control design has been refactored in the current Webkit Gtk
>> port. The CSS id
>> and properties related to media
media style mediaControlsAdwaita.css values are not being
> applied.
> Solution: restored media control keywords and mapped to CSS keywords values.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
media style mediaControlsAdwaita.css values are not being
> applied.
> Solution: restored media control keywords and mapped to CSS keywords values.
Jay Bhaskar has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will s
On Mon, 27 Feb 2023 18:56:35 GMT, Hima Bindu Meda wrote:
> With this fix, default slider of input type: Range is rendered properly.
> Verified build and unit tests.DRT tests related to "Range", also pass with
> this fix.
+ looks good
-
Marked as reviewed by jbhaskar (Author).
PR:
media style mediaControlsAdwaita.css values are not being
> applied.
> Solution: restored media control keywords and mapped to CSS keywords values.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Refactoring cod
media style mediaControlsAdwaita.css values are not being
> applied.
> Solution: restored media control keywords and mapped to CSS keywords values.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
render media slider
media style mediaControlsAdwaita.css values are not being
> applied.
> Solution: restored media control keywords and mapped to CSS keywords values.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
add test case
---
On Tue, 28 Feb 2023 14:41:59 GMT, Jay Bhaskar wrote:
>> Issue: default html5 video element not showing media controls
>> Details: Media control design has been refactored in the current Webkit Gtk
>> port. The CSS id
>> and properties related to media
media style mediaControlsAdwaita.css values are not being
> applied.
> Solution: restored media control keywords and mapped to CSS keywords values.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
resol
media style mediaControlsAdwaita.css values are not being
> applied.
> Solution: restored media control keywords and mapped to CSS keywords values.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
cleaning trailin
On Sun, 26 Feb 2023 16:47:23 GMT, Jay Bhaskar wrote:
> Issue: default html5 video element not showing media controls
> Details: Media control design has been refactored in the current Webkit Gtk
> port. The CSS id
> and properties related to media buttons, and slid
Issue: Error copying file (if different) from
Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py"
to
"modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate_header.py".
Root cause: The number of build threads more than 8, causing a synchroni
On Wed, 29 Mar 2023 08:46:53 GMT, Lukasz Kostyra wrote:
>> Issue: Error copying file (if different) from
>> Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py"
>> to
>> "modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate_header.py".
>>
On Wed, 29 Mar 2023 11:09:52 GMT, Lukasz Kostyra wrote:
>> do you mean as
>> if(copy_result)
>> message(WARNING "Failed to copy ${_file} to
>> ${JavaScriptCore_SCRIPTS_DIR}/${_script}: ${copy_output}")
>> should be as
>>
>> if(copy_result)
>> message(WARNING "${copy_res
On Tue, 28 Mar 2023 02:08:27 GMT, Jay Bhaskar wrote:
> Issue: Error copying file (if different) from
> Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py"
> to
> "modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate
clean backport to jfx20u. The fix solves the build issue on the macOx11_64
machine. It fixes the intermittent build issue. The build issue occurs without
the fix and does not occur with the fix.
-
Commit messages:
- Backport 810bd90d5089364067549b8ba299300bfd208357
Changes: https:
On Mon, 10 Apr 2023 17:19:15 GMT, Jay Bhaskar wrote:
> clean backport to jfx20u. The fix solves the build issue on the macOx11_64
> machine. It fixes the intermittent build issue. The build issue occurs
> without the fix and does not occur with the fix.
This pull request has
Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data
dirs"
Solution:
1. All data directories must only be created under the "build" dir. In addition
to being a best practice, at least they will be cleaned up by "gradle clean"
2. There should be an @AfterClass method that d
> "gradle clean"
> 2. There should be an @AfterClass method that deletes the data dirs
> 3. There should be an @BeforeClass method that also deletes the data dirs
> prior to running the tests in case it wasn't cleaned up previously
Jay Bhaskar has updated the pull reques
> "gradle clean"
> 2. There should be an @AfterClass method that deletes the data dirs
> 3. There should be an @BeforeClass method that also deletes the data dirs
> prior to running the tests in case it wasn't cleaned up previously
Jay Bhaskar has updated the pull request increme
On Thu, 20 Apr 2023 12:33:27 GMT, Jay Bhaskar wrote:
>> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data
>> dirs"
>> Solution:
>> 1. All data directories must only be created under the "build" dir. In
>> a
> "gradle clean"
> 2. There should be an @AfterClass method that deletes the data dirs
> 3. There should be an @BeforeClass method that also deletes the data dirs
> prior to running the tests in case it wasn't cleaned up previously
Jay Bhaskar has updated the pull reques
On Wed, 19 Apr 2023 13:25:07 GMT, Jay Bhaskar wrote:
> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data
> dirs"
> Solution:
> 1. All data directories must only be created under the "build" dir. In
> addition to being a best pr
Issue: [windows] Intermittent test failure in
test.javafx.scene.web.MiscellaneousTest::testDOMTimer
Analysis:
setTimeout call is not a real-time function. it is considered just a minimum
delay before the callback is executed. The actual time taken depends
1. How long it takes to process any m
Issue: The test fails, in case snapshot is taken before web view finish web
content load
Solution: Introduce a sleep , before taking snapshot of web view , to test
straight line
-
Commit messages:
- Fix straight line test, introduce a sleep before taking snapshot
Changes: https://
On Tue, 25 Apr 2023 12:18:17 GMT, Kevin Rushforth wrote:
>> Issue: [windows] Intermittent test failure in
>> test.javafx.scene.web.MiscellaneousTest::testDOMTimer
>> Analysis:
>> setTimeout call is not a real-time function. it is considered just a
>> minimum delay before the callback is execu
> Issue: The test fails, in case snapshot is taken before web view finish web
> content load
> Solution: Introduce a sleep , before taking snapshot of web view , to test
> straight line
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the l
On Tue, 25 Apr 2023 11:42:28 GMT, Jay Bhaskar wrote:
> Issue: The test fails, in case snapshot is taken before web view finish web
> content load
> Solution: Introduce a sleep , before taking snapshot of web view , to test
> straight line
Tested on Linux, There was an issue w
On Tue, 25 Apr 2023 06:41:56 GMT, Jay Bhaskar wrote:
> Issue: [windows] Intermittent test failure in
> test.javafx.scene.web.MiscellaneousTest::testDOMTimer
> Analysis:
> setTimeout call is not a real-time function. it is considered just a minimum
> delay before the callback i
> Issue: The test fails, in case snapshot is taken before web view finish web
> content load
> Solution: Introduce a sleep , before taking snapshot of web view , to test
> straight line
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the l
On Tue, 25 Apr 2023 11:42:28 GMT, Jay Bhaskar wrote:
> Issue: The test fails, in case snapshot is taken before web view finish web
> content load
> Solution: Introduce a sleep , before taking snapshot of web view , to test
> straight line
This pull request has now been integrated
Issue: The Websocket Channel is broken
Solution: The socket Provider needs a web page pointer, since the web socket
channel source code is moved to WebkitLegacy in 617.1 for the web process
model, it is invalid for JavaFx Webkit.
-
Commit messages:
- add pass and fail button
- 83
> Issue: The Websocket Channel is broken
> Solution: The socket Provider needs a web page pointer, since the web socket
> channel source code is moved to WebkitLegacy in 617.1 for the web process
> model, it is invalid for JavaFx Webkit.
Jay Bhaskar has updated the pull request i
On Thu, 20 Jun 2024 15:30:03 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adding review comments
>
> tests/manual/web/WebSocketTestApp.java line 2:
>
>
> Issue: The Websocket Channel is broken
> Solution: The socket Provider needs a web page pointer, since the web socket
> channel source code is moved to WebkitLegacy in 617.1 for the web process
> model, it is invalid for JavaFx Webkit.
Jay Bhaskar has updated the pull request i
On Thu, 20 Jun 2024 23:48:32 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adding review comments
>
> tests/manual/web/WebSocketTestApp.java line 62:
>
>
> Issue: The Websocket Channel is broken
> Solution: The socket Provider needs a web page pointer, since the web socket
> channel source code is moved to WebkitLegacy in 617.1 for the web process
> model, it is invalid for JavaFx Webkit.
Jay Bhaskar has updated the pull request i
1 - 100 of 232 matches
Mail list logo
