On Thu, 20 Jun 2024 15:30:03 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adding review comments
>
> tests/manual/web/WebSocketTestApp.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2022, 2024, Oracle and/or its affiliates. All rights
>> reserved.
>
> This file is new in 2024, so you can remove the `2022,`
done
> tests/manual/web/WebSocketTestApp.java line 62:
>
>> 60: failButton.setOnAction(e -> {
>> 61: Platform.exit();
>> 62: throw new AssertionError("on paste the Data Nodes count is
>> wrong.");
>
> The error message is wrong. It looks like a copy/paste from another test
> program. Something like "WebSocket connection failed" would be a better
> message.
looks good, will do
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1477#discussion_r1648231491
PR Review Comment: https://git.openjdk.org/jfx/pull/1477#discussion_r1648231716
