RFR: 8285881: Update WebKit to 614.1

2022-07-22 Thread Hima Bindu Meda
Update JavaFX WebKit to GTK WebKit 2.36 (614.1). Verified the updated version build, sanity tests and stability. This does not cause any issues except a few unit test failures. These tests are recorded and ignored using below bugs: [JDK-8290237](https://bugs.openjdk.org/browse/JDK-8290237) [JDK-82

Integrated: 8285881: Update WebKit to 614.1

2022-07-28 Thread Hima Bindu Meda
On Fri, 22 Jul 2022 19:29:12 GMT, Hima Bindu Meda wrote: > Update JavaFX WebKit to GTK WebKit 2.36 (614.1). > > Verified the updated version build, sanity tests and stability. > This does not cause any issues except a few unit test failures. > These tests are recorded and igno

RFR: JDK-8310681: Update WebKit to 616.1

2023-07-20 Thread Hima Bindu Meda
Updated JavaFX Webkit to GTK WebKit 2.40 (616.1). Verified the updated version build, sanity tests and stability. No issues have been observed. - Commit messages: - Update WebKit to 616.1 Changes: https://git.openjdk.org/jfx/pull/1180/files Webrev: https://webrevs.openjdk.org/?rep

Re: RFR: JDK-8310681: Update WebKit to 616.1

2023-07-21 Thread Hima Bindu Meda
On Thu, 20 Jul 2023 15:36:28 GMT, Hima Bindu Meda wrote: > Updated JavaFX Webkit to GTK WebKit 2.40 (616.1). > Verified the updated version build, sanity tests and stability. No issues > have been observed. > You can include this in the next "cherry-pick" update, if yo

Re: RFR: JDK-8310681: Update WebKit to 616.1 [v2]

2023-07-24 Thread Hima Bindu Meda
> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1). > Verified the updated version build, sanity tests and stability. No issues > have been observed. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Remove check for PLAT

Re: RFR: JDK-8310681: Update WebKit to 616.1

2023-07-24 Thread Hima Bindu Meda
On Mon, 24 Jul 2023 02:50:30 GMT, Jay Bhaskar wrote: > > Oh, I see that now. What led me to ask this question was that there is an > > alternative implementation in `#if PLATFORM(JAVA)`, which implies that we > > removed the call to `stripLeadingAndTrailingHTMLSpaces` and that it is > > still

Integrated: JDK-8310681: Update WebKit to 616.1

2023-07-28 Thread Hima Bindu Meda
On Thu, 20 Jul 2023 15:36:28 GMT, Hima Bindu Meda wrote: > Updated JavaFX Webkit to GTK WebKit 2.40 (616.1). > Verified the updated version build, sanity tests and stability. No issues > have been observed. This pull request has now been integrated. Changeset: 2dc699a8 Author:H

[jfx21u] RFR: 8310681: Update WebKit to 616.1

2023-07-28 Thread Hima Bindu Meda
Backport of webkit update to v616.1. Clean Backport - Commit messages: - Backport 2dc699a8661fb23040c9f8e3905713229e615816 Changes: https://git.openjdk.org/jfx21u/pull/3/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=3&range=00 Issue: https://bugs.openjdk.org/browse/JD

[jfx21u] Integrated: 8310681: Update WebKit to 616.1

2023-07-28 Thread Hima Bindu Meda
On Fri, 28 Jul 2023 13:06:48 GMT, Hima Bindu Meda wrote: > Backport of webkit update to v616.1. Clean Backport This pull request has now been integrated. Changeset: 104e0584 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx21u/commit/104e0584b516536ad829a560e87f6eb71513a

Re: RFR: 8313177: Web Workers timeout with Webkit 616.1 [v2]

2023-08-01 Thread Hima Bindu Meda
On Mon, 31 Jul 2023 08:16:12 GMT, Jay Bhaskar wrote: >> Issue: Some web worker tests fail to finish. >> Root Cause: >> sharedTimerFiredInternal function from ThreadTimers class does not require >> an isMainThread check, The check was introduced during the initial webkit >> stabilization. > > Ja

Re: RFR: 8313177: Web Workers timeout with Webkit 616.1 [v3]

2023-08-01 Thread Hima Bindu Meda
On Tue, 1 Aug 2023 09:54:03 GMT, Jay Bhaskar wrote: >> Issue: Some web worker tests fail to finish. >> Root Cause: >> sharedTimerFiredInternal function from ThreadTimers class does not require >> an isMainThread check, The check was introduced during the initial webkit >> stabilization. > > Jay

RFR: 8313711: Cherry-pick webkitgtk-2.40.5 stabilzation fixes

2023-08-03 Thread Hima Bindu Meda
Cherry-picked commits from webkitgtk-2.40.5. Verified build on windows, mac and linux. Sanity testing looks fine. No issues seen - Commit messages: - white space correction - cherry-pick webkit-2.40.5 Changes: https://git.openjdk.org/jfx/pull/1196/files Webrev: https://webrevs.op

Re: RFR: 8313711: Cherry-pick WebKit 616.1 stabilization fixes [v2]

2023-08-06 Thread Hima Bindu Meda
> Cherry-picked commits from webkitgtk-2.40.5. > Verified build on windows, mac and linux. Sanity testing looks fine. No > issues seen Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Correct indentation -

Re: RFR: 8313711: Cherry-pick WebKit 616.1 stabilization fixes [v2]

2023-08-07 Thread Hima Bindu Meda
On Fri, 4 Aug 2023 13:37:10 GMT, Kevin Rushforth wrote: >> modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3DuplicateTails.cpp >> line 89: >> >>> 87: >>> 88: if (canCopyBlock) >>> 89: candidates.add(block); >> >> The indentation looks off here. > > I'll re

Integrated: 8313711: Cherry-pick WebKit 616.1 stabilization fixes

2023-08-07 Thread Hima Bindu Meda
On Thu, 3 Aug 2023 17:54:48 GMT, Hima Bindu Meda wrote: > Cherry-picked commits from webkitgtk-2.40.5. > Verified build on windows, mac and linux. Sanity testing looks fine. No > issues seen This pull request has now been integrated. Changeset: af8950e7 Author:Hima Bindu

[jfx21u] Integrated: 8313711: Cherry-pick WebKit 616.1 stabilization fixes

2023-08-07 Thread Hima Bindu Meda
On Mon, 7 Aug 2023 14:23:50 GMT, Hima Bindu Meda wrote: > Clean backport This pull request has now been integrated. Changeset: bb6cbae9 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx21u/commit/bb6cbae996a529cd8d8bf30bf7b1c35fa920112e Stats: 637 lines in 88 fi

[jfx21u] Integrated: 8313711: Cherry-pick WebKit 616.1 stabilization fixes

2023-08-07 Thread Hima Bindu Meda
Clean backport - Commit messages: - Backport af8950e7ebfa1f0705cc9ef5ab50ce25571c00d4 Changes: https://git.openjdk.org/jfx21u/pull/6/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=6&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313711 Stats: 637 lines in 88 fi

Re: RFR: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element [v3]

2023-08-08 Thread Hima Bindu Meda
On Tue, 8 Aug 2023 17:39:18 GMT, Jay Bhaskar wrote: >> Issue : Enabling modern media controls on webkit 616.1 does not load button >> images on HTML5 Video Element >> Solution: Add resources and correct MediaControl Stylesheet > > Jay Bhaskar has updated the pull request incrementally with one a

RFR: 8313321 : Set minimum python version in WebKit cmake scripts

2023-08-09 Thread Hima Bindu Meda
Minimum version of python ,to run webkit build , on linux is set to 3.6 and for other platforms, minimum version of python is set to 3.8. Verified build on all platforms. No issue seen - Commit messages: - Add check for python version for various platforms Changes: https://git.ope

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v2]

2023-08-14 Thread Hima Bindu Meda
> Minimum version of python ,to run webkit build , on linux is set to 3.6 and > for other platforms, minimum version of python is set to 3.8. > > Verified build on all platforms. No issue seen Hima Bindu Meda has updated the pull request incrementally with one additional commit si

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts

2023-08-14 Thread Hima Bindu Meda
On Thu, 10 Aug 2023 23:00:11 GMT, Kevin Rushforth wrote: > I tested this on my MacBook Pro running macOS 13.3.1 and discovered that it > has python 3.7.x: > > ``` > Could NOT find Python3: Found unsuitable version "3.7.3", but required is > at least "3.8.0" (found /usr/bin/python3, found co

Re: RFR: 8314212: Crash when loading cnn.com in WebView [v2]

2023-08-18 Thread Hima Bindu Meda
On Thu, 17 Aug 2023 13:50:06 GMT, Jay Bhaskar wrote: >> Issue: WCMediaPlayer does not support HTTP live streaming m3u8 format. >> Giving error com.sun.javafx.webkit.prism.WCMediaPlayerImpl onError WARNING: >> onError, errCode=0, msg=Unsupported protocol "data" >> >> Solution: Do not invoke the

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v3]

2023-10-10 Thread Hima Bindu Meda
> Minimum version of python ,to run webkit build , on linux is set to 3.6 and > for other platforms, minimum version of python is set to 3.8. > > Verified build on all platforms. No issue seen Hima Bindu Meda has updated the pull request with a new target base due to a merge or a

Integrated: 8313321 : Set minimum python version in WebKit cmake scripts

2023-10-18 Thread Hima Bindu Meda
On Wed, 9 Aug 2023 07:31:57 GMT, Hima Bindu Meda wrote: > Minimum version of python ,to run webkit build , on linux is set to 3.6 and > for other platforms, minimum version of python is set to 3.8. > > Verified build on all platforms. No issue seen This pull request has now bee

[jfx21u] Integrated: 8313321: Set minimum python version in WebKit cmake scripts

2023-10-20 Thread Hima Bindu Meda
Set minimum python version for all platforms. - Commit messages: - Backport bb07bcf7eb60cb772e6d4f135893ff6915c5aa0d Changes: https://git.openjdk.org/jfx21u/pull/20/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=20&range=00 Issue: https://bugs.openjdk.org/browse/JDK-83

[jfx21u] Integrated: 8313321: Set minimum python version in WebKit cmake scripts

2023-10-20 Thread Hima Bindu Meda
On Fri, 20 Oct 2023 12:40:58 GMT, Hima Bindu Meda wrote: > Set minimum python version for all platforms. This pull request has now been integrated. Changeset: 8c2c9ca4 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx21u/commit/8c2c9ca4ca6bb72e5fbe97d002757d267b7c0882 St

RFR: 8318388: Update libxslt to 1.1.39

2023-11-29 Thread Hima Bindu Meda
Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen. - Commit messages: - white space corrections - update version info in libxslt.md - configure libxslt on linux - configure libxslt on windows - update libxslt to v1.1.39 Changes: https://git.openjdk.org/jf

Re: RFR: 8318388: Update libxslt to 1.1.39 [v2]

2023-11-30 Thread Hima Bindu Meda
> Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen. Hima Bindu Meda has updated the pull request incrementally with two additional commits since the last revision: - update license for libxslt - update libxslt.md - Changes: - all: ht

Integrated: 8318388: Update libxslt to 1.1.39

2023-12-05 Thread Hima Bindu Meda
On Wed, 29 Nov 2023 11:18:43 GMT, Hima Bindu Meda wrote: > Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen. This pull request has now been integrated. Changeset: 09922d5c Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/com

RFR: 8318614: Update WebKit to 617.1

2024-01-10 Thread Hima Bindu Meda
This PR updates webkit to v617.1. Verified build on Mac,Windows and linux. Sanity testing looks fine. No issues observed in HelloWebView as well - Commit messages: - Remove unwanted files - Update webkit to v617.1 Changes: https://git.openjdk.org/jfx/pull/1328/files Webrev: https:

Integrated: 8318614: Update WebKit to 617.1

2024-01-16 Thread Hima Bindu Meda
On Wed, 10 Jan 2024 17:53:46 GMT, Hima Bindu Meda wrote: > This PR updates webkit to v617.1. Verified build on Mac,Windows and linux. > Sanity testing looks fine. No issues observed in HelloWebView as well This pull request has now been integrated. Changeset: ba79e081 Author: Hima

Re: RFR: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html [v2]

2024-01-19 Thread Hima Bindu Meda
On Fri, 19 Jan 2024 01:06:50 GMT, Jay Bhaskar wrote: >> Issue: constructor Path(Path) which takes another Path object fails to draw >> on canvas html. >> Solution: copy the old path while creating a new Path object from the >> existing Path that is already created with the same canvas rendering

[jfx22u] RFR: 8318614: Update WebKit to 617.1

2024-01-23 Thread Hima Bindu Meda
Clean Backport. - Commit messages: - Backport ba79e081547b7f15697bfaaac42ec2de1971935a Changes: https://git.openjdk.org/jfx22u/pull/4/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=4&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8318614 Stats: 289254 lines in 6

[jfx22u] Integrated: 8318614: Update WebKit to 617.1

2024-01-23 Thread Hima Bindu Meda
On Tue, 23 Jan 2024 14:26:35 GMT, Hima Bindu Meda wrote: > Clean Backport. This pull request has now been integrated. Changeset: 9336ba77 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/9336ba774e0e4ef06291b0785f3919a9932a0eca Stats: 289254 lines in 6439 fi

RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes

2024-01-25 Thread Hima Bindu Meda
Cherry-picked changes related to webkit-2.42.4.Verified build on all platforms. Sanity testing looks fine. - Commit messages: - Resolve compilation error - Cherrypick changes related to 2.42.4 Changes: https://git.openjdk.org/jfx/pull/1350/files Webrev: https://webrevs.openjdk.or

Re: RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes [v2]

2024-01-26 Thread Hima Bindu Meda
> Cherry-picked changes related to webkit-2.42.4.Verified build on all > platforms. Sanity testing looks fine. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Minor corrections as per review comments - C

Re: RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes [v2]

2024-01-26 Thread Hima Bindu Meda
On Thu, 25 Jan 2024 15:46:24 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minor corrections as per review comments > > modules/javafx.web/src/main/n

Re: RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes [v3]

2024-01-28 Thread Hima Bindu Meda
> Cherry-picked changes related to webkit-2.42.4.Verified build on all > platforms. Sanity testing looks fine. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: space corrections - Changes: - all:

Integrated: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes

2024-01-29 Thread Hima Bindu Meda
On Thu, 25 Jan 2024 13:32:21 GMT, Hima Bindu Meda wrote: > Cherry-picked changes related to webkit-2.42.4.Verified build on all > platforms. Sanity testing looks fine. This pull request has now been integrated. Changeset: 52840a17 Author: Hima Bindu Meda URL:

[jfx22u] RFR: 8324337: Cherry-pick WebKit 617.1 stabilization fixes

2024-01-30 Thread Hima Bindu Meda
Clean Backport - Commit messages: - Backport 52840a17dee6a92fb9b1f3ff1b314b0ae228b95f Changes: https://git.openjdk.org/jfx22u/pull/7/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=7&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324337 Stats: 1297 lines in 161

[jfx22u] Integrated: 8324337: Cherry-pick WebKit 617.1 stabilization fixes

2024-01-30 Thread Hima Bindu Meda
On Tue, 30 Jan 2024 11:56:35 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: a247278f Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/a247278f9818265e1d012981ea7a6fcc2748185a Stats: 1297 lines in 161 fi

RFR: 8325258: Cherry-pick WebKit 617.1 stabilization fixes (2)

2024-02-09 Thread Hima Bindu Meda
Cherry-picked changes related to webkit-2.42.5. Verified build on all platforms. Sanity testing looks fine. - Commit messages: - white space correction - commit 3d5373575695b293b8559155431d0079a6153aff from webkitglib/2.42 to resolve build error on 32 bit - cherry-pick 2.42.5 C

Integrated: 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5

2024-02-11 Thread Hima Bindu Meda
On Fri, 9 Feb 2024 17:05:53 GMT, Hima Bindu Meda wrote: > Ported changes related to webkit-2.42.5. Verified build on all platforms. > Sanity testing looks fine. This pull request has now been integrated. Changeset: a7f6de8d Author: Hima Bindu Meda URL: https://git.openjdk.o

[jfx22u] Integrated: 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5

2024-02-12 Thread Hima Bindu Meda
On Mon, 12 Feb 2024 15:46:41 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: 82618d0e Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/82618d0e41806df238128b7199a09bf208ebb428 Stats: 1877 lines in 128 fi

[jfx22u] Integrated: 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5

2024-02-12 Thread Hima Bindu Meda
Clean Backport - Commit messages: - Backport a7f6de8d13fd7a7e37ca80b28badcb24566153d8 Changes: https://git.openjdk.org/jfx22u/pull/11/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=11&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8325258 Stats: 1877 lines in 12

Re: RFR: 8323880: Caret rendered at wrong position in case of a click event on RTL text

2024-02-15 Thread Hima Bindu Meda
On Tue, 13 Feb 2024 16:57:37 GMT, Jay Bhaskar wrote: > Issue: The current implementation of complex text rendering paths on the Java > platform is experiencing side effects. > Solution: We need to align with WebKit 616.1 standards. The patch supports > two paths simple rendering path and compl

RFR: 8326989 : Text selection issues on WebView after WebKit 617.1

2024-03-06 Thread Hima Bindu Meda
Text Selection issue is observed due to a pending layout call. This issue is resolved by a call to the method "updateSelectionAppearanceNow". Verified Sanity testing and unit test verification looks fine. No issue seen. Note: Unit test in order to validate the fix, is in progress. Due to the ro

Integrated: 8326989 : Text selection issues on WebView after WebKit 617.1

2024-03-06 Thread Hima Bindu Meda
On Wed, 6 Mar 2024 14:51:40 GMT, Hima Bindu Meda wrote: > Text Selection issue is observed due to a pending layout call. This issue is > resolved by a call to the method "updateSelectionAppearanceNow". > Verified Sanity testing and unit test verification looks fine. No is

[jfx22u] RFR: 8326989: Text selection issues on WebView after WebKit 617.1

2024-03-07 Thread Hima Bindu Meda
Clean Backport - Commit messages: - Backport 64af987576214fc5483520ce8131895be74a641d Changes: https://git.openjdk.org/jfx22u/pull/18/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=18&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326989 Stats: 5 lines in 1 fil

[jfx22u] Integrated: 8326989: Text selection issues on WebView after WebKit 617.1

2024-03-07 Thread Hima Bindu Meda
On Thu, 7 Mar 2024 12:43:17 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: 419bad3a Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/419bad3a4053abe215329a5228789f2c876ab287 Stats: 5 lines in 1 file changed

RFR: 8324326: Update ICU4C to 74.2

2024-03-12 Thread Hima Bindu Meda
Updated icu to v74.2. Sanity testing looks fine. Verified build on all platforms - Commit messages: - Revert file permissions similar to master - Tab correction - Resolve PR error - Tab Correction - Merge branch 'master' into icu-74 - updated LICENSE - white space corrections

Re: RFR: 8324326: Update ICU4C to 74.2

2024-03-12 Thread Hima Bindu Meda
On Tue, 12 Mar 2024 15:02:48 GMT, Kevin Rushforth wrote: >> modules/javafx.web/src/main/native/Source/ThirdParty/icu/CMakeLists.txt line >> 593: >> >>> 591: >>> 592: # Get just file name without extension >>> 593: set(ICU_DATA_FILE_NAME "icudt74l") >> >> Shouldn't this be 742? > > Never mind.

Integrated: 8324326: Update ICU4C to 74.2

2024-03-18 Thread Hima Bindu Meda
On Tue, 12 Mar 2024 14:45:06 GMT, Hima Bindu Meda wrote: > Updated icu to v74.2. Sanity testing looks fine. Verified build on all > platforms This pull request has now been integrated. Changeset: ad3d44e2 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx/

[jfx22u] Integrated: 8324326: Update ICU4C to 74.2

2024-03-19 Thread Hima Bindu Meda
Clean Backport - Commit messages: - Backport ad3d44e27f8ffb90aad81497f0bba2b00f7a49aa Changes: https://git.openjdk.org/jfx22u/pull/20/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=20&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324326 Stats: 10765 lines in

[jfx22u] Integrated: 8324326: Update ICU4C to 74.2

2024-03-19 Thread Hima Bindu Meda
On Tue, 19 Mar 2024 16:32:55 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: 32378354 Author: Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/323783541140bea2119e2e59d0bb2d8d1fb37c8a Stats: 10765 lines in 123 fi

Re: RFR: 8328749: Remove unused imports in javafx.web [v2]

2024-03-26 Thread Hima Bindu Meda
On Fri, 22 Mar 2024 16:11:52 GMT, Andy Goryachev wrote: >> Using Eclipse IDE to remove unused imports **javafx.web** module, and update >> the copyright year to 2024. Using wildcard for more than 10 static imports. >> >> >> -- >> >> This is a trivial change, 1 reviewer is probably enough. > >

Re: RFR: 8328749: Remove unused imports in javafx.web [v2]

2024-03-26 Thread Hima Bindu Meda
On Fri, 22 Mar 2024 16:11:52 GMT, Andy Goryachev wrote: >> Using Eclipse IDE to remove unused imports **javafx.web** module, and update >> the copyright year to 2024. Using wildcard for more than 10 static imports. >> >> >> -- >> >> This is a trivial change, 1 reviewer is probably enough. > >

RFR: 8292609 : Cherry-pick WebKit 614.1 stabilization fixes

2022-08-26 Thread Hima Bindu Meda
Stabilization fixes from WebKitGTK 2.36.7. Verified drt and unit tests on Mac, Windows and Linux platforms. - Commit messages: - Cherry-pick WebKit 614.1 stabilization fixes Changes: https://git.openjdk.org/jfx/pull/885/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=885&ran

Integrated: 8292609 : Cherry-pick WebKit 614.1 stabilization fixes

2022-08-29 Thread Hima Bindu Meda
On Fri, 26 Aug 2022 11:51:04 GMT, Hima Bindu Meda wrote: > Stabilization fixes from WebKitGTK 2.36.7. > Verified drt and unit tests on Mac, Windows and Linux platforms. This pull request has now been integrated. Changeset: da580ba4 Author: Hima Bindu Meda Committer: Kevin Rushfort

RFR: JDK-8289541 : Update ICU4C to 71.1

2022-09-08 Thread Hima Bindu Meda
Updated icu to v71.1. Verified build and sanity testing on windows,Mac and Linux. Removed icu directory from Source/WTF, as the functionality is already provided by Source/ThirdParty/icu - Commit messages: - Update file permission for rbbicst.pl - update file permission - Remove t

Re: RFR: JDK-8289541 : Update ICU4C to 71.1 [v2]

2022-09-08 Thread Hima Bindu Meda
> Updated icu to v71.1. > Verified build and sanity testing on windows,Mac and Linux. > Removed icu directory from Source/WTF, as the functionality is already > provided by Source/ThirdParty/icu Hima Bindu Meda has updated the pull request incrementally with one additional commit si

Re: RFR: JDK-8289541 : Update ICU4C to 71.1

2022-09-08 Thread Hima Bindu Meda
On Thu, 8 Sep 2022 15:34:32 GMT, Kevin Rushforth wrote: > One quick comment. I noticed that several files have changed from Unix-style > line endings to DOS-style (CRLF) line endings. These are all extensions that > aren't in our list of ones to check for whitespace (so jcheck won't catch > th

Re: RFR: JDK-8289541 : Update ICU4C to 71.1 [v3]

2022-09-08 Thread Hima Bindu Meda
> Updated icu to v71.1. > Verified build and sanity testing on windows,Mac and Linux. > Removed icu directory from Source/WTF, as the functionality is already > provided by Source/ThirdParty/icu Hima Bindu Meda has updated the pull request incrementally with one additional commit si

Re: RFR: JDK-8289541 : Update ICU4C to 71.1 [v3]

2022-09-08 Thread Hima Bindu Meda
On Thu, 8 Sep 2022 17:00:56 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert CMakelists.txt to be same as master > > modules/javafx.web/src/main/native/

Re: RFR: JDK-8289541 : Update ICU4C to 71.1 [v4]

2022-09-08 Thread Hima Bindu Meda
> Updated icu to v71.1. > Verified build and sanity testing on windows,Mac and Linux. > Removed icu directory from Source/WTF, as the functionality is already > provided by Source/ThirdParty/icu Hima Bindu Meda has updated the pull request incrementally with one additional commit si

Re: RFR: JDK-8289541 : Update ICU4C to 71.1 [v5]

2022-09-21 Thread Hima Bindu Meda
> Updated icu to v71.1. > Verified build and sanity testing on windows,Mac and Linux. > Removed icu directory from Source/WTF, as the functionality is already > provided by Source/ThirdParty/icu Hima Bindu Meda has updated the pull request incrementally with one additional commit si

Re: RFR: JDK-8289541 : Update ICU4C to 71.1 [v6]

2022-09-21 Thread Hima Bindu Meda
> Updated icu to v71.1. > Verified build and sanity testing on windows,Mac and Linux. > Removed icu directory from Source/WTF, as the functionality is already > provided by Source/ThirdParty/icu Hima Bindu Meda has updated the pull request incrementally with one additional commit si

Re: RFR: JDK-8289541 : Update ICU4C to 71.1 [v5]

2022-09-21 Thread Hima Bindu Meda
On Wed, 21 Sep 2022 13:17:34 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update icu_web.md > > modules/javafx.web/src/main/legal/icu_web.md line 446:

Integrated: JDK-8289541 : Update ICU4C to 71.1

2022-09-22 Thread Hima Bindu Meda
On Wed, 7 Sep 2022 18:13:43 GMT, Hima Bindu Meda wrote: > Updated icu to v71.1. > Verified build and sanity testing on windows,Mac and Linux. > Removed icu directory from Source/WTF, as the functionality is already > provided by Source/ThirdParty/icu This pull request has now bee

Re: RFR: 8293795: [Accessibility] [Win] [Narrator] Exceptions when deleting text with continous key press in TextArea and TextField [v3]

2022-10-04 Thread Hima Bindu Meda
On Mon, 3 Oct 2022 14:40:27 GMT, Ambarish Rapte wrote: >> This is a follow up bug-fix to >> [JDK-8284281](https://bugs.openjdk.org/browse/JDK-8284281) >> >> Issue: >> When Narrator is running, >> Following scenarios with TextField or TextArea cause >> IllegalArgumentException or NPE >> >> 1.

RFR: JDK-8295755 : Update SQLite to 3.39.4

2022-11-21 Thread Hima Bindu Meda
Updated sqlite to v3.39.4 Verified build on windows, linux and mac. Sanity testing looks fine. - Commit messages: - Update Sqlite to v3.39.4 Changes: https://git.openjdk.org/jfx/pull/953/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=953&range=00 Issue: https://bugs.openj

Integrated: JDK-8295755 : Update SQLite to 3.39.4

2022-12-09 Thread Hima Bindu Meda
On Thu, 17 Nov 2022 06:16:34 GMT, Hima Bindu Meda wrote: > Updated sqlite to v3.39.4 > Verified build on windows, linux and mac. > Sanity testing looks fine. This pull request has now been integrated. Changeset: 9f6ec88b Author:Hima Bindu Meda Committer: Kevin Rushforth URL:

RFR: JDK-8299977 : Update WebKit to 615.1

2023-01-25 Thread Hima Bindu Meda
Update JavaFX WebKit to GTK WebKit 2.38 (615.1). Verified the updated version build, sanity tests and stability. This does not cause any issues except one unit test failure. Also, there are some artifacts observed while playing youtube The above issues are recorded and ignored using below bugs: [

Re: RFR: JDK-8299977 : Update WebKit to 615.1 [v2]

2023-01-30 Thread Hima Bindu Meda
recorded and ignored using below bugs: > [JDK-8300954](https://bugs.openjdk.org/browse/JDK-8300954) > [JDK-8301022](https://bugs.openjdk.org/browse/JDK-8301022) Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Add blank lines

Re: RFR: JDK-8299977 : Update WebKit to 615.1 [v3]

2023-01-31 Thread Hima Bindu Meda
recorded and ignored using below bugs: > [JDK-8300954](https://bugs.openjdk.org/browse/JDK-8300954) > [JDK-8301022](https://bugs.openjdk.org/browse/JDK-8301022) Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Remove the lo

Integrated: JDK-8299977 : Update WebKit to 615.1

2023-02-01 Thread Hima Bindu Meda
On Wed, 25 Jan 2023 19:51:02 GMT, Hima Bindu Meda wrote: > Update JavaFX WebKit to GTK WebKit 2.38 (615.1). > > Verified the updated version build, sanity tests and stability. > This does not cause any issues except one unit test failure. > Also, there are some artifacts observe

Re: RFR: 8301712: [linux] Crash on exit from WebKit 615.1

2023-02-08 Thread Hima Bindu Meda
On Wed, 8 Feb 2023 13:51:29 GMT, Jay Bhaskar wrote: > Issue: [linux] Crash on exit from WebKit 615.1 Crash dump observed on Window > exit > Root cause: Accessing local storage data of a thread having client data like > font cache during VM shutdown > Solution: Add a shutdown hook to ThreadTimer

Re: RFR: 8301712: [linux] Crash on exit from WebKit 615.1

2023-02-08 Thread Hima Bindu Meda
On Wed, 8 Feb 2023 13:51:29 GMT, Jay Bhaskar wrote: > Issue: [linux] Crash on exit from WebKit 615.1 Crash dump observed on Window > exit > Root cause: Accessing local storage data of a thread having client data like > font cache during VM shutdown > Solution: Add a shutdown hook to ThreadTimer

RFR: 8302294 : Cherry-pick WebKit 615.1 stabilization fixes

2023-02-14 Thread Hima Bindu Meda
Cherry-pick stabilisation fixes till 2.38.4. Verified unit tests and drt. No issue observed. - Commit messages: - Cherry-pick WebKit 614.1 stabilization fixes till 2.38.4 Changes: https://git.openjdk.org/jfx/pull/1033/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1033&rang

Integrated: 8302294 : Cherry-pick WebKit 615.1 stabilization fixes

2023-02-15 Thread Hima Bindu Meda
On Tue, 14 Feb 2023 18:19:17 GMT, Hima Bindu Meda wrote: > Cherry-pick stabilisation fixes till 2.38.4. > Verified unit tests and drt. No issue observed. This pull request has now been integrated. Changeset: 97ae4b87 Author: Hima Bindu Meda Committer: Kevin Rushforth URL:

RFR: 8302684 : Cherry-pick WebKit 615.1 stabilization fixes (2)

2023-02-16 Thread Hima Bindu Meda
Stabilization fixes from Webkitgtk-2.38.5. Verified drt and unit tests. No issues observed. - Commit messages: - white space correction - Cherry-pick stabilisation fixes till 2.38.5 Changes: https://git.openjdk.org/jfx/pull/1038/files Webrev: https://webrevs.openjdk.org/?repo=jfx&

Integrated: 8302684 : Cherry-pick WebKit 615.1 stabilization fixes (2)

2023-02-17 Thread Hima Bindu Meda
On Thu, 16 Feb 2023 19:29:26 GMT, Hima Bindu Meda wrote: > Stabilization fixes from Webkitgtk-2.38.5. > Verified drt and unit tests. No issues observed. This pull request has now been integrated. Changeset: 67c2b7a1 Author: Hima Bindu Meda Committer: Kevin Rushforth URL:

Re: RFR: 8301022: Video distortion is observed while playing youtube video [v2]

2023-02-22 Thread Hima Bindu Meda
On Wed, 22 Feb 2023 12:36:44 GMT, Jay Bhaskar wrote: >> Issue: current update is breaking the rendering of media controls on youtube >> video playback >>For the Webkit Gtk platform, the layout class name is returned as >> AdwaitaLayoutTraits >>which is incompatible with

RFR: 8300954 : Unit test related to range input type in FormsControlsTest is failing

2023-02-27 Thread Hima Bindu Meda
With this fix, default slider of input type: Range is rendered properly. Verified build and unit tests.DRT tests related to "Range", also pass with this fix. - Commit messages: - Resolve build error - Fix for rendering slider of input type:range Changes: https://git.openjdk.org/jf

Withdrawn: 8300954 : HTML default Range input control not rendered

2023-02-28 Thread Hima Bindu Meda
On Mon, 27 Feb 2023 18:56:35 GMT, Hima Bindu Meda wrote: > With this fix, default slider of input type: Range is rendered properly. > Verified build and unit tests.DRT tests related to "Range", also pass with > this fix. This pull request has been closed witho

Re: RFR: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements [v9]

2023-03-06 Thread Hima Bindu Meda
On Mon, 6 Mar 2023 12:55:51 GMT, Jay Bhaskar wrote: >> Issue: default html5 video element not showing media controls >> Details: Media control design has been refactored in the current Webkit Gtk >> port. The CSS id >> and properties related to media buttons, and slider have >>

RFR: 8301009: Update libxml2 to 2.10.3

2023-03-14 Thread Hima Bindu Meda
Updated Libxml2 to v2.10.3. verfied build and sanity testing on windows, mac and Linux platforms. No issue observed. - Commit messages: - White space corrections - white space correction - update libxml2.md - Remove unwanted files - configure libxml to v2.10.3 on linux - config

Integrated: 8301009: Update libxml2 to 2.10.3

2023-03-16 Thread Hima Bindu Meda
On Tue, 14 Mar 2023 08:04:04 GMT, Hima Bindu Meda wrote: > Updated Libxml2 to v2.10.3. verfied build and sanity testing on windows, mac > and Linux platforms. > No issue observed. This pull request has now been integrated. Changeset: 935c7b79 Author:Hima Bindu Meda URL:

RFR: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23

2023-03-31 Thread Hima Bindu Meda
In Jenkins Build, the intermediate failure on windows is observed due to crash in mspdbserv.exe, which generates Program database (.pdb) files. Disabled the pdb file generation in order to resolve the build failure. Sanity testing looks fine. Verified build on windows, mac and linux.

Re: RFR: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23 [v2]

2023-04-02 Thread Hima Bindu Meda
ac and linux. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Add code under Java port - Changes: - all: https://git.openjdk.org/jfx/pull/1079/files - new: https://git.openjdk.org/jfx/pull/1079/files/0ef66c0b..d21b9

Re: RFR: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23 [v3]

2023-04-03 Thread Hima Bindu Meda
ac and linux. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: remove white space - Changes: - all: https://git.openjdk.org/jfx/pull/1079/files - new: https://git.openjdk.org/jfx/pull/1079/files/d21b94a6..5b80745d Webr

Re: RFR: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23 [v3]

2023-04-03 Thread Hima Bindu Meda
On Mon, 3 Apr 2023 13:25:34 GMT, Kevin Rushforth wrote: >> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove white space > > modules/javafx.web/src/main/native/Source/cmake/OptionsMSVC

Re: RFR: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23 [v4]

2023-04-03 Thread Hima Bindu Meda
ac and linux. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: Update proper comment - Changes: - all: https://git.openjdk.org/jfx/pull/1079/files - new: https://git.openjdk.org/jfx/pull/1079/files/5b80745d..16650

Integrated: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23

2023-04-04 Thread Hima Bindu Meda
On Fri, 31 Mar 2023 07:57:11 GMT, Hima Bindu Meda wrote: > In Jenkins Build, the intermediate failure on windows is observed due to > crash in mspdbserv.exe, which generates Program database (.pdb) files. > Disabled the pdb file generation in order to resolve the build failure. > Sa

[jfx20u] RFR: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23

2023-04-10 Thread Hima Bindu Meda
Clean Backport.This pull request contains a backport of commit [a264435d](https://github.com/openjdk/jfx/commit/a264435dccba6ec386548f76f1ace095d943f4ca) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. - Commit messages: - Backport a264435dccba6ec386548f76f1ace095d9

[jfx20u] Integrated: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23

2023-04-10 Thread Hima Bindu Meda
On Mon, 10 Apr 2023 17:21:34 GMT, Hima Bindu Meda wrote: > Clean Backport.This pull request contains a backport of commit > [a264435d](https://github.com/openjdk/jfx/commit/a264435dccba6ec386548f76f1ace095d943f4ca) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.

[jfx20u] Integrated: 8301009: Update libxml2 to 2.10.3

2023-04-11 Thread Hima Bindu Meda
Clean Backport.This pull request contains a backport of commit [935c7b79](https://github.com/openjdk/jfx/commit/935c7b797d79407d741735324313684617d1292d) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. - Commit messages: - Backport 935c7b797d79407d741735324313684617

[jfx20u] Integrated: 8301009: Update libxml2 to 2.10.3

2023-04-11 Thread Hima Bindu Meda
On Tue, 11 Apr 2023 17:03:51 GMT, Hima Bindu Meda wrote: > Clean Backport.This pull request contains a backport of commit > [935c7b79](https://github.com/openjdk/jfx/commit/935c7b797d79407d741735324313684617d1292d) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.

RFR: 8306115 : Update libxml2 to 2.10.4

2023-04-23 Thread Hima Bindu Meda
Updated libxml to v2.10.4.Configured and verified on all Windows, Linux and Mac. Sanity testing looks fine. - Commit messages: - version update for linux - update xmlversion on windows - Update version info - White space corrections - Update libxml to v2.10.4 Changes: https://gi

Integrated: 8306115 : Update libxml2 to 2.10.4

2023-04-25 Thread Hima Bindu Meda
On Fri, 21 Apr 2023 10:34:49 GMT, Hima Bindu Meda wrote: > Updated libxml to v2.10.4.Configured and verified on all Windows, Linux and > Mac. > Sanity testing looks fine. This pull request has now been integrated. Changeset: cf5b8389 Author:Hima Bindu Meda URL:

  1   2   >