On Mon, 24 Jul 2023 02:50:30 GMT, Jay Bhaskar <jbhas...@openjdk.org> wrote:
> > Oh, I see that now. What led me to ask this question was that there is an > > alternative implementation in `#if PLATFORM(JAVA)`, which implies that we > > removed the call to `stripLeadingAndTrailingHTMLSpaces` and that it is > > still present in the upstream. > > Given that this code block now matches the upstream, the `if..else..endif` > > block should simply be replaced with: > > ``` > > return document().completeURL(linkAttribute); > > ``` > > > > > > > > > > > > > > > > > > > > > > > > removing the `#if PLATFORM(JAVA)` and the entire `#else` block (including > > the old call to `stripLeadingAndTrailingHTMLSpaces`). Otherwise it will be > > confusing and possibly lead to merge conflicts later. > > I agree with this. Is there a reason this can't be done in the current PR? Pushed the change. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1180#issuecomment-1647811198
