Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v13]

2025-04-18 Thread John Hendrikx
On Wed, 12 Mar 2025 01:28:49 GMT, Nir Lisker wrote: > Finished the 2nd part of the implementation review. I didn't delve into the > logic of the listener management, but it looks sane :) > > I'll review the tests as the final part. @nlisker did you have time to look at the final part? ---

Re: RFR: 8354795: DialogPane show details button wipes out base style class "hyperlink"

2025-04-18 Thread John Hendrikx
On Thu, 17 Apr 2025 21:19:09 GMT, Andy Goryachev wrote: > > If you use a `Hyperlink` control, you also want the result to be hyperlinky > > and inherit all the hyperlinky styles > > not necessarily, if you want all the functionality but different visuals. > > BTW, the circular button in the Di

Re: RFR: 8354795: DialogPane show details button wipes out base style class "hyperlink"

2025-04-18 Thread Andy Goryachev
On Fri, 18 Apr 2025 09:22:27 GMT, John Hendrikx wrote: >> I can confirm that we don't use these `//$NON-NLS-*` comments in javaFX. >> >> `` >> These comments were invented as a way to solve the localization problem. >> The problem is real, but the "solution" was exactly the opposite. Instead

Re: RFR: 8354876: Update SQLite to 3.49.1

2025-04-18 Thread Kevin Rushforth
On Fri, 18 Apr 2025 12:03:22 GMT, Jay Bhaskar wrote: > As part of the current WebKit JFX upgrade, it is required to update sqlite to > compatible versions. Additionally, this release addresses known issues from > the previous version to improve stability and performance. Reviewers: @tiainen @k

Re: RFR: 8352162: Update libxml2 to 2.13.6 [v2]

2025-04-18 Thread Kevin Rushforth
On Fri, 18 Apr 2025 14:36:26 GMT, Jay Bhaskar wrote: >> As part of the current WebKit JFX upgrade, it is required to update libxml >> and libxslt to compatible versions. Additionally, this release addresses >> several known issues from the previous version to improve stability and >> performa

Re: RFR: 8354795: DialogPane show details button wipes out base style class "hyperlink"

2025-04-18 Thread John Hendrikx
On Thu, 17 Apr 2025 21:06:08 GMT, Andy Goryachev wrote: >> I'll double check and will let you know tomorrow. >> >> A code search shows that these are only used in 5 classes: ButtonBar, >> ButtonBarSkin, Dialog, DialogPane, Properties, so chances are it's a digital >> fossil. > > I can confirm

Integrated: 8354794: [TestBug] LocalDateTimeStringConverterTest: Not all Tests needs to be parameterized

2025-04-18 Thread Marius Hanl
On Wed, 16 Apr 2025 18:23:01 GMT, Marius Hanl wrote: > As discussed in #1778, those test does not need to be parameterized, we > therefore can replace `@ParameterizedTest` and `@MethodSource` with `@Test`. This pull request has now been integrated. Changeset: a25935d1 Author:Marius Hanl U

Re: RFR: 8354795: DialogPane show details button wipes out base style class "hyperlink"

2025-04-18 Thread Andy Goryachev
On Fri, 18 Apr 2025 09:26:43 GMT, John Hendrikx wrote: > So... you want me to add more styles so it then ends up looking like a > correctly colored hyperlink? No. I would like to retain the existing functionality where the styles alternate between `[ "details-button", "less" ]` and `[ "detail

Re: RFR: 8352162: Update libxml2 to 2.13.6 and libxslt to 1.1.43

2025-04-18 Thread Kevin Rushforth
On Fri, 18 Apr 2025 05:41:38 GMT, Jay Bhaskar wrote: > As part of the current WebKit JFX upgrade, it is required to update libxml > and libxslt to compatible versions. Additionally, this release addresses > several known issues from the previous version to improve stability and > performance.

Re: RFR: 8354876: Update SQLite to 3.49.1

2025-04-18 Thread Kevin Rushforth
On Fri, 18 Apr 2025 12:03:22 GMT, Jay Bhaskar wrote: > As part of the current WebKit JFX upgrade, it is required to update sqlite to > compatible versions. The SQLite library is used by WebKit, but is updated independently. So this isn't related to the recent WebKit update. Please update the d

Re: RFR: 8352162: Update libxml2 to 2.13.6 [v2]

2025-04-18 Thread Jay Bhaskar
> As part of the current WebKit JFX upgrade, it is required to update libxml > and libxslt to compatible versions. Additionally, this release addresses > several known issues from the previous version to improve stability and > performance. Jay Bhaskar has updated the pull request incrementall

Re: RFR: 8354702: [TestBug] LocalDateTimeStringConverterTest Workaround can be removed

2025-04-18 Thread Marius Hanl
On Thu, 17 Apr 2025 18:09:57 GMT, Andy Goryachev wrote: > both tickets are a duplicate of https://bugs.openjdk.org/browse/JDK-8264061 > fixed in jfx17, closed both. thanks! I don't want to close them when I was just testing them! So thank you for validating both tickets! :) - PR

RFR: 8352162: Update libxml2 to 2.13.6 and libxslt to 1.1.43

2025-04-18 Thread Jay Bhaskar
As part of the current WebKit JFX upgrade, it is required to update libxml and libxslt to compatible versions. Additionally, this release addresses several known issues from the previous version to improve stability and performance. - Commit messages: - white space fix remainings

Re: Proposal: A new common Image API

2025-04-18 Thread Glavo
Hi John, Thank you very much for your reply. I think you are actually talking about two problems: For compact storage, I think the first choice would be something like PixelBuffer. Pixels can be stored in MemorySegment. When the pixel format needs to be converted, it is easier to accelerate using

RFR: 8354876: Update SQLite to 3.49.1

2025-04-18 Thread Jay Bhaskar
As part of the current WebKit JFX upgrade, it is required to update sqlite to compatible versions. Additionally, this release addresses known issues from the previous version to improve stability and performance. - Commit messages: - whitespace error cleanup - update sqllite Chan

Re: RFR: 8354795: DialogPane show details button wipes out base style class "hyperlink"

2025-04-18 Thread John Hendrikx
On Thu, 17 Apr 2025 15:58:28 GMT, Andy Goryachev wrote: > I've added the Dialog page to the monkey tester > https://github.com/andy-goryachev-oracle/MonkeyTest > > Looking at the stock behavior, I don't really see the problem. The > .details-button should not _look_ a hyperlink (despite being

Withdrawn: 8354480: A Stage should allow simultaneous iconified and maximized states

2025-04-18 Thread Thiago Milczarek Sayao
On Sun, 13 Apr 2025 17:46:58 GMT, Thiago Milczarek Sayao wrote: > On some platforms (at least on Ubuntu 24.04 with GNOME and Windows 11), > windows can remain maximized even when they are iconified (minimized). When > the window is de-iconified (restored), it retains its maximized state. > >

Re: RFR: 8169285: Re-enable javafx.swt tests [v2]

2025-04-18 Thread Marius Hanl
> With this change, you can now run the `swt` tests as easy as: `:swt:test > -PSWT_TEST=true`. > ![image](https://github.com/user-attachments/assets/928141b5-ac81-4b15-9d86-5ea87f47c1c4) > > Note: At one point `IS_FULL_TEST` was used as well for the enablement of the > tests. I don't see any rea

Re: RFR: 8354795: DialogPane show details button wipes out base style class "hyperlink"

2025-04-18 Thread Andy Goryachev
On Thu, 17 Apr 2025 19:19:13 GMT, John Hendrikx wrote: > I think it _should_ look like a hyperlink It might look like a hyperlink, but it has a different semantics (semantics of a hyperlink is to navigate to some other place). When application wants to change the hyperlink styling, we don't

Re: RFR: 8296554: MouseLocationOnScreenTest sometime fails when system is busy [v5]

2025-04-18 Thread Andy Goryachev
On Thu, 17 Apr 2025 05:57:12 GMT, Gopal Pattnaik wrote: >> There was a Assertion fail issue in mouse location test case JDK-8296554, >> Reason: We felt the one mili second delay time for the Robot test may be >> insufficient in few OS. >> Solution: We Changed the delay time to three mili second.

Re: RFR: 8296554: MouseLocationOnScreenTest sometime fails when system is busy [v5]

2025-04-18 Thread Gopal Pattnaik
> There was a Assertion fail issue in mouse location test case JDK-8296554, > Reason: We felt the one mili second delay time for the Robot test may be > insufficient in few OS. > Solution: We Changed the delay time to three mili second. > > Verification: > Tested in Windows 11, and the Assert fai

Re: RFR: 8347359: RichTextArea API Tests [v7]

2025-04-18 Thread Andy Goryachev
> Additional RichTextArea API tests. Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits: - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests - Merge remote-tracking branch 'origin/master'

Re: Re[2]: Proposal: A new common Image API

2025-04-18 Thread Glavo
Hi Jeremy, The purpose of my email is to: 1. Find out if people feel the work is worth the effort. 2. Find out if there is anyone willing to take the lead. 3. Discuss how this work will begin. I did have a draft design, but I was not an expert in the field, so I knew it had a lot of fl

Re: RFR: 8329227: Seek might hang with fMP4 H.265/HEVC or H.265/HEVC over HTTP/FILE

2025-04-18 Thread Kevin Rushforth
On Sat, 12 Apr 2025 01:43:29 GMT, Alexander Matveev wrote: > - Fixed by reloading decoder for each seek. > - Tested with all H.265 files for HLS/HTTP/FILE, no issues found. > - Seek performance is not affected or at least I did not notice any > performance issues when doing reload for each seek