On Thu, 17 Apr 2025 15:58:28 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> I've added the Dialog page to the monkey tester > https://github.com/andy-goryachev-oracle/MonkeyTest > > Looking at the stock behavior, I don't really see the problem. The > .details-button should not _look_ a hyperlink (despite being implemented > using Hyperlink control), so the code seems to be correct in that it replaces > the hyperlink style with something else. > > What we probably need for the dark mode is to update the stylesheet as you > described in the ticket. > > What do you think? I think it _should_ look like a hyperlink, as the choices of potential clickable controls that users will recognize as such is limited; it can be either a button, checkbox or hyperlink. You can't just define something new and expect users to understand it at a glance; and why even do so for an alert dialog? This is clearly intended to mimic other standard alert dialogs that use the same kind of button to display details. There are so many things dependent on the base style in modena, not having a base style is highly unusual and in this case IMHO a clear mistake in how the styles are being applied. It just wasn't caught in testing as the default color matches close enough, but becomes rather obvious when changing the base colors significantly. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1779#issuecomment-2813824295
