Re: RFR: 8345348: CSS media feature queries [v9]

2025-04-12 Thread Michael Strauß
On Sat, 12 Apr 2025 18:32:57 GMT, John Hendrikx wrote: > With some minimal style changes (and a hack to change the window border to > dark mode on Windows) I get this out of modena.css: Nice! Once we have a per-scene color scheme, I plan to have window borders adjust to the color scheme of the

Re: RFR: 8345348: CSS media feature queries [v9]

2025-04-12 Thread John Hendrikx
On Sat, 12 Apr 2025 20:01:44 GMT, Michael Strauß wrote: > By the way, can I interest you in a review of this PR? Yes, I already partially checked it out, and was intending to do a closer review soon. - PR Comment: https://git.openjdk.org/jfx/pull/1655#issuecomment-2799045186

Re: RFR: 8345348: CSS media feature queries [v11]

2025-04-12 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: change indentation - Changes: - all: https://git.openjdk.org

Re: RFR: 8329227: Seek might hang with fMP4 H.265/HEVC or H.265/HEVC over HTTP/FILE

2025-04-12 Thread Kevin Rushforth
On Sat, 12 Apr 2025 01:43:29 GMT, Alexander Matveev wrote: > - Fixed by reloading decoder for each seek. > - Tested with all H.265 files for HLS/HTTP/FILE, no issues found. > - Seek performance is not affected or at least I did not notice any > performance issues when doing reload for each seek

Re: RFR: 8345348: CSS media feature queries [v9]

2025-04-12 Thread John Hendrikx
On Fri, 11 Apr 2025 22:57:51 GMT, Andy Goryachev wrote: > > You seem to be arguing against media queries themselves > > Probably. I am afraid the CSS subsystem will grow into a monster (I mean, it > already is). > > The follow up question is what you guys think about updating `modena.css` to

Re: RFR: 8345348: CSS media feature queries [v9]

2025-04-12 Thread Michael Strauß
On Fri, 11 Apr 2025 22:57:51 GMT, Andy Goryachev wrote: > > You seem to be arguing against media queries themselves > > Probably. I am afraid the CSS subsystem will grow into a monster (I mean, it > already is). It is, and it’s held together by duct tape in many places. That’s why I think we

Re: RFR: 8313424: JavaFX controls in the title bar [v64]

2025-04-12 Thread Michael Strauß
> Implementation of > [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: don't show a right-click system menu in full-screen mode -

Re: RFR: 8354455: [TestBug] Remove JUnit Vintage Engine with JUnit 4

2025-04-12 Thread Kevin Rushforth
On Fri, 11 Apr 2025 21:01:13 GMT, Kevin Rushforth wrote: > For this specific case, this PR may be premature. We have closed tests that > still use JUnit 4, and this might break our build. I'll check next week. A quick initial test suggests that this will not be a problem after all. We do not u