Re: RFR: 8313424: JavaFX controls in the title bar [v59]

2025-03-23 Thread Michael Strauß
> Implementation of > [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) > and `EXTENDED_UTILITY` stage style. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: documentation - Changes: - al

Re: RFR: 8313424: JavaFX controls in the title bar [v49]

2025-03-23 Thread Michael Strauß
On Fri, 14 Feb 2025 17:22:03 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - typo >> - update copyright headers > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/HeaderButtonOverla

Re: RFR: 8313424: JavaFX controls in the title bar [v58]

2025-03-23 Thread Michael Strauß
> Implementation of > [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) > and `EXTENDED_UTILITY` stage style. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: documentation - Changes: - al

Re: RFR: 8313424: JavaFX controls in the title bar [v49]

2025-03-23 Thread Michael Strauß
On Tue, 18 Feb 2025 20:47:24 GMT, Andy Goryachev wrote: >> It's a bit like using deep reflection to access internals. It's technically >> possible, but explicitly unsupported. Much in the same way, any attempt to >> style header buttons can stop working at any time (because we're free to >> ch

Re: RFR: 8313424: JavaFX controls in the title bar [v22]

2025-03-23 Thread Michael Strauß
On Tue, 5 Nov 2024 23:00:36 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - HeaderBar changes >> - EMPTY Dimension2D constant >> - use CsvSource in HeaderBarTest > > modules/javafx.graph

Re: RFR: 8313424: JavaFX controls in the title bar [v49]

2025-03-23 Thread Michael Strauß
On Tue, 18 Feb 2025 20:16:27 GMT, Andy Goryachev wrote: >> Are we talking about the specification of the system-reserved insets in >> `HeaderBar`? Or do you suggest to link from `HeaderButtonMetrics` to >> `HeaderBar`? >> >> >> /** >> * Describes the size of the left system-reserved

Re: RFR: 8313424: JavaFX controls in the title bar [v56]

2025-03-23 Thread Michael Strauß
On Tue, 18 Mar 2025 21:36:59 GMT, Andy Goryachev wrote: > Standard windows buttons appear blurry and smaller at 100% scale: I've tweaked the scaling a bit, should be fixed. - PR Comment: https://git.openjdk.org/jfx/pull/1605#issuecomment-2746104110

Re: RFR: 8313424: JavaFX controls in the title bar [v57]

2025-03-23 Thread Michael Strauß
> Implementation of > [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) > and `EXTENDED_UTILITY` stage style. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: tweak header button scaling at 100%

Re: RFR: 8313424: JavaFX controls in the title bar [v45]

2025-03-23 Thread Michael Strauß
On Tue, 4 Feb 2025 12:59:39 GMT, Kevin Rushforth wrote: >> It's a bit more than just a generic handler, it basically encapsulates the >> entire behavior of a window button (including setting its visibility and >> disabled states). > > We generally use "Behavior" in the context of controls. Alth